Skip to contentSkip to conversation

docs/devicetree: mailbox: fix trivial typo

PATCH In review [email protected] 2 participants 2 messages May 10, 2020 – May 11, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs/devicetree: mailbox: fix trivial typo

From: Kangmin Park <[email protected]>

Fix node id typo in example

---
 Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt +1 -1
index 4438432..ad76edc 100644
@@ -87,7 +87,7 @@ Example:
 		ranges;
 
 		/* APU<->RPU0 IPI mailbox controller */
-		ipi_mailbox_rpu0: mailbox@ff90400 {
+		ipi_mailbox_rpu0: mailbox@ff990400 {
 			reg = <0xff990400 0x20>,
 			      <0xff990420 0x20>,
 			      <0xff990080 0x20>,
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · On 10. 05. 20 21:38, [email protected] wrote:

From: Kangmin Park <[email protected]>

Fix node id typo in example

I think it is more than typo. It is incorrect unit-address which doesn't match the first address specified in the reg property of the node.

Here is line from dt binding spec.
"The unit-address must match the first address specified in the reg property of the node."

Quoted 2 lines

IIRC subject should start with dt-bindings:

Quoted 10 lines
---
 Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt +0 -0
index 4438432..ad76edc 100644

Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt Example: · line 93

Quoted 8 lines
Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt +1 -1
@@ -87,7 +87,7 @@ Example:
 		ranges;
 
 		/* APU<->RPU0 IPI mailbox controller */
-		ipi_mailbox_rpu0: mailbox@ff90400 {
+		ipi_mailbox_rpu0: mailbox@ff990400 {
 			reg = <0xff990400 0x20>,
 			      <0xff990420 0x20>,
 			      <0xff990080 0x20>,

Change is correct.

With nits above applied please add my

Thanks,
Michal