Skip to contentSkip to conversation

drivers/of: keep description of function consistent with function name

PATCH Applied [email protected] 2 participants 2 messages May 11, 2020 – May 19, 2020 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/of: keep description of function consistent with function name

From: chenqiwu <[email protected]>

Currently, there are some descriptions of function not consistent with function name, fixing them will make the code more readable.

---
 drivers/of/fdt.c             |  2 +-
 drivers/of/of_reserved_mem.c | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/of/fdt.c +1 -1
index 2cdf64d..a86392a 100644
@@ -471,7 +471,7 @@ void *of_fdt_unflatten_tree(const unsigned long *blob,
 static u32 of_fdt_crc32;
 
 /**
- * res_mem_reserve_reg() - reserve all memory described in 'reg' property
+ * __reserved_mem_reserve_reg() - reserve all memory described in 'reg' property
  */
 static int __init __reserved_mem_reserve_reg(unsigned long node,
 					     const char *uname)
drivers/of/of_reserved_mem.c +5 -5
index 1a84bc0..6f6fea3 100644
@@ -46,7 +46,7 @@ static int __init early_init_dt_alloc_reserved_memory_arch(phys_addr_t size,
 }
 
 /**
- * res_mem_save_node() - save fdt node for second pass initialization
+ * fdt_reserved_mem_save_node() - save fdt node for second pass initialization
  */
 void __init fdt_reserved_mem_save_node(unsigned long node, const char *uname,
 				      phys_addr_t base, phys_addr_t size)
@@ -68,8 +68,8 @@ void __init fdt_reserved_mem_save_node(unsigned long node, const char *uname,
 }
 
 /**
- * res_mem_alloc_size() - allocate reserved memory described by 'size', 'align'
- *			  and 'alloc-ranges' properties
+ * __reserved_mem_alloc_size() - allocate reserved memory described by
+ *	'size', 'align'  and 'alloc-ranges' properties.
  */
 static int __init __reserved_mem_alloc_size(unsigned long node,
 	const char *uname, phys_addr_t *res_base, phys_addr_t *res_size)
@@ -165,7 +165,7 @@ static int __init __reserved_mem_alloc_size(unsigned long node,
 	__used __section(__reservedmem_of_table_end);
 
 /**
- * res_mem_init_node() - call region specific reserved memory init code
+ * __reserved_mem_init_node() - call region specific reserved memory init code
  */
 static int __init __reserved_mem_init_node(struct reserved_mem *rmem)
 {
@@ -232,7 +232,7 @@ static void __init __rmem_check_for_overlap(void)
 }
 
 /**
- * fdt_init_reserved_mem - allocate and init all saved reserved memory regions
+ * fdt_init_reserved_mem() - allocate and init all saved reserved memory regions
  */
 void __init fdt_init_reserved_mem(void)
 {
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw
Quoted 6 lines · On Mon, 11 May 2020 23:04:57 +0800, wrote:

From: chenqiwu <[email protected]>

Currently, there are some descriptions of function not consistent with function name, fixing them will make the code more readable.

Quoted 6 lines
---
 drivers/of/fdt.c             |  2 +-
 drivers/of/of_reserved_mem.c | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

Applied, thanks!