test/crypto: remove tests for unsupported descriptors
PATCH 1/1 test/crypto: remove tests for unsupported descriptors
Cryptodev doesn't limit the number of descriptors that can be supported by the PMD.
--- app/test/test_cryptodev.c | 45 --------------------------------------------- 1 file changed, 45 deletions(-)
app/test/test_cryptodev.c +0 -45
@@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 2 */ - qp_conf.nb_descriptors =MAX_NUM_OPS_INFLIGHT +2 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" -"num_inflights %u on qp %u on cryptodev %u" , - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - -/* invalid number of descriptors - max value of parameter */ - qp_conf.nb_descriptors =UINT32_MAX -1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" -"num_inflights %u on qp %u on cryptodev %u" , - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) {
@@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 1 */ - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT +1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" -"num_inflights %u on qp %u on cryptodev %u" , - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } -/* test invalid queue pair id */ qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;/*valid */
Signature · 1 line
2.7.4
Hi Anoob.
What's wrong with this test? Is this unit test failing on any PMD now?
I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, SCHEDULER) and it passes everywhere. Then why should we remove it completely?
Adam
Quoted 88 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Anoob Joseph
Sent: Tuesday, 12 May, 2020 09:12
To: Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: Anoob Joseph <[email protected]>; Narayana Prasad <[email protected]>; Ankur Dwivedi <[email protected]>; De Lara Guarch, Pablo <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptorsCryptodev doesn't limit the number of descriptors that can be supported by the PMD.
Signed-off-by Anoob Joseph <[email protected]>--- app/test/test_cryptodev.c | 45 --------------------------------------------- 1 file changed, 45 deletions(-)app/test/test_cryptodev.c index renamed from app/test/test_cryptodev.c +0
-0c624018..1ed2df8 100644
app/test/test_cryptodev.c +0
-30@@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 2 */ - qp_conf.nb_descriptors =MAX_NUM_OPS_INFLIGHT +2 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - -/* invalid number of descriptors - max value of parameter */ - qp_conf.nb_descriptors =UINT32_MAX -1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;app/test/test_cryptodev.c +0
-15for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) {@@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 1 */ - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT +1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } -/* test invalid queue pair id */ qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;/*valid */--
2.7.4
Hi Adam,
Quoted 8 lines
Hi Anoob.
What's wrong with this test? Is this unit test failing on any PMD now? I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, SCHEDULER) and it passes everywhere. Then why should we remove it completely?
The problem is not with the valid cases. It is the negative cases which will cause issue On most of the hardware PMDs which do not use qp_conf and simply ignore the values set in qp_conf. So it actually does not matter whether you set valid or invalid value for those PMDs
I believe negative test should not be there for parameters which are optional to be used. And IMO the patch is fine.
Regards,
Akhil
Hi Adam,
The crypto library doesn't specify an upper limit for the nb_descriptors to be passed for queue_pair_setup. So technically all the values that you have passed as invalid is not correct.
I did check few PMDs when I saw this issue with OCTEON TX2 crypto PMD. QAT support max 4096 descriptors and so the invalids that is present is exactly following that. I checked DPAA drivers, but in that the entire conf is left unused. So I'm not sure whether DPAA passes these cases. I couldn't check the entire list that you have mentioned. But it doesn't much sense for s/w PMDs to limit max_nb_descriptors.
If we need to have an invalid check, we should probably add max_nb_descriptors in dev_info. And then we can have these tests. I'm open for that idea also. But I don't know whether that is allowed now or not. I leave that to Akhil.
Thanks,
Anoob
Quoted 113 lines
-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Tuesday, May 12, 2020 6:37 PM
To: Anoob Joseph <[email protected]>; Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: Narayana Prasad Raju Athreya <[email protected]>; Ankur Dwivedi <[email protected]>; De Lara Guarch, Pablo <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptorsExternal Email
----------------------------------------------------------------------
Hi Anoob.What's wrong with this test? Is this unit test failing on any PMD now? I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, SCHEDULER) and it passes everywhere. Then why should we remove it completely?
Adam
Quoted 90 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Anoob Joseph
Sent: Tuesday, 12 May, 2020 09:12
To: Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: Anoob Joseph <[email protected]>; Narayana Prasad <[email protected]>; Ankur Dwivedi <[email protected]>; De Lara Guarch, Pablo <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptorsCryptodev doesn't limit the number of descriptors that can be supported by the PMD.
Signed-off-by Anoob Joseph <[email protected]>--- app/test/test_cryptodev.c | 45 --------------------------------------------- 1 file changed, 45 deletions(-)app/test/test_cryptodev.c +0
-0index
c624018..1ed2df8 100644app/test/test_cryptodev.c +0
-30@@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 2 */ - qp_conf.nb_descriptors =MAX_NUM_OPS_INFLIGHT +2 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - -/* invalid number of descriptors - max value of parameter */ - qp_conf.nb_descriptors =UINT32_MAX -1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;app/test/test_cryptodev.c +0
-15for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) {@@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 1 */ - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT +1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } -/* test invalid queue pair id */ qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;/*valid */--
2.7.4
Dybkowski, AdamX
Acked-byHi Anoob.
Thanks for this longer explanation.
I think can remove the test as intended.
Adam
Quoted 146 lines
-----Original Message-----
From: Anoob Joseph <[email protected]>
Sent: Tuesday, 12 May, 2020 15:27
To: Dybkowski, AdamX <[email protected]>; Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: Narayana Prasad Raju Athreya <[email protected]>; Ankur Dwivedi <[email protected]>; De Lara Guarch, Pablo <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptorsHi Adam,
The crypto library doesn't specify an upper limit for the
nb_descriptorsto be passed forqueue_pair_setup. So technically all the values that you have passed as invalid is not correct.I did check few PMDs when I saw this issue with OCTEON TX2 crypto PMD. QAT support max 4096 descriptors and so the invalids that is present is exactly following that. I checked DPAA drivers, but in that the entire conf is left unused. So I'm not sure whether DPAA passes these cases. I couldn't check the entire list that you have mentioned. But it doesn't much sense for s/w PMDs to limit
max_nb_descriptors.If we need to have an invalid check, we should probably add
max_nb_descriptorsindev_info. And then we can have these tests. I'm open for that idea also. But I don't know whether that is allowed now or not. I leave that to Akhil.Thanks,
AnoobQuoted 6 lines
-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Tuesday, May 12, 2020 6:37 PM
To: Anoob Joseph <[email protected]>; Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: Narayana Prasad Raju Athreya <[email protected]>; AnkurDwivedi
Quoted 107 lines
<[email protected]>; De Lara Guarch, Pablo <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptorsExternal Email
----------------------------------------------------------------------
Hi Anoob.What's wrong with this test? Is this unit test failing on any PMD now? I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, SCHEDULER) and it passes everywhere. Then why should we remove it completely?
Adam
Quoted 90 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Anoob Joseph
Sent: Tuesday, 12 May, 2020 09:12
To: Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>
Cc: Anoob Joseph <[email protected]>; Narayana Prasad <[email protected]>; Ankur Dwivedi <[email protected]>; De Lara Guarch, Pablo <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptorsCryptodev doesn't limit the number of descriptors that can be supported by the PMD.
Signed-off-by Anoob Joseph <[email protected]>--- app/test/test_cryptodev.c | 45 --------------------------------------------- 1 file changed, 45 deletions(-)app/test/test_cryptodev.c +0
-0index
c624018..1ed2df8 100644app/test/test_cryptodev.c +0
-30@@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 2 */ - qp_conf.nb_descriptors =MAX_NUM_OPS_INFLIGHT +2 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - -/* invalid number of descriptors - max value of parameter */ - qp_conf.nb_descriptors =UINT32_MAX -1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;app/test/test_cryptodev.c +0
-15for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) {@@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) ts_params->valid_devs[0]); } -/* invalid number of descriptors - max supported + 1 */ - qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT +1 ; - -for (qp_id =0 ; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { -TEST_ASSERT_FAIL (rte_cryptodev_queue_pair_setup ( - ts_params->valid_devs[0 ], qp_id, &qp_conf, -rte_cryptodev_socket_id ( - ts_params->valid_devs[0 ])), -"Unexpectedly passed test for " -"rte_cryptodev_queue_pair_setup:" - "num_inflights %u on qp %u on cryptodev %u", - qp_conf.nb_descriptors, qp_id, - ts_params->valid_devs[0 ]); - } -/* test invalid queue pair id */ qp_conf.nb_descriptors =DEFAULT_NUM_OPS_INFLIGHT ;/*valid */--
2.7.4
Quoted 8 lines
Hi Anoob.
Thanks for this longer explanation.
I think can remove the test as intended.Acked-by Adam Dybkowski <[email protected]>
Applied to dpdk-next-crypto
Thanks.