patch "staging: kpc2000: fix error return code in kp2000_pcie_probe()" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: kpc2000: fix error return code in kp2000_pcie_probe()
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From b17884ccf29e127b16bba6aea1438c851c9f5af1 Mon Sep 17 00:00:00 2001
From: Wei Yongjun <[email protected]>
Date: Wed, 6 May 2020 13:47:35 +0000
Subject: staging: kpc2000: fix error return code in kp2000_pcie_probe()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Also removed var 'rv' since we can use 'err' instead.
--- drivers/staging/kpc2000/kpc2000/core.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/staging/kpc2000/kpc2000/core.c +4 -5
@@ -298,7 +298,6 @@ static int kp2000_pcie_probe(struct pci_dev *pdev, {int err =0 ;struct kp2000_device *pcard; -int rv;unsigned long reg_bar_phys_addr;unsigned long reg_bar_phys_len;unsigned long dma_bar_phys_addr;
@@ -445,11 +444,11 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,if (err <0 ) goto err_release_dma; - rv =request_irq (pcard->pdev->irq, kp2000_irq_handler,IRQF_SHARED , - pcard->name, pcard); -if (rv) { + err =request_irq (pcard->pdev->irq, kp2000_irq_handler,IRQF_SHARED , + pcard->name, pcard); +if (err) {dev_err (&pcard->pdev->dev, -"%s: failed to request_irq: %d\n" , __func__, rv); +"%s: failed to request_irq: %d\n" , __func__, err); goto err_disable_msi; }
Signature · 1 line
2.26.2