usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
Subsystems (3)
PATCH 1/1 usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
When receiving reset interrupt, FADDR need to be reset to zero in periphearl mode. Otherwise ep0 cannot do enumeration when re-pluging USB cable.
Signed-off-by Macpaul Lin <[email protected]>
--- drivers/usb/musb/mediatek.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/usb/musb/mediatek.c +6 -0
@@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci) musb->int_rx =musb_clearw (musb->mregs,MUSB_INTRRX ); musb->int_tx =musb_clearw (musb->mregs,MUSB_INTRTX ); +if ((musb->int_usb &MUSB_INTR_RESET ) && !is_host_active (musb)) { +/* ep0 FADDR must be 0 when (re)entering peripheral mode */ +musb_ep_select (musb->mregs,0 ); +musb_writeb (musb->mregs,MUSB_FADDR ,0 ); + } +if (musb->int_usb || musb->int_tx || musb->int_rx) retval =musb_interrupt (musb);
Signature · 1 line
1.7.9.5
Quoted 16 lines · Macpaul Lin
When receiving reset interrupt, FADDR need to be reset to zero in periphearl mode. Otherwise ep0 cannot do enumeration when re-pluging USB cable.
Signed-off-by Macpaul Lin <[email protected]>--- drivers/usb/musb/mediatek.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/usb/musb/mediatek.c +0
-0@@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci) musb->int_rx =musb_clearw (musb->mregs,MUSB_INTRRX ); musb->int_tx =musb_clearw (musb->mregs,MUSB_INTRTX );
drivers/usb/musb/mediatek.c static irqreturn_t generic_interrupt(int irq, void *__hci) · line 219
Quoted 10 lines
drivers/usb/musb/mediatek.c +6
-0+if ((musb->int_usb &MUSB_INTR_RESET ) && !is_host_active (musb)) { +/* ep0 FADDR must be 0 when (re)entering peripheral mode */ +musb_ep_select (musb->mregs,0 ); +musb_writeb (musb->mregs,MUSB_FADDR ,0 ); + } +if (musb->int_usb || musb->int_tx || musb->int_rx) retval =musb_interrupt (musb);
Acked-by Min Guo <[email protected]>
Quoted 18 lines · Min Guo
Quoted 17 lines · Macpaul Lin
When receiving reset interrupt, FADDR need to be reset to zero in periphearl mode. Otherwise ep0 cannot do enumeration when re-pluging USB cable.
Signed-off-by Macpaul Lin <[email protected]>--- drivers/usb/musb/mediatek.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/usb/musb/mediatek.c +0
-0@@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci) musb->int_rx =musb_clearw (musb->mregs,MUSB_INTRRX ); musb->int_tx =musb_clearw (musb->mregs,MUSB_INTRTX );
Quoted 12 lines
drivers/usb/musb/mediatek.c static irqreturn_t generic_interrupt(int irq, void *__hci) · line 219
Quoted 9 lines
drivers/usb/musb/mediatek.c +6
-0+if ((musb->int_usb &MUSB_INTR_RESET ) && !is_host_active (musb)) { +/* ep0 FADDR must be 0 when (re)entering peripheral mode */ +musb_ep_select (musb->mregs,0 ); +musb_writeb (musb->mregs,MUSB_FADDR ,0 ); + } +if (musb->int_usb || musb->int_tx || musb->int_rx) retval =musb_interrupt (musb);Acked-by Min Guo <[email protected]>
Queued for v5.8. Thanks.
-Bin.