Skip to contentSkip to conversation

net/sfc/base: fix manual filter delete in EF10

PATCH Applied Andrew Rybchenko 2 participants 2 messages May 20, 2020 – May 21, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/sfc/base: fix manual filter delete in EF10

From: Igor Romanov <[email protected]>

When user requests a filter deletion only filter with manual priority must be deleted. When an automatic filter has the same specification, it must be skipped.

Fixes 585c22edb29c ("net/sfc/base: handle manual and auto filter clashes in EF10")
---
 drivers/net/sfc/base/ef10_filter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/sfc/base/ef10_filter.c +2 -1
index 7a726ef977..12c84a5640 100644
@@ -1161,7 +1161,8 @@ ef10_filter_delete(
 		i = (hash + depth) & (EFX_EF10_FILTER_TBL_ROWS - 1);
 		saved_spec = ef10_filter_entry_spec(table, i);
 		if (saved_spec && ef10_filter_equal(spec, saved_spec) &&
-		    ef10_filter_same_dest(spec, saved_spec)) {
+		    ef10_filter_same_dest(spec, saved_spec) &&
+		    saved_spec->efs_priority == EFX_FILTER_PRI_MANUAL) {
 			break;
 		}
 		if (depth == EF10_FILTER_SEARCH_LIMIT) {
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 11 lines · Andrew Rybchenko

From: Igor Romanov <[email protected]>

When user requests a filter deletion only filter with manual priority must be deleted. When an automatic filter has the same specification, it must be skipped.

Fixes 585c22edb29c ("net/sfc/base: handle manual and auto filter clashes in EF10")

Applied to dpdk-next-net/master, thanks.