MT6779 IOMMU SUPPORT
Subsystems (5)
v3 cover MT6779 IOMMU SUPPORT
This patchset adds mt6779 iommu support.
mt6779 has two iommus, they are MM_IOMMU(M4U) and APU_IOMMU which used ARM Short-Descriptor translation format. The mt6779's MM_IOMMU-SMI and APU_IOMMU HW diagram is as below, it is only a brief diagram:
EMI
|
--------------------------------------
| |
MM_IOMMU APU_IOMMU
| |
SMI_COMMOM----------- APU_BUS
| | |
SMI_LARB(0~11) | |
| | |
| | --------------
| | | | |
Multimedia engine CCU VPU MDLA EMDA
All the connections are hardware fixed, software can not adjust it.
Compared with mt8183, SMI_BUS_ID width has changed from 10 to 12. SMI Larb number is described in bit[11:7], Port number is described in bit[6:2]. In addition, there are some registers has changed in mt6779, so we need to redefine and reuse them.
The patchset only used MM_IOMMU, so we only add MM_IOMMU basic function, such as smi_larb port definition, registers definition and hardware initialization.
change notes:
v3:
1. Rebase on v5.7-rc1.
2. Remove unused port definition,ex:APU and CCU port in mt6779-larb-port.h.
3. Remove "change single domain to multiple domain" part(from PATCH v2 09/19 to PATCH v2 19/19).
4. Redesign mt6779 basic part
(1)Add some register definition and reuse them.
(2)Redesign smi larb bus ID to analyze IOMMU translation fault.
(3)Only init MM_IOMMU and not use APU_IOMMU.
v2:
1. Rebase on v5.5-rc1.
2. Delete M4U_PORT_UNKNOWN define because of not use it.
3. Correct coding format.
4. Rename offset=0x48 register.
5. Split "iommu/mediatek: Add mt6779 IOMMU basic support(patch v1)" to several patches(patch v2).
http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026131.html
v1:
http://lists.infradead.org/pipermail/linux-mediatek/2019-November/024567.html
Chao Hao (7):
dt-bindings: mediatek: Add bindings for MT6779 iommu/mediatek: Rename the register STANDARD_AXI_MODE(0x48) to
MISC_CTRL
iommu/mediatek: Disable STANDARD_AXI_MODE in MISC_CTRL iommu/mediatek: Move inv_sel_reg into the plat_data iommu/mediatek: Add sub_comm id in translation fault iommu/mediatek: Add REG_MMU_WR_LEN definition preparing for mt6779 iommu/mediatek: Add mt6779 basic support
.../bindings/iommu/mediatek,iommu.txt | 2 + drivers/iommu/mtk_iommu.c | 77 +++++-- drivers/iommu/mtk_iommu.h | 10 +- include/dt-bindings/memory/mt6779-larb-port.h | 206 ++++++++++++++++++ 4 files changed, 273 insertions(+), 22 deletions(-)
--
2.18.0
PATCH v3 1/7 dt-bindings: mediatek: Add bindings for MT6779
This patch adds description for MT6779 IOMMU.
MT6779 has two iommus, they are mm_iommu and apu_iommu which both use ARM Short-Descriptor translation format.
In addition, mm_iommu and apu_iommu are two independent HW instance , we need to set them separately.
The MT6779 IOMMU hardware diagram is as below, it is only a brief diagram about iommu, it don't focus on the part of smi_larb, so I don't describe the smi_larb detailedly.
EMI
|
--------------------------------------
| |
MM_IOMMU APU_IOMMU
| |
SMI_COMMOM----------- APU_BUS
| | |
SMI_LARB(0~11) | |
| | |
| | --------------
| | | | |Multimedia engine CCU VPU MDLA EMDA
All the connections are hardware fixed, software can not adjust it.
Change since v2:
1. Delete unused definition, ex: M4U_LARB12_ID, M4U_LARB13_ID, CCU, VPU, MDLA, EDMA
Change since v1:
1. Delete M4U_PORT_UNKNOWN define because of not use it.
2. Correct coding format: ex: /*larb3-VENC*/ --> /* larb3-VENC */
--- .../bindings/iommu/mediatek,iommu.txt | 2 + include/dt-bindings/memory/mt6779-larb-port.h | 206 ++++++++++++++++++ 2 files changed, 208 insertions(+) create mode 100644 include/dt-bindings/memory/mt6779-larb-port.h
Documentation/devicetree/bindings/iommu/mediatek,iommu.txt +2 -0
@@ -58,6 +58,7 @@ Required properties: - compatible : must be one of the following string: "mediatek,mt2701-m4u" for mt2701 which uses generation one m4u HW. "mediatek,mt2712-m4u" for mt2712 which uses generation two m4u HW. + "mediatek,mt6779-m4u" for mt6779 which uses generation two m4u HW. "mediatek,mt7623-m4u", "mediatek,mt2701-m4u" for mt7623 which uses generation one m4u HW. "mediatek,mt8173-m4u" for mt8173 which uses generation two m4u HW.
@@ -78,6 +79,7 @@ Required properties: Specifies the mtk_m4u_id as defined in dt-binding/memory/mt2701-larb-port.h for mt2701, mt7623 dt-binding/memory/mt2712-larb-port.h for mt2712, + dt-binding/memory/mt6779-larb-port.h for mt6779, dt-binding/memory/mt8173-larb-port.h for mt8173, and dt-binding/memory/mt8183-larb-port.h for mt8183.
include/dt-bindings/memory/mt6779-larb-port.h new file +206 -0
206 lines not on this page · raw message
Signature · 1 line
2.18.0
PATCH v3 2/7 iommu/mediatek: Rename the register STANDARD_AXI_MODE(0x48) to MISC_CTRL
In reply to Chao HaoFor iommu offset=0x48 register, only the previous mt8173/mt8183 use the name STANDARD_AXI_MODE, all the latest SoC extend the register more feature by different bits, for example: axi_mode, in_order_en, coherent_en and so on. So rename REG_MMU_MISC_CTRL may be more proper.
This patch only rename the register name, no functional change.
--- drivers/iommu/mtk_iommu.c | 14 +++++++------- drivers/iommu/mtk_iommu.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-)
drivers/iommu/mtk_iommu.c +7 -7
@@ -41,7 +41,7 @@#define F_INVLD_EN0 BIT(0)#define F_INVLD_EN1 BIT(1) -#define REG_MMU_STANDARD_AXI_MODE 0x048 +#define REG_MMU_MISC_CTRL 0x048#define REG_MMU_DCM_DIS 0x050#define REG_MMU_CTRL_REG 0x110
@@ -585,8 +585,10 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) }writel_relaxed (0 , data->base +REG_MMU_DCM_DIS ); -if (data->plat_data->reset_axi) -writel_relaxed (0 , data->base +REG_MMU_STANDARD_AXI_MODE ); +if (data->plat_data->reset_axi) { +/* The register is called STANDARD_AXI_MODE in this case */ +writel_relaxed (0 , data->base +REG_MMU_MISC_CTRL ); + }if (devm_request_irq (data->dev, data->irq, mtk_iommu_isr,0 ,dev_name (data->dev), (void *)data)) {
@@ -730,8 +732,7 @@ static int __maybe_unused mtk_iommu_suspend(struct device *dev)struct mtk_iommu_suspend_reg *reg = &data->reg;void __iomem *base = data->base; - reg->standard_axi_mode =readl_relaxed (base + -REG_MMU_STANDARD_AXI_MODE ); + reg->misc_ctrl =readl_relaxed (base +REG_MMU_MISC_CTRL ); reg->dcm_dis =readl_relaxed (base +REG_MMU_DCM_DIS ); reg->ctrl_reg =readl_relaxed (base +REG_MMU_CTRL_REG ); reg->int_control0 =readl_relaxed (base +REG_MMU_INT_CONTROL0 );
@@ -755,8 +756,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev)dev_err (data->dev,"Failed to enable clk(%d) in resume\n" , ret);return ret; } -writel_relaxed (reg->standard_axi_mode, - base +REG_MMU_STANDARD_AXI_MODE ); +writel_relaxed (reg->misc_ctrl, base +REG_MMU_MISC_CTRL );writel_relaxed (reg->dcm_dis, base +REG_MMU_DCM_DIS );writel_relaxed (reg->ctrl_reg, base +REG_MMU_CTRL_REG );writel_relaxed (reg->int_control0, base +REG_MMU_INT_CONTROL0 );
drivers/iommu/mtk_iommu.h +1 -1
@@ -18,7 +18,7 @@#include <soc/mediatek/smi.h> struct mtk_iommu_suspend_reg { -u32 standard_axi_mode; +u32 misc_ctrl;u32 dcm_dis;u32 ctrl_reg;u32 int_control0;
Signature · 1 line
2.18.0
Re: [PATCH v3 2/7] iommu/mediatek: Rename the register STANDARD_AXI_MODE(0x48) to MISC_CTRL
Quoted 8 lines · Chao Hao
For iommu offset=0x48 register, only the previous mt8173/mt8183 use the name
STANDARD_AXI_MODE, all the latest SoC extend the register more feature by different bits, for example:axi_mode,in_order_en,coherent_enand so on. So renameREG_MMU_MISC_CTRLmay be more proper.This patch only rename the register name, no functional change.
Signed-off-by Chao Hao <[email protected]>
Quoted 64 lines
--- drivers/iommu/mtk_iommu.c | 14 +++++++------- drivers/iommu/mtk_iommu.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-)drivers/iommu/mtk_iommu.c +7
-7@@ -41,7 +41,7 @@#define F_INVLD_EN0 BIT(0)#define F_INVLD_EN1 BIT(1) -#define REG_MMU_STANDARD_AXI_MODE 0x048 +#define REG_MMU_MISC_CTRL 0x048#define REG_MMU_DCM_DIS 0x050#define REG_MMU_CTRL_REG 0x110@@ -585,8 +585,10 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) }writel_relaxed (0 , data->base +REG_MMU_DCM_DIS ); -if (data->plat_data->reset_axi) -writel_relaxed (0 , data->base +REG_MMU_STANDARD_AXI_MODE ); +if (data->plat_data->reset_axi) { +/* The register is called STANDARD_AXI_MODE in this case */ +writel_relaxed (0 , data->base +REG_MMU_MISC_CTRL ); + }if (devm_request_irq (data->dev, data->irq, mtk_iommu_isr,0 ,dev_name (data->dev), (void *)data)) {@@ -730,8 +732,7 @@ static int __maybe_unused mtk_iommu_suspend(struct device *dev)struct mtk_iommu_suspend_reg *reg = &data->reg;void __iomem *base = data->base; - reg->standard_axi_mode =readl_relaxed (base + -REG_MMU_STANDARD_AXI_MODE ); + reg->misc_ctrl =readl_relaxed (base +REG_MMU_MISC_CTRL ); reg->dcm_dis =readl_relaxed (base +REG_MMU_DCM_DIS ); reg->ctrl_reg =readl_relaxed (base +REG_MMU_CTRL_REG ); reg->int_control0 =readl_relaxed (base +REG_MMU_INT_CONTROL0 );@@ -755,8 +756,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev)dev_err (data->dev,"Failed to enable clk(%d) in resume\n" , ret);return ret; } -writel_relaxed (reg->standard_axi_mode, - base +REG_MMU_STANDARD_AXI_MODE ); +writel_relaxed (reg->misc_ctrl, base +REG_MMU_MISC_CTRL );writel_relaxed (reg->dcm_dis, base +REG_MMU_DCM_DIS );writel_relaxed (reg->ctrl_reg, base +REG_MMU_CTRL_REG );writel_relaxed (reg->int_control0, base +REG_MMU_INT_CONTROL0 );drivers/iommu/mtk_iommu.h +1
-1@@ -18,7 +18,7 @@#include <soc/mediatek/smi.h> struct mtk_iommu_suspend_reg { -u32 standard_axi_mode; +u32 misc_ctrl;u32 dcm_dis;u32 ctrl_reg;u32 int_control0;
PATCH v3 3/7 iommu/mediatek: Disable STANDARD_AXI_MODE in MISC_CTRL
In reply to Chao HaoIn order to improve performance, we always disable STANDARD_AXI_MODE in MISC_CTRL.
--- drivers/iommu/mtk_iommu.c | 8 +++++++- drivers/iommu/mtk_iommu.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/iommu/mtk_iommu.c +7 -1
@@ -42,6 +42,8 @@#define F_INVLD_EN1 BIT(1)#define REG_MMU_MISC_CTRL 0x048 +#define F_MMU_STANDARD_AXI_MODE_BIT (BIT(3) | BIT(19)) +#define REG_MMU_DCM_DIS 0x050#define REG_MMU_CTRL_REG 0x110
@@ -585,7 +587,11 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) }writel_relaxed (0 , data->base +REG_MMU_DCM_DIS ); -if (data->plat_data->reset_axi) { +if (data->plat_data->has_misc_ctrl) { + regval =readl_relaxed (data->base +REG_MMU_MISC_CTRL ); + regval &= ~F_MMU_STANDARD_AXI_MODE_BIT ; +writel_relaxed (regval, data->base +REG_MMU_MISC_CTRL ); + }else if (data->plat_data->reset_axi) {/* The register is called STANDARD_AXI_MODE in this case */ writel_relaxed (0 , data->base +REG_MMU_MISC_CTRL ); }
drivers/iommu/mtk_iommu.h +1 -0
@@ -40,6 +40,7 @@ struct mtk_iommu_plat_data {/* HW will use the EMI clock if there isn't the "bclk". */ bool has_bclk; +bool has_misc_ctrl;bool has_vld_pa_rng;bool reset_axi;unsigned char larbid_remap[MTK_LARB_NR_MAX ];
Signature · 1 line
2.18.0
Yong Wu
maintainerRe: [PATCH v3 3/7] iommu/mediatek: Disable STANDARD_AXI_MODE in MISC_CTRL
Quoted 25 lines · Chao Hao
In order to improve performance, we always disable
STANDARD_AXI_MODEinMISC_CTRL.Signed-off-by Chao Hao <[email protected]>--- drivers/iommu/mtk_iommu.c | 8 +++++++- drivers/iommu/mtk_iommu.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-)drivers/iommu/mtk_iommu.c +2
-0@@ -42,6 +42,8 @@#define F_INVLD_EN1 BIT(1)#define REG_MMU_MISC_CTRL 0x048 +#define F_MMU_STANDARD_AXI_MODE_BIT (BIT(3) | BIT(19)) +#define REG_MMU_DCM_DIS 0x050#define REG_MMU_CTRL_REG 0x110@@ -585,7 +587,11 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) }writel_relaxed (0 , data->base +REG_MMU_DCM_DIS );
drivers/iommu/mtk_iommu.c static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) · line 597
Quoted 10 lines
drivers/iommu/mtk_iommu.c +5
-1-if (data->plat_data->reset_axi) { +if (data->plat_data->has_misc_ctrl) { + regval =readl_relaxed (data->base +REG_MMU_MISC_CTRL ); + regval &= ~F_MMU_STANDARD_AXI_MODE_BIT ; +writel_relaxed (regval, data->base +REG_MMU_MISC_CTRL ); + }else if (data->plat_data->reset_axi) {/* The register is called STANDARD_AXI_MODE in this case */ writel_relaxed (0 , data->base +REG_MMU_MISC_CTRL ); }
0x48 is either STANDARD_AXI_MODE or MISC_CTRL.
Thus,
if (data->plat_data->reset_axi) {
xxx
} else { /* MISC_CTRL */
xxx
}
No need add "has_misc_ctrl".
Quoted 12 lines
drivers/iommu/mtk_iommu.h +1
-0@@ -40,6 +40,7 @@ struct mtk_iommu_plat_data {/* HW will use the EMI clock if there isn't the "bclk". */ bool has_bclk; +bool has_misc_ctrl;bool has_vld_pa_rng;bool reset_axi;unsigned char larbid_remap[MTK_LARB_NR_MAX ];
Re: [PATCH v3 3/7] iommu/mediatek: Disable STANDARD_AXI_MODE in MISC_CTRL
Quoted 42 lines · Yong Wu
Quoted 25 lines · Chao Hao
In order to improve performance, we always disable
STANDARD_AXI_MODEinMISC_CTRL.Signed-off-by Chao Hao <[email protected]>--- drivers/iommu/mtk_iommu.c | 8 +++++++- drivers/iommu/mtk_iommu.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-)drivers/iommu/mtk_iommu.c +2
-0@@ -42,6 +42,8 @@#define F_INVLD_EN1 BIT(1)#define REG_MMU_MISC_CTRL 0x048 +#define F_MMU_STANDARD_AXI_MODE_BIT (BIT(3) | BIT(19)) +#define REG_MMU_DCM_DIS 0x050#define REG_MMU_CTRL_REG 0x110@@ -585,7 +587,11 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) }writel_relaxed (0 , data->base +REG_MMU_DCM_DIS );drivers/iommu/mtk_iommu.c static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) · line 597
Quoted 10 lines
drivers/iommu/mtk_iommu.c +5
-1-if (data->plat_data->reset_axi) { +if (data->plat_data->has_misc_ctrl) { + regval =readl_relaxed (data->base +REG_MMU_MISC_CTRL ); + regval &= ~F_MMU_STANDARD_AXI_MODE_BIT ; +writel_relaxed (regval, data->base +REG_MMU_MISC_CTRL ); + }else if (data->plat_data->reset_axi) {/* The register is called STANDARD_AXI_MODE in this case */ writel_relaxed (0 , data->base +REG_MMU_MISC_CTRL ); }
0x48is eitherSTANDARD_AXI_MODEorMISC_CTRL.Thus,
Quoted 7 lines
if (
data->plat_data->reset_axi) {
xxx
} else { /*MISC_CTRL*/
xxx
}No need add "
has_misc_ctrl".
Thanks for you comment.
Only mm_iommu/m4u needs to set MISC_CTRL register and apu_iommu don't need to set it. So I think we need to use has_misc_ctrl to distinguish it.
Quoted 15 lines
Quoted 13 lines
drivers/iommu/mtk_iommu.h +1
-0@@ -40,6 +40,7 @@ struct mtk_iommu_plat_data {/* HW will use the EMI clock if there isn't the "bclk". */ bool has_bclk; +bool has_misc_ctrl;bool has_vld_pa_rng;bool reset_axi;unsigned char larbid_remap[MTK_LARB_NR_MAX ];
PATCH v3 4/7 iommu/mediatek: Move inv_sel_reg into the plat_data
In reply to Chao HaoFor mt6779, MMU_INVLDT_SEL register's offset is changed from 0x38 to 0x2c, so we can put inv_sel_reg in the plat_data to use it.
In addition, we renamed it to REG_MMU_INV_SEL_GEN1 and use it before mt6779.
--- drivers/iommu/mtk_iommu.c | 9 ++++++--- drivers/iommu/mtk_iommu.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-)
drivers/iommu/mtk_iommu.c +6 -3
@@ -37,7 +37,7 @@#define REG_MMU_INVLD_START_A 0x024#define REG_MMU_INVLD_END_A 0x028 -#define REG_MMU_INV_SEL 0x038 +#define REG_MMU_INV_SEL_GEN1 0x038#define F_INVLD_EN0 BIT(0)#define F_INVLD_EN1 BIT(1)
@@ -167,7 +167,7 @@ static void mtk_iommu_tlb_flush_all(void *cookie)for_each_m4u (data) {writel_relaxed (F_INVLD_EN1 |F_INVLD_EN0 , - data->base +REG_MMU_INV_SEL ); + data->base + data->plat_data->inv_sel_reg);writel_relaxed (F_ALL_INVLD , data->base +REG_MMU_INVALIDATE );wmb ();/* Make sure the tlb flush all done */ }
@@ -184,7 +184,7 @@ static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,for_each_m4u (data) {spin_lock_irqsave (&data->tlb_lock, flags);writel_relaxed (F_INVLD_EN1 |F_INVLD_EN0 , - data->base +REG_MMU_INV_SEL ); + data->base + data->plat_data->inv_sel_reg);writel_relaxed (iova, data->base +REG_MMU_INVLD_START_A ); writel_relaxed(iova + size - 1,
@@ -784,6 +784,7 @@ static const struct mtk_iommu_plat_data mt2712_data = { .has_4gb_mode = true, .has_bclk = true, .has_vld_pa_rng = true, + .inv_sel_reg = REG_MMU_INV_SEL_GEN1, .larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, };
@@ -792,12 +793,14 @@ static const struct mtk_iommu_plat_data mt8173_data = { .has_4gb_mode = true, .has_bclk = true, .reset_axi = true, + .inv_sel_reg = REG_MMU_INV_SEL_GEN1, .larbid_remap = {0, 1, 2, 3, 4, 5}, /* Linear mapping. */ };static const struct mtk_iommu_plat_data mt8183_data = { .m4u_plat =M4U_MT8183 , .reset_axi = true, + .inv_sel_reg =REG_MMU_INV_SEL_GEN1 , .larbid_remap = {0 ,4 ,5 ,6 ,7 ,2 ,3 ,1 }, };
drivers/iommu/mtk_iommu.h +1 -0
@@ -43,6 +43,7 @@ struct mtk_iommu_plat_data {bool has_misc_ctrl;bool has_vld_pa_rng;bool reset_axi; +u32 inv_sel_reg;unsigned char larbid_remap[MTK_LARB_NR_MAX ]; };
Signature · 1 line
2.18.0
Yong Wu
maintainerRe: [PATCH v3 4/7] iommu/mediatek: Move inv_sel_reg into the plat_data
Quoted 1 line · Chao Hao
For mt6779,
MMU_INVLDT_SELregister's offset is changed from
At this patch, the register is still called by "MMU_INV_SEL".
Quoted 43 lines
0x38to0x2c, so we can putinv_sel_regin theplat_datato use it.
In addition, we renamed it toREG_MMU_INV_SEL_GEN1and use it before mt6779.Signed-off-by Chao Hao <[email protected]>--- drivers/iommu/mtk_iommu.c | 9 ++++++--- drivers/iommu/mtk_iommu.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-)drivers/iommu/mtk_iommu.c +3
-3@@ -37,7 +37,7 @@#define REG_MMU_INVLD_START_A 0x024#define REG_MMU_INVLD_END_A 0x028 -#define REG_MMU_INV_SEL 0x038 +#define REG_MMU_INV_SEL_GEN1 0x038#define F_INVLD_EN0 BIT(0)#define F_INVLD_EN1 BIT(1)@@ -167,7 +167,7 @@ static void mtk_iommu_tlb_flush_all(void *cookie)for_each_m4u (data) {writel_relaxed (F_INVLD_EN1 |F_INVLD_EN0 , - data->base +REG_MMU_INV_SEL ); + data->base + data->plat_data->inv_sel_reg);writel_relaxed (F_ALL_INVLD , data->base +REG_MMU_INVALIDATE );wmb ();/* Make sure the tlb flush all done */ }@@ -184,7 +184,7 @@ static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,for_each_m4u (data) {spin_lock_irqsave (&data->tlb_lock, flags);writel_relaxed (F_INVLD_EN1 |F_INVLD_EN0 , - data->base +REG_MMU_INV_SEL ); + data->base + data->plat_data->inv_sel_reg);writel_relaxed (iova, data->base +REG_MMU_INVLD_START_A ); writel_relaxed(iova + size - 1,
drivers/iommu/mtk_iommu.c static const struct mtk_iommu_plat_data mt2712_data = { · line 787
Quoted 4 lines
drivers/iommu/mtk_iommu.c +1
-0@@ -784,6 +784,7 @@ static const struct mtk_iommu_plat_data mt2712_data = { .has_4gb_mode = true, .has_bclk = true, .has_vld_pa_rng = true, + .inv_sel_reg = REG_MMU_INV_SEL_GEN1,
nitpick: align '=' with the next line.
drivers/iommu/mtk_iommu.c static const struct mtk_iommu_plat_data mt8173_data = { · line 796
Quoted 8 lines
drivers/iommu/mtk_iommu.c +1
-0.larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, };@@ -792,12 +793,14 @@ static const struct mtk_iommu_plat_data mt8173_data = { .has_4gb_mode = true, .has_bclk = true, .reset_axi = true, + .inv_sel_reg = REG_MMU_INV_SEL_GEN1,
align '='
Quoted 22 lines
drivers/iommu/mtk_iommu.c +1
-0.larbid_remap = {0, 1, 2, 3, 4, 5}, /* Linear mapping. */ };static const struct mtk_iommu_plat_data mt8183_data = { .m4u_plat =M4U_MT8183 , .reset_axi = true, + .inv_sel_reg =REG_MMU_INV_SEL_GEN1 , .larbid_remap = {0 ,4 ,5 ,6 ,7 ,2 ,3 ,1 }, };drivers/iommu/mtk_iommu.h +1
-0@@ -43,6 +43,7 @@ struct mtk_iommu_plat_data {bool has_misc_ctrl;bool has_vld_pa_rng;bool reset_axi; +u32 inv_sel_reg;unsigned char larbid_remap[MTK_LARB_NR_MAX ]; };
PATCH v3 5/7 iommu/mediatek: Add sub_comm id in translation fault
In reply to Chao HaoThe max larb number that a iommu HW support is 8(larb0~larb7 in the below diagram).
If the larb's number is over 8, we use a sub_common for merging several larbs into one larb. At this case, we will extend larb_id:
bit[11:9] means common-id;
bit[8:7] means subcommon-id;
From these two variable, we could get the real larb number when translation fault happen.
The diagram is as below:
EMI
|
IOMMU
|
-----------------
| |
common1 common0
| |
-----------------
|
smi common
|
------------------------------------
| | | | | |
3'd0 3'd1 3'd2 3'd3 ... 3'd7 <-common_id(max is 8)
| | | | | |
Larb0 Larb1 | Larb3 ... Larb7
|
smi sub common
|
--------------------------
| | | |
2'd0 2'd1 2'd2 2'd3 <-sub_common_id(max is 4)
| | | |Larb8 Larb9 Larb10 Larb11
In this patch we extern larb_remap[] to larb_remap[8][4] for this. larb_remap[x][y]: x mean common-id above, y means subcommon_id above.
We can also distinguish if the M4U HW has sub_common by has_sub_comm property.
--- drivers/iommu/mtk_iommu.c | 20 +++++++++++++------- drivers/iommu/mtk_iommu.h | 3 ++- 2 files changed, 15 insertions(+), 8 deletions(-)
drivers/iommu/mtk_iommu.c +13 -7
@@ -90,6 +90,8 @@#define REG_MMU1_INVLD_PA 0x148#define REG_MMU0_INT_ID 0x150#define REG_MMU1_INT_ID 0x154 +#define F_MMU_INT_ID_COMM_ID (a) (((a) >> 9) & 0x7) +#define F_MMU_INT_ID_SUB_COMM_ID (a) (((a) >> 7) & 0x3)#define F_MMU_INT_ID_LARB_ID (a) (((a) >> 7) & 0x7)#define F_MMU_INT_ID_PORT_ID (a) (((a) >> 2) & 0x1f)
@@ -228,7 +230,7 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)struct mtk_iommu_data *data = dev_id;struct mtk_iommu_domain *dom = data->m4u_dom;u32 int_state, regval, fault_iova, fault_pa; -unsigned int fault_larb, fault_port; +unsigned int fault_larb, fault_port, sub_comm =0 ;bool layer, write;/* Read error info from registers */
@@ -244,10 +246,14 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id) } layer = fault_iova &F_MMU_FAULT_VA_LAYER_BIT ; write = fault_iova &F_MMU_FAULT_VA_WRITE_BIT ; - fault_larb =F_MMU_INT_ID_LARB_ID (regval); fault_port =F_MMU_INT_ID_PORT_ID (regval); - - fault_larb = data->plat_data->larbid_remap[fault_larb]; +if (data->plat_data->has_sub_comm) { + fault_larb =F_MMU_INT_ID_COMM_ID (regval); + sub_comm =F_MMU_INT_ID_SUB_COMM_ID (regval); + }else { + fault_larb =F_MMU_INT_ID_LARB_ID (regval); + } + fault_larb = data->plat_data->larbid_remap[fault_larb][sub_comm];if (report_iommu_fault (&dom->domain, data->dev, fault_iova, write ?IOMMU_FAULT_WRITE :IOMMU_FAULT_READ )) {
@@ -785,7 +791,7 @@ static const struct mtk_iommu_plat_data mt2712_data = { .has_bclk = true, .has_vld_pa_rng = true, .inv_sel_reg = REG_MMU_INV_SEL_GEN1, - .larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, + .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}}, };static const struct mtk_iommu_plat_data mt8173_data = {
@@ -794,14 +800,14 @@ static const struct mtk_iommu_plat_data mt8173_data = { .has_bclk = true, .reset_axi = true, .inv_sel_reg = REG_MMU_INV_SEL_GEN1, - .larbid_remap = {0, 1, 2, 3, 4, 5}, /* Linear mapping. */ + .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */ };static const struct mtk_iommu_plat_data mt8183_data = { .m4u_plat =M4U_MT8183 , .reset_axi = true, .inv_sel_reg =REG_MMU_INV_SEL_GEN1 , - .larbid_remap = {0 ,4 ,5 ,6 ,7 ,2 ,3 ,1 }, + .larbid_remap = {{0 }, {4 }, {5 }, {6 }, {7 }, {2 }, {3 }, {1 }}, };static const struct of_device_id mtk_iommu_of_ids[] = {
drivers/iommu/mtk_iommu.h +2 -1
@@ -41,10 +41,11 @@ struct mtk_iommu_plat_data {/* HW will use the EMI clock if there isn't the "bclk". */ bool has_bclk;bool has_misc_ctrl; +bool has_sub_comm;bool has_vld_pa_rng;bool reset_axi;u32 inv_sel_reg; -unsigned char larbid_remap[MTK_LARB_NR_MAX ]; +unsigned char larbid_remap[8 ][4 ]; };struct mtk_iommu_domain ;
Signature · 1 line
2.18.0
Re: [PATCH v3 5/7] iommu/mediatek: Add sub_comm id in translation fault
Quoted 88 lines · Chao Hao
The max larb number that a iommu HW support is 8(larb0~larb7 in the below diagram).
If the larb's number is over 8, we use asub_commonfor merging several larbs into one larb. At this case, we will extendlarb_id:
bit[11:9] means common-id;
bit[8:7] means subcommon-id;
From these two variable, we could get the real larb number when translation fault happen.
The diagram is as below:EMI | IOMMU | ----------------- | | common1 common0 | | ----------------- | smi common | ------------------------------------ | | | | | | 3'd0 3'd1 3'd2 3'd3 ... 3'd7 <-common_id(max is 8) | | | | | | Larb0 Larb1 | Larb3 ... Larb7 | smi sub common | -------------------------- | | | | 2'd0 2'd1 2'd2 2'd3 <-sub_common_id(max is 4) | | | |Larb8 Larb9 Larb10 Larb11
In this patch we extern larb_remap[] to larb_remap[8][4] for this. larb_remap[x][y]: x mean common-id above, y means
subcommon_idabove.We can also distinguish if the M4U HW has
sub_commonbyhas_sub_commproperty.Signed-off-by Chao Hao <[email protected]>--- drivers/iommu/mtk_iommu.c | 20 +++++++++++++------- drivers/iommu/mtk_iommu.h | 3 ++- 2 files changed, 15 insertions(+), 8 deletions(-)drivers/iommu/mtk_iommu.c +10
-4@@ -90,6 +90,8 @@#define REG_MMU1_INVLD_PA 0x148#define REG_MMU0_INT_ID 0x150#define REG_MMU1_INT_ID 0x154 +#define F_MMU_INT_ID_COMM_ID (a) (((a) >> 9) & 0x7) +#define F_MMU_INT_ID_SUB_COMM_ID (a) (((a) >> 7) & 0x3)#define F_MMU_INT_ID_LARB_ID (a) (((a) >> 7) & 0x7)#define F_MMU_INT_ID_PORT_ID (a) (((a) >> 2) & 0x1f)@@ -228,7 +230,7 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)struct mtk_iommu_data *data = dev_id;struct mtk_iommu_domain *dom = data->m4u_dom;u32 int_state, regval, fault_iova, fault_pa; -unsigned int fault_larb, fault_port; +unsigned int fault_larb, fault_port, sub_comm =0 ;bool layer, write;/* Read error info from registers */ @@ -244,10 +246,14 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id) } layer = fault_iova &F_MMU_FAULT_VA_LAYER_BIT ; write = fault_iova &F_MMU_FAULT_VA_WRITE_BIT ; - fault_larb =F_MMU_INT_ID_LARB_ID (regval); fault_port =F_MMU_INT_ID_PORT_ID (regval); - - fault_larb = data->plat_data->larbid_remap[fault_larb]; +if (data->plat_data->has_sub_comm) { + fault_larb =F_MMU_INT_ID_COMM_ID (regval); + sub_comm =F_MMU_INT_ID_SUB_COMM_ID (regval); + }else { + fault_larb =F_MMU_INT_ID_LARB_ID (regval); + } + fault_larb = data->plat_data->larbid_remap[fault_larb][sub_comm];if (report_iommu_fault (&dom->domain, data->dev, fault_iova, write ?IOMMU_FAULT_WRITE :IOMMU_FAULT_READ )) {
drivers/iommu/mtk_iommu.c static const struct mtk_iommu_plat_data mt2712_data = { · line 794
Quoted 5 lines
drivers/iommu/mtk_iommu.c +1
-1@@ -785,7 +791,7 @@ static const struct mtk_iommu_plat_data mt2712_data = { .has_bclk = true, .has_vld_pa_rng = true, .inv_sel_reg = REG_MMU_INV_SEL_GEN1, - .larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, + .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}},
The original mt2712 has 10 larbs, but it actually has 2 IOMMU HWs. For each a smi-common, The max larb number could only be 8. So it is right here.
Thus,
Quoted 27 lines
drivers/iommu/mtk_iommu.c +2
-2};static const struct mtk_iommu_plat_data mt8173_data = {@@ -794,14 +800,14 @@ static const struct mtk_iommu_plat_data mt8173_data = { .has_bclk = true, .reset_axi = true, .inv_sel_reg = REG_MMU_INV_SEL_GEN1, - .larbid_remap = {0, 1, 2, 3, 4, 5}, /* Linear mapping. */ + .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */ };static const struct mtk_iommu_plat_data mt8183_data = { .m4u_plat =M4U_MT8183 , .reset_axi = true, .inv_sel_reg =REG_MMU_INV_SEL_GEN1 , - .larbid_remap = {0 ,4 ,5 ,6 ,7 ,2 ,3 ,1 }, + .larbid_remap = {{0 }, {4 }, {5 }, {6 }, {7 }, {2 }, {3 }, {1 }}, };static const struct of_device_id mtk_iommu_of_ids[] = {drivers/iommu/mtk_iommu.h +0
-0@@ -41,10 +41,11 @@ struct mtk_iommu_plat_data {/* HW will use the EMI clock if there isn't the "bclk". */ bool has_bclk;
drivers/iommu/mtk_iommu.h struct mtk_iommu_plat_data { · line 51
Quoted 10 lines
drivers/iommu/mtk_iommu.h +2
-1bool has_misc_ctrl; +bool has_sub_comm;bool has_vld_pa_rng;bool reset_axi;u32 inv_sel_reg; -unsigned char larbid_remap[MTK_LARB_NR_MAX ]; +unsigned char larbid_remap[8 ][4 ]; };struct mtk_iommu_domain ;
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
PATCH v3 6/7 iommu/mediatek: Add REG_MMU_WR_LEN definition preparing for mt6779
In reply to Chao HaoSome platforms(ex: mt6779) have a new register called by REG_MMU_WR_LEN to improve performance.
This patch add this register definition.
--- drivers/iommu/mtk_iommu.c | 10 ++++++++++ drivers/iommu/mtk_iommu.h | 2 ++ 2 files changed, 12 insertions(+)
drivers/iommu/mtk_iommu.c +10 -0
@@ -45,6 +45,8 @@#define F_MMU_STANDARD_AXI_MODE_BIT (BIT(3) | BIT(19))#define REG_MMU_DCM_DIS 0x050 +#define REG_MMU_WR_LEN 0x054 +#define F_MMU_WR_THROT_DIS_BIT (BIT(5) | BIT(21))#define REG_MMU_CTRL_REG 0x110#define F_MMU_TF_PROT_TO_PROGRAM_ADDR (2 << 4)
@@ -592,6 +594,12 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data)writel_relaxed (regval, data->base +REG_MMU_VLD_PA_RNG ); }writel_relaxed (0 , data->base +REG_MMU_DCM_DIS ); +if (data->plat_data->has_wr_len) { +/* write command throttling mode */ + regval =readl_relaxed (data->base +REG_MMU_WR_LEN ); + regval &= ~F_MMU_WR_THROT_DIS_BIT ; +writel_relaxed (regval, data->base +REG_MMU_WR_LEN ); + }if (data->plat_data->has_misc_ctrl) { regval =readl_relaxed (data->base +REG_MMU_MISC_CTRL );
@@ -744,6 +752,7 @@ static int __maybe_unused mtk_iommu_suspend(struct device *dev)struct mtk_iommu_suspend_reg *reg = &data->reg;void __iomem *base = data->base; + reg->wr_len =readl_relaxed (base +REG_MMU_WR_LEN ); reg->misc_ctrl =readl_relaxed (base +REG_MMU_MISC_CTRL ); reg->dcm_dis =readl_relaxed (base +REG_MMU_DCM_DIS ); reg->ctrl_reg =readl_relaxed (base +REG_MMU_CTRL_REG );
@@ -768,6 +777,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev)dev_err (data->dev,"Failed to enable clk(%d) in resume\n" , ret);return ret; } +writel_relaxed (reg->wr_len, base +REG_MMU_WR_LEN );writel_relaxed (reg->misc_ctrl, base +REG_MMU_MISC_CTRL );writel_relaxed (reg->dcm_dis, base +REG_MMU_DCM_DIS );writel_relaxed (reg->ctrl_reg, base +REG_MMU_CTRL_REG );
drivers/iommu/mtk_iommu.h +2 -0
@@ -25,6 +25,7 @@ struct mtk_iommu_suspend_reg {u32 int_main_control;u32 ivrp_paddr;u32 vld_pa_rng; +u32 wr_len; };enum mtk_iommu_plat {
@@ -43,6 +44,7 @@ struct mtk_iommu_plat_data {bool has_misc_ctrl;bool has_sub_comm;bool has_vld_pa_rng; +bool has_wr_len;bool reset_axi;u32 inv_sel_reg;unsigned char larbid_remap[8 ][4 ];
Signature · 1 line
2.18.0
PATCH v3 7/7 iommu/mediatek: Add mt6779 basic support
In reply to Chao Hao1. Start from mt6779, INVLDT_SEL move to offset=0x2c, so we add REG_MMU_INV_SEL_GEN2 definition and mt6779 uses it.
2. Change PROTECT_PA_ALIGN from 128 byte to 256 byte.
3. For REG_MMU_CTRL_REG register, we only need to change bit[2:0], others bits keep default value, ex: enable victim tlb.
4. Add mt6779_data to support mm_iommu HW init.
--- drivers/iommu/mtk_iommu.c | 18 +++++++++++++++--- drivers/iommu/mtk_iommu.h | 1 + 2 files changed, 16 insertions(+), 3 deletions(-)
drivers/iommu/mtk_iommu.c +15 -3
@@ -37,6 +37,7 @@#define REG_MMU_INVLD_START_A 0x024#define REG_MMU_INVLD_END_A 0x028 +#define REG_MMU_INV_SEL_GEN2 0x02c#define REG_MMU_INV_SEL_GEN1 0x038#define F_INVLD_EN0 BIT(0)#define F_INVLD_EN1 BIT(1)
@@ -97,7 +98,7 @@#define F_MMU_INT_ID_LARB_ID (a) (((a) >> 7) & 0x7)#define F_MMU_INT_ID_PORT_ID (a) (((a) >> 2) & 0x1f) -#define MTK_PROTECT_PA_ALIGN 128 +#define MTK_PROTECT_PA_ALIGN 256/* * Get the local arbiter ID and the portid within the larb arbiter
@@ -554,11 +555,12 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data)return ret; } + regval =readl_relaxed (data->base +REG_MMU_CTRL_REG );if (data->plat_data->m4u_plat ==M4U_MT8173 ) - regval =F_MMU_PREFETCH_RT_REPLACE_MOD | + regval |=F_MMU_PREFETCH_RT_REPLACE_MOD |F_MMU_TF_PROT_TO_PROGRAM_ADDR_MT8173 ;else - regval =F_MMU_TF_PROT_TO_PROGRAM_ADDR ; + regval |=F_MMU_TF_PROT_TO_PROGRAM_ADDR ;writel_relaxed (regval, data->base +REG_MMU_CTRL_REG ); regval = F_L2_MULIT_HIT_EN |
@@ -804,6 +806,15 @@ static const struct mtk_iommu_plat_data mt2712_data = { .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}}, }; +static const struct mtk_iommu_plat_data mt6779_data = { + .m4u_plat =M4U_MT6779 , + .larbid_remap = {{0 }, {1 }, {2 }, {3 }, {5 }, {7 ,8 }, {10 }, {9 }}, + .has_sub_comm = true, + .has_wr_len = true, + .has_misc_ctrl = true, + .inv_sel_reg =REG_MMU_INV_SEL_GEN2 , +}; +static const struct mtk_iommu_plat_data mt8173_data = { .m4u_plat =M4U_MT8173 , .has_4gb_mode = true,
@@ -822,6 +833,7 @@ static const struct mtk_iommu_plat_data mt8183_data = {static const struct of_device_id mtk_iommu_of_ids[] = { { .compatible ="mediatek,mt2712-m4u" , .data = &mt2712_data}, + { .compatible ="mediatek,mt6779-m4u" , .data = &mt6779_data}, { .compatible ="mediatek,mt8173-m4u" , .data = &mt8173_data}, { .compatible ="mediatek,mt8183-m4u" , .data = &mt8183_data}, {}
drivers/iommu/mtk_iommu.h +1 -0
@@ -31,6 +31,7 @@ struct mtk_iommu_suspend_reg {enum mtk_iommu_plat {M4U_MT2701 ,M4U_MT2712 , +M4U_MT6779 ,M4U_MT8173 ,M4U_MT8183 , };
Signature · 1 line
2.18.0
Yong Wu
maintainerRe: [PATCH v3 7/7] iommu/mediatek: Add mt6779 basic support
Quoted 18 lines · Chao Hao
1. Start from mt6779,
INVLDT_SELmove to offset=0x2c, so we addREG_MMU_INV_SEL_GEN2definition and mt6779 uses it.
2. ChangePROTECT_PA_ALIGNfrom 128 byte to 256 byte.
3. ForREG_MMU_CTRL_REGregister, we only need to change bit[2:0], others bits keep default value, ex: enable victim tlb.
4. Addmt6779_datato supportmm_iommuHW init.Signed-off-by Chao Hao <[email protected]>--- drivers/iommu/mtk_iommu.c | 18 +++++++++++++++--- drivers/iommu/mtk_iommu.h | 1 + 2 files changed, 16 insertions(+), 3 deletions(-)drivers/iommu/mtk_iommu.c +0
-0
drivers/iommu/mtk_iommu.c line 41
Quoted 5 lines
drivers/iommu/mtk_iommu.c +1
-0@@ -37,6 +37,7 @@#define REG_MMU_INVLD_START_A 0x024#define REG_MMU_INVLD_END_A 0x028 +#define REG_MMU_INV_SEL_GEN2 0x02c#define REG_MMU_INV_SEL_GEN1 0x038
Normally the register name comes from the CODA. In the lasted CODA, this is called "MMU_INVLDT_SEL". But it's same with the previous 0x38 totally. Using _GEN1, _GEN2 is ok for me. Please add its coda name in the comment. like:
#define REG_MMU_INV_SEL_GEN2 0x02c /* MMU_INVLDT_SEL */
Quoted 12 lines
drivers/iommu/mtk_iommu.c +1
-1#define F_INVLD_EN0 BIT(0)#define F_INVLD_EN1 BIT(1)@@ -97,7 +98,7 @@#define F_MMU_INT_ID_LARB_ID (a) (((a) >> 7) & 0x7)#define F_MMU_INT_ID_PORT_ID (a) (((a) >> 2) & 0x1f) -#define MTK_PROTECT_PA_ALIGN 128 +#define MTK_PROTECT_PA_ALIGN 256/* * Get the local arbiter ID and the portid within the larb arbiter
drivers/iommu/mtk_iommu.c static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) · line 560
Quoted 7 lines
drivers/iommu/mtk_iommu.c +2
-1@@ -554,11 +555,12 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data)return ret; } + regval =readl_relaxed (data->base +REG_MMU_CTRL_REG );if (data->plat_data->m4u_plat ==M4U_MT8173 ) - regval = F_MMU_PREFETCH_RT_REPLACE_MOD | + regval |= F_MMU_PREFETCH_RT_REPLACE_MOD |
The default value is not ok for mt8173(Its bit9 is in_order_write_en, we could not use its default 1'b1). thus, Don't touch this line.
Quoted 8 lines
drivers/iommu/mtk_iommu.c +1
-1F_MMU_TF_PROT_TO_PROGRAM_ADDR_MT8173 ; else - regval =F_MMU_TF_PROT_TO_PROGRAM_ADDR ; + regval |= F_MMU_TF_PROT_TO_PROGRAM_ADDR;writel_relaxed (regval, data->base +REG_MMU_CTRL_REG ); regval = F_L2_MULIT_HIT_EN |
drivers/iommu/mtk_iommu.c static const struct mtk_iommu_plat_data mt2712_data = { · line 815
Quoted 10 lines
drivers/iommu/mtk_iommu.c +7
-0@@ -804,6 +806,15 @@ static const struct mtk_iommu_plat_data mt2712_data = { .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}}, }; +static const struct mtk_iommu_plat_data mt6779_data = { + .m4u_plat =M4U_MT6779 , + .larbid_remap = {{0 }, {1 }, {2 }, {3 }, {5 }, {7 ,8 }, {10 }, {9 }}, + .has_sub_comm = true, + .has_wr_len = true, + .has_misc_ctrl = true, + .inv_sel_reg =REG_MMU_INV_SEL_GEN2 ,
align '=' a bit.
Quoted 18 lines
drivers/iommu/mtk_iommu.c +3
-0+}; +static const struct mtk_iommu_plat_data mt8173_data = { .m4u_plat =M4U_MT8173 , .has_4gb_mode = true,@@ -822,6 +833,7 @@ static const struct mtk_iommu_plat_data mt8183_data = {static const struct of_device_id mtk_iommu_of_ids[] = { { .compatible ="mediatek,mt2712-m4u" , .data = &mt2712_data}, + { .compatible ="mediatek,mt6779-m4u" , .data = &mt6779_data}, { .compatible ="mediatek,mt8173-m4u" , .data = &mt8173_data}, { .compatible ="mediatek,mt8183-m4u" , .data = &mt8183_data}, {}drivers/iommu/mtk_iommu.h +0
-0
drivers/iommu/mtk_iommu.h struct mtk_iommu_suspend_reg { · line 37
Quoted 7 lines
drivers/iommu/mtk_iommu.h +1
-0@@ -31,6 +31,7 @@ struct mtk_iommu_suspend_reg {enum mtk_iommu_plat {M4U_MT2701 ,M4U_MT2712 , +M4U_MT6779 ,M4U_MT8173 ,M4U_MT8183 , };
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu