Skip to contentSkip to conversation

FAILED: patch "[PATCH] iio: sca3000: Remove an erroneous 'get_device()'" failed to apply to 4.9-stable tree

PATCH [email protected] 2 participants 2 messages May 25, 2020

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 928edefbc18cd8433f7df235c6e09a9306e7d580 Mon Sep 17 00:00:00 2001
From: Christophe JAILLET <[email protected]>
Date: Wed, 6 May 2020 05:52:06 +0200
Subject: [PATCH] iio: sca3000: Remove an erroneous 'get_device()'

This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.
Remove it.

While at it add a missing \n at the end of the message.

Fixes 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)")
drivers/iio/accel/sca3000.c +1 -1
index 66d768d971e1..6e429072e44a 100644
@@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
 	st->tx[0] = SCA3000_READ_REG(reg_address_high);
 	ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
 	if (ret) {
-		dev_err(get_device(&st->us->dev), "problem reading register");
+		dev_err(&st->us->dev, "problem reading register\n");
 		return ret;
 	}
 
maintainer
#1 lore raw
Quoted 21 lines · On Mon, May 25, 2020 at 03:55:49PM +0200, [email protected] wrote:

The patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 928edefbc18cd8433f7df235c6e09a9306e7d580 Mon Sep 17 00:00:00 2001
From: Christophe JAILLET <[email protected]>
Date: Wed, 6 May 2020 05:52:06 +0200
Subject: [PATCH] iio: sca3000: Remove an erroneous 'get_device()'

This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.
Remove it.

Quoted 6 lines

While at it add a missing \n at the end of the message.

Fixes 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)")

Back in 4.9 and 4.4 this code was in staging, I've fixed up the patch to reflect the old path and queued it for 4.9 and 4.4.

Signature · 2 lines
Thanks,
Sasha