Skip to contentSkip to conversation

Bluetooth: hci_qca: Improve controller ID info log level

PATCH In review Zijun Hu 3 participants 3 messages May 29, 2020 – Jun 1, 2020

Subsystems (3)
lore
Share & tools
lore

Zijun Hu

author
#0 lore raw

PATCH v4 1/1 Bluetooth: hci_qca: Improve controller ID info log level

Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO.

---
Changes in v4:
- correct coding style of qca_read_soc_version()

Changes in v3:
- correct coding style

Changes in v2:
- adjust controller ID info print order

 drivers/bluetooth/btqca.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
drivers/bluetooth/btqca.c +9 -5
index 3ea866d44568..5629e2c80b97 100644
@@ -74,17 +74,21 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
 
 	ver = (struct qca_btsoc_version *)(edl->data);
 
-	BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
-	BT_DBG("%s: Patch  :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
-	BT_DBG("%s: ROM    :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
-	BT_DBG("%s: SOC    :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
+	bt_dev_info(hdev, "QCA Product ID   :0x%08x",
+		    le32_to_cpu(ver->product_id));
+	bt_dev_info(hdev, "QCA SOC Version  :0x%08x",
+		    le32_to_cpu(ver->soc_id));
+	bt_dev_info(hdev, "QCA ROM Version  :0x%08x",
+		    le16_to_cpu(ver->rom_ver));
+	bt_dev_info(hdev, "QCA Patch Version:0x%08x",
+		    le16_to_cpu(ver->patch_ver));
 
 	/* QCA chipset version can be decided by patch and SoC
 	 * version, combination with upper 2 bytes from SoC
 	 * and lower 2 bytes from patch will be used.
 	 */
 	*soc_version = (le32_to_cpu(ver->soc_id) << 16) |
-			(le16_to_cpu(ver->rom_ver) & 0x0000ffff);
+		(le16_to_cpu(ver->rom_ver) & 0x0000ffff);
 	if (*soc_version == 0)
 		err = -EILSEQ;
 
Signature · 1 line
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
maintainer
#2 lore raw
In reply to Zijun Hu

Hi Zijun,

Quoted 8 lines

Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO.

---
Changes in v4:
- correct coding style of qca_read_soc_version()

Quoted 8 lines

Changes in v3:
- correct coding style

Changes in v2:
- adjust controller ID info print order

drivers/bluetooth/btqca.c | 14 +++++++++-----

1 file changed, 9 insertions(+), 5 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel