Bluetooth: btmtkuart: Use serdev_device_write_buf() instead of serdev_device_write()
Subsystems (3)
PATCH 1/1 Bluetooth: btmtkuart: Use serdev_device_write_buf() instead of serdev_device_write()
serdev_device_write() is not appropriate at here because serdev_device_write_wakeup() is not used to release completion hold by the former at @write_wakeup member of struct serdev_device_ops.
Fix by using serdev_device_write_buf() instead of serdev_device_write().
Signed-off-by Zijun Hu <[email protected]>
--- drivers/bluetooth/btmtkuart.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/bluetooth/btmtkuart.c +1 -2
@@ -695,8 +695,7 @@ static int btmtkuart_change_baudrate(struct hci_dev *hdev)/* Send a dummy byte 0xff to activate the new baudrate */ param =0xff ; - err =serdev_device_write (bdev->serdev, ¶m,sizeof (param), -MAX_SCHEDULE_TIMEOUT ); + err =serdev_device_write_buf (bdev->serdev, ¶m,sizeof (param));if (err <0 || err <sizeof (param))return err;
Signature · 1 line
2.7.4
Marcel Holtmann
maintainerHi Zijun,
Quoted 10 lines
serdev_device_write()is not appropriate at here becauseserdev_device_write_wakeup()is not used to release completion hold by the former at @write_wakeup member of structserdev_device_ops.Fix by using
serdev_device_write_buf()instead ofserdev_device_write().Signed-off-by Zijun Hu <[email protected]>---
drivers/bluetooth/btmtkuart.c| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel