Skip to contentSkip to conversation

qemu-dm monitor doesn't support the quit command.

PATCH In review Kasai Takanori 2 participants 2 messages Dec 22, 2006 – Jan 4, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu-dm monitor doesn't support the quit command.

Hi All,

It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake. I think that I should prohibit the quit command of qemu-dm.

Thanks

--
Takanori Kasai

# HG changeset patch
# User [email protected]
# Node ID ef195d27a54ef7d5e256788d5a1a51ee55e2bcf6 # Parent 360eb996fa38319867a74bf581c734a80bf6839d The quit command of the Qemu-dm monitor is made invalid.

tools/ioemu/monitor.c +1 -2
diff -r 360eb996fa38 -r ef195d27a54e tools/ioemu/monitor.c
@@ -309,8 +309,7 @@ static void do_info_history (void)
 
 static void do_quit(void)
 {
-    destroy_hvm_domain();
-    exit(0);
+    term_printf("quit is not supported\n");
 }
 
 static int eject_device(BlockDriverState *bs, int force)
#1 lore raw
Quoted 6 lines · Kasai Takanori

Hi All,

It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake. I think that I should prohibit the quit command of qemu-dm.

Better #ifdef out the quit command for HVM then, so people aren't tempted to use it.

(Whatever HVM is, qemu doesn't know about it for now, so this patch is currently not suitable for the qemu CVS.)

Thiemo