mfd: mt6360: add pmic mt6360 driver
Subsystems (2)
PATCH v10 1/1 mfd: mt6360: add pmic mt6360 driver
From: Gene Chen <[email protected]>
Add MFD driver for mt6360 pmic chip include Battery Charger/ USB_PD/Flash, LED/RGB and LED/LDO/Buck
--- drivers/mfd/Kconfig | 12 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6360-core.c | 424 +++++++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++++++ 4 files changed, 677 insertions(+) create mode 100644 drivers/mfd/mt6360-core.c create mode 100644 include/linux/mfd/mt6360.h
changelogs between v1 & v2
- include missing header file
changelogs between v2 & v3
- add changelogs
changelogs between v3 & v4
- fix Kconfig description
- replace mt6360_pmu_info with mt6360_pmu_data
- replace probe with probe_new
- remove unnecessary irq_chip variable
- remove annotation
- replace MT6360_MFD_CELL with OF_MFD_CELL
changelogs between v4 & v5
- remove unnecessary parse dt function
- use devm_i2c_new_dummy_device
- add base-commit message
changelogs between v5 & v6
- review return value
- remove i2c id_table
- use GPL license v2
changelogs between v6 & v7
- add author description
- replace MT6360_REGMAP_IRQ_REG by REGMAP_IRQ_REG_LINE
- remove mt6360-private.h
changelogs between v7 & v8
- fix kbuild auto reboot by include interrupt header
changelogs between v8 & v9
- fix GPL license out of date
- add commit message about Acked-for-MFD-by
changelogs between v9 & v10
- fix duplicate define of kbuild test reboot initializer-overrides
- sync commit message format
drivers/mfd/Kconfig +12 -0
@@ -870,6 +870,18 @@ config MFD_MAX8998 additional drivers must be enabled in order to use the functionality of the device. +config MFD_MT6360 + tristate "Mediatek MT6360 SubPMIC" + select MFD_CORE + select REGMAP_I2C + select REGMAP_IRQ + depends on I2C + help + Say Y here to enable MT6360 PMU/PMIC/LDO functional support. + PMU part includes Charger, Flashlight, RGB LED + PMIC part includes 2-channel BUCKs and 2-channel LDOs + LDO part includes 4-channel LDOs + config MFD_MT6397 tristate "MediaTek MT6397 PMIC Support" select MFD_CORE
drivers/mfd/Makefile +1 -0
@@ -239,6 +239,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o +obj-$(CONFIG_MFD_MT6360) += mt6360-core.o mt6397-objs := mt6397-core.o mt6397-irq.o obj-$(CONFIG_MFD_MT6397) += mt6397.o obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.o
drivers/mfd/mt6360-core.c new file +424 -0
424 lines not on this page · raw message
include/linux/mfd/mt6360.h new file +240 -0
240 lines not on this page · raw message
Signature · 1 line
2.7.4
Quoted 7 lines · Gene Chen
From: Gene Chen <[email protected]>
Add MFD driver for mt6360 pmic chip include Battery Charger/ USB_PD/Flash, LED/RGB and LED/LDO/Buck
Signed-off-by Gene Chen <[email protected]>Signed-off-by Lee Jones <[email protected]>
I did not sign this off.
Quoted 38 lines
--- drivers/mfd/Kconfig | 12 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6360-core.c | 424 +++++++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++++++ 4 files changed, 677 insertions(+) create mode 100644 drivers/mfd/mt6360-core.c create mode 100644 include/linux/mfd/mt6360.hchangelogs between v1 & v2
- include missing header filechangelogs between v2 & v3
- add changelogschangelogs between v3 & v4
- fixKconfigdescription
- replacemt6360_pmu_infowithmt6360_pmu_data
- replace probe withprobe_new
- remove unnecessaryirq_chipvariable
- remove annotation
- replaceMT6360_MFD_CELLwithOF_MFD_CELLchangelogs between v4 & v5
- remove unnecessary parse dt function
- usedevm_i2c_new_dummy_device
- add base-commit messagechangelogs between v5 & v6
- review return value
- remove i2cid_table
- use GPL license v2changelogs between v6 & v7
- add author description
- replaceMT6360_REGMAP_IRQ_REGbyREGMAP_IRQ_REG_LINE
- removemt6360-private.h
Quoted 8 lines
changelogs between v7 & v8
- fix kbuild auto reboot by include interrupt headerchangelogs between v8 & v9
- fix GPL license out of date
- add commit message about Acked-for-MFD-bychangelogs between v9 & v10
v9 of this patch is already applied.
You cannot send a v10.
Quoted 1 line
- fix duplicate define of kbuild test reboot initializer-overrides
I fixed this already.
Quoted 1 line
- sync commit message format
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Matthias Brugger
maintainerQuoted 4 lines · Lee Jones
Quoted 2 lines · Gene Chen
From: Gene Chen <[email protected]>
Quoted 8 lines
Quoted 5 lines
Add MFD driver for mt6360 pmic chip include Battery Charger/ USB_PD/Flash, LED/RGB and LED/LDO/Buck
Signed-off-by Gene Chen <[email protected]>Signed-off-by Lee Jones <[email protected]>I did not sign this off.
You are right, you provided your Acked-for-MFD-by and took an earlier version of the patch [1]. But as this didn't show up in linux-next I suppose you dropped it afterwards because of kbuild test errors (deducing from the changes log).
I suppose if this errors are fixed now, we should be fine :)
Regards,
Matthias
[1]
https://lkml.kernel.org/lkml/[email protected]/T/#m75e8ee81950ee34e155eccd2dc5ad9b1d2cef40a
Quoted 59 lines
Quoted 38 lines
--- drivers/mfd/Kconfig | 12 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6360-core.c | 424 +++++++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++++++ 4 files changed, 677 insertions(+) create mode 100644 drivers/mfd/mt6360-core.c create mode 100644 include/linux/mfd/mt6360.hchangelogs between v1 & v2
- include missing header filechangelogs between v2 & v3
- add changelogschangelogs between v3 & v4
- fixKconfigdescription
- replacemt6360_pmu_infowithmt6360_pmu_data
- replace probe withprobe_new
- remove unnecessaryirq_chipvariable
- remove annotation
- replaceMT6360_MFD_CELLwithOF_MFD_CELLchangelogs between v4 & v5
- remove unnecessary parse dt function
- usedevm_i2c_new_dummy_device
- add base-commit messagechangelogs between v5 & v6
- review return value
- remove i2cid_table
- use GPL license v2changelogs between v6 & v7
- add author description
- replaceMT6360_REGMAP_IRQ_REGbyREGMAP_IRQ_REG_LINE
- removemt6360-private.hQuoted 8 lines
changelogs between v7 & v8
- fix kbuild auto reboot by include interrupt headerchangelogs between v8 & v9
- fix GPL license out of date
- add commit message about Acked-for-MFD-bychangelogs between v9 & v10
v9 of this patch is already applied.
You cannot send a v10.
Quoted 1 line
- fix duplicate define of kbuild test reboot initializer-overrides
I fixed this already.
Quoted 1 line
- sync commit message format
Quoted 13 lines · Matthias Brugger
Quoted 10 lines · Lee Jones
Quoted 7 lines · Gene Chen
From: Gene Chen <[email protected]>
Add MFD driver for mt6360 pmic chip include Battery Charger/ USB_PD/Flash, LED/RGB and LED/LDO/Buck
Signed-off-by Gene Chen <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 6 lines
Quoted 2 lines
I did not sign this off.
You are right, you provided your Acked-for-MFD-by and took an earlier version of the patch [1]. But as this didn't show up in linux-next I suppose you dropped it afterwards because of kbuild test errors (deducing from the changes log).
If the builders can see it, -next can pull from it.
It was never dropped.
Quoted 1 line
I suppose if this errors are fixed now, we should be fine :)
Indeed. No more build errors. :)
Signature · 9 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel