Skip to contentSkip to conversation

perf svghelper: fix memory leak in svg_build_topology_map

PATCH New Li Bin 1 participant 1 message Jun 3, 2020 perf events

lore
Share & tools
lore

Li Bin

author
#0 lore raw

PATCH 1/1 perf svghelper: fix memory leak in svg_build_topology_map

Fix leak of memory pointed to by t.sib_thr and t.sib_core in svg_build_topology_map in the non-error path.

---
 tools/perf/util/svghelper.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/svghelper.c +3 -3
index 96f941e..d50955f 100644
@@ -754,6 +754,7 @@ int svg_build_topology_map(struct perf_env *env)
 	int i, nr_cpus;
 	struct topology t;
 	char *sib_core, *sib_thr;
+	int ret = -1;
 
 	nr_cpus = min(env->nr_cpus_online, MAX_NR_CPUS);
 
@@ -798,12 +799,11 @@ int svg_build_topology_map(struct perf_env *env)
 		topology_map[i] = -1;
 
 	scan_core_topology(topology_map, &t, nr_cpus);
-
-	return 0;
+	ret = 0;
 
 exit:
 	zfree(&t.sib_core);
 	zfree(&t.sib_thr);
 
-	return -1;
+	return ret;
 }
Signature · 1 line
1.7.12.4