ath11k: Fix resource leak in QMI send message error path
PATCH 1/1 ath11k: Fix resource leak in QMI send message error path
QMI client calling qmi_txn_init() must call either qmi_txn_wait() or qmi_txn_cancel() to free up the allocated transaction id. There are many error cases leaking this resource. Found in code review.
Tested-on: Compile tested only
Signed-off-by Vasanthakumar Thiagarajan <[email protected]>
--- drivers/net/wireless/ath/ath11k/qmi.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/wireless/ath/ath11k/qmi.c +7 -0
@@ -1535,6 +1535,7 @@ static int ath11k_qmi_host_cap_send(struct ath11k_base *ab)QMI_WLANFW_HOST_CAP_REQ_MSG_V01_MAX_LEN , qmi_wlanfw_host_cap_req_msg_v01_ei, &req);if (ret <0 ) { +qmi_txn_cancel (&txn);ath11k_warn (ab,"Failed to send host capability request,err = %d\n" , ret); goto out; }
@@ -1596,6 +1597,7 @@ static int ath11k_qmi_fw_ind_register_send(struct ath11k_base *ab)QMI_WLANFW_IND_REGISTER_REQ_MSG_V01_MAX_LEN , qmi_wlanfw_ind_register_req_msg_v01_ei, req);if (ret <0 ) { +qmi_txn_cancel (&txn);ath11k_warn (ab,"Failed to send indication register request, err = %d\n" , ret); goto out;
@@ -1652,6 +1654,7 @@ static int ath11k_qmi_respond_fw_mem_request(struct ath11k_base *ab)QMI_WLANFW_RESPOND_MEM_REQ_MSG_V01_MAX_LEN , qmi_wlanfw_respond_mem_req_msg_v01_ei, req);if (ret <0 ) { +qmi_txn_cancel (&txn);ath11k_warn (ab,"qmi failed to respond memory request, err = %d\n" , ret); goto out;
@@ -1730,6 +1733,7 @@ static int ath11k_qmi_request_target_cap(struct ath11k_base *ab)QMI_WLANFW_CAP_REQ_MSG_V01_MAX_LEN , qmi_wlanfw_cap_req_msg_v01_ei, &req);if (ret <0 ) { +qmi_txn_cancel (&txn);ath11k_warn (ab,"qmi failed to send target cap request, err = %d\n" , ret); goto out;
@@ -1936,6 +1940,7 @@ static int ath11k_qmi_wlanfw_m3_info_send(struct ath11k_base *ab)QMI_WLANFW_M3_INFO_REQ_MSG_V01_MAX_MSG_LEN , qmi_wlanfw_m3_info_req_msg_v01_ei, &req);if (ret <0 ) { +qmi_txn_cancel (&txn);ath11k_warn (ab,"qmi failed to send M3 information request, err = %d\n" , ret); goto out;
@@ -1982,6 +1987,7 @@ static int ath11k_qmi_wlanfw_mode_send(struct ath11k_base *ab,QMI_WLANFW_WLAN_MODE_REQ_MSG_V01_MAX_LEN , qmi_wlanfw_wlan_mode_req_msg_v01_ei, &req);if (ret <0 ) { +qmi_txn_cancel (&txn);ath11k_warn (ab,"qmi failed to send mode request, mode: %d, err = %d\n" , mode, ret); goto out;
@@ -2063,6 +2069,7 @@ static int ath11k_qmi_wlanfw_wlan_cfg_send(struct ath11k_base *ab)QMI_WLANFW_WLAN_CFG_REQ_MSG_V01_MAX_LEN , qmi_wlanfw_wlan_cfg_req_msg_v01_ei, req);if (ret <0 ) { +qmi_txn_cancel (&txn);ath11k_warn (ab,"qmi failed to send wlan config request, err = %d\n" , ret); goto out;
Signature · 7 lines
2.7.4 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k