Skip to contentSkip to conversation

ath11k: removing redundant reo unlock followed by immediate lock

PATCH In review Sowmiya Sree Elavalagan 2 participants 3 messages Jun 9, 2020 – Jun 15, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: removing redundant reo unlock followed by immediate lock

Removed reo cmd lock and unlock which was acquiring the lock immediately after unlock. Done for code clean up.

---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +0 -2
index a54610d..a010cf7 100644
@@ -653,10 +653,8 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx,
 	spin_lock_bh(&dp->reo_cmd_lock);
 	list_add_tail(&elem->list, &dp->reo_cmd_cache_flush_list);
 	dp->reo_cmd_cache_flush_count++;
-	spin_unlock_bh(&dp->reo_cmd_lock);
 
 	/* Flush and invalidate aged REO desc from HW cache */
-	spin_lock_bh(&dp->reo_cmd_lock);
 	list_for_each_entry_safe(elem, tmp, &dp->reo_cmd_cache_flush_list,
 				 list) {
 		if (dp->reo_cmd_cache_flush_count > DP_REO_DESC_FREE_THRESHOLD ||
Signature · 1 line
2.7.4
#1 lore raw
Quoted 5 lines · Sowmiya Sree Elavalagan

Removed reo cmd lock and unlock which was acquiring the lock immediately after unlock. Done for code clean up.

Patch applied to ath-next branch of ath.git, thanks.

8cacd0389c4f ath11k: removing redundant reo unlock followed by immediate lock

Signature · 9 lines
https://patchwork.kernel.org/patch/11595859/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#2 lore raw
In reply to Sowmiya Sree Elavalagan
Quoted 5 lines · Sowmiya Sree Elavalagan

Removed reo cmd lock and unlock which was acquiring the lock immediately after unlock. Done for code clean up.

Patch applied to ath-next branch of ath.git, thanks.

8cacd0389c4f ath11k: removing redundant reo unlock followed by immediate lock

Signature · 3 lines
https://patchwork.kernel.org/patch/11595859/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches