sparc: piggyback: handle invalid image
PATCH 1/1 sparc: piggyback: handle invalid image
With an old elftoaout, the generation of tftpboot.img fail with "lseek:
invalid argument".
This is due to offset being negative.
Instead of printing this error message, let's print a better one.
Signed-off-by Corentin Labbe <[email protected]>
--- arch/sparc/boot/piggyback.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/sparc/boot/piggyback.c +4 -0
@@ -154,6 +154,10 @@ static off_t get_hdrs_offset(int kernelfd, const char *filename) offset -=LOOKBACK ;/* skip a.out header */ offset +=AOUT_TEXT_OFFSET ; +if (offset <0 ) { + errno = -EINVAL ; +die ("Calculated a negative offset, probably elftoaout generated an invalid image. Did you use a recent elftoaout ?" ); + }if (lseek (kernelfd, offset,SEEK_SET ) <0 )die ("lseek" );if (read (kernelfd, buffer,BUFSIZE ) !=BUFSIZE )
Signature · 1 line
2.26.2
From: Corentin Labbe <[email protected]>
Date: Wed, 10 Jun 2020 07:55:19 +0000
Quoted 7 lines
With an old elftoaout, the generation of tftpboot.img fail with "lseek:
invalid argument".
This is due to offset being negative.Instead of printing this error message, let's print a better one.
Signed-off-by Corentin Labbe <[email protected]>
Applied, thank you.