FAILED: patch "[PATCH] ima: Set again build_ima_appraise variable" failed to apply to 5.4-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From b59fda449cf07f2db3be3a67142e6c000f5e8d79 Mon Sep 17 00:00:00 2001
From: Krzysztof Struczynski <[email protected]>
Date: Mon, 27 Apr 2020 12:28:59 +0200
Subject: [PATCH] ima: Set again build_ima_appraise variable
After adding the new add_rule() function in commit c52657d93b05 ("ima: refactor ima_init_policy()"), all appraisal flags are added to the temp_ima_appraise variable. Revert to the previous behavior instead of removing build_ima_appraise, to benefit from the protection offered by __ro_after_init.
The mentioned commit introduced a bug, as it makes all the flags modifiable, while build_ima_appraise flags can be protected with __ro_after_init.
security/integrity/ima/ima_policy.c +8 -2
@@ -643,8 +643,14 @@ static void add_rules(struct ima_rule_entry *entries, int count,list_add_tail (&entry->list, &ima_policy_rules); } -if (entries[i].action ==APPRAISE ) - temp_ima_appraise |=ima_appraise_flag (entries[i].func); +if (entries[i].action ==APPRAISE ) { +if (entries != build_appraise_rules) + temp_ima_appraise |= +ima_appraise_flag (entries[i].func); +else + build_ima_appraise |= +ima_appraise_flag (entries[i].func); + } } }