sysreset: syscon: Don't assume default value for offset and mask property
Subsystems (2)
PATCH 1/5 sysreset: syscon: Don't assume default value for offset and mask property
From: Bin Meng <[email protected]>
Per the DT binding, <offset> is a required property. Let's abort the probe if it is missing. For the <mask> property, current codes assume a default value of zero, which is not correct either.
---
drivers/sysreset/sysreset_syscon.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/sysreset/sysreset_syscon.c +12 -2
@@ -41,6 +41,7 @@ static struct sysreset_ops syscon_reboot_ops = {int syscon_reboot_probe (struct udevice *dev) {struct syscon_reboot_priv *priv =dev_get_priv (dev); +int err; priv->regmap =syscon_regmap_lookup_by_phandle (dev,"regmap" );if (IS_ERR (priv->regmap)) {
@@ -48,8 +49,17 @@ int syscon_reboot_probe(struct udevice *dev)return -ENODEV ; } - priv->offset =dev_read_u32_default (dev,"offset" ,0 ); - priv->mask =dev_read_u32_default (dev,"mask" ,0 ); + err =dev_read_u32 (dev,"offset" , &priv->offset); +if (err) { +pr_err ("unable to find offset\n" ); +return -ENOENT ; + } + + err =dev_read_u32 (dev,"mask" , &priv->mask); +if (err) { +pr_err ("unable to find mask\n" ); +return -ENOENT ; + }return 0 ; }
Signature · 1 line
2.7.4
PATCH 2/5 sysreset: syscon: Support value property
From: Bin Meng <[email protected]>
Per the DT binding, <mask> and <value> property can have either one or both, and if <value> is missing, <mask> should be used, which is what current U-Boot sysreset_syscon driver supports.
This adds support to the <value> property to the driver, and <mask> semantics is updated to really be a mask to the value if both exist.
---
drivers/sysreset/sysreset_syscon.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-)
drivers/sysreset/sysreset_syscon.c +17 -5
@@ -19,6 +19,7 @@ struct syscon_reboot_priv {struct regmap *regmap;unsigned int offset;unsigned int mask; +unsigned int value; };static int syscon_reboot_request (struct udevice *dev,enum sysreset_t type)
@@ -29,7 +30,7 @@ static int syscon_reboot_request(struct udevice *dev, enum sysreset_t type)if (type != driver_data)return -EPROTONOSUPPORT ; -regmap_write (priv->regmap, priv->offset, priv->mask); +regmap_update_bits (priv->regmap, priv->offset, priv->mask, priv->value);return -EINPROGRESS ; }
@@ -42,6 +43,7 @@ int syscon_reboot_probe(struct udevice *dev) {struct syscon_reboot_priv *priv =dev_get_priv (dev);int err; +int mask_err, value_err; priv->regmap =syscon_regmap_lookup_by_phandle (dev,"regmap" );if (IS_ERR (priv->regmap)) {
@@ -55,10 +57,20 @@ int syscon_reboot_probe(struct udevice *dev)return -ENOENT ; } - err =dev_read_u32 (dev,"mask" , &priv->mask); -if (err) { -pr_err ("unable to find mask\n" ); -return -ENOENT ; + mask_err =dev_read_u32 (dev,"mask" , &priv->mask); + value_err =dev_read_u32 (dev,"value" , &priv->value); +if (mask_err && value_err) { +pr_err ("unable to find mask and value\n" ); +return -EINVAL ; + } + +if (value_err) { +/* support old binding */ + priv->value = priv->mask; + priv->mask =0xffffffff ; + }else if (mask_err) { +/* support value without mask*/ + priv->mask =0xffffffff ; }return 0 ;
Signature · 1 line
2.7.4
PATCH 2/5 sysreset: syscon: Support value property
Quoted 7 lines · Bin Meng
From: Bin Meng <[email protected]>
Per the DT binding, <mask> and <value> property can have either one or both, and if <value> is missing, <mask> should be used, which is what current U-Boot
sysreset_syscondriver supports.
Quoted 8 lines
This adds support to the <value> property to the driver, and <mask> semantics is updated to really be a mask to the value if both exist.
Signed-off-by Bin Meng <[email protected]>---
drivers/sysreset/sysreset_syscon.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-)
PATCH 2/5 sysreset: syscon: Support value property
In reply to Bin MengQuoted 18 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 2/5] sysreset: syscon: Support value property[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Per the DT binding, <mask> and <value> property can have either one or both, and if <value> is missing, <mask> should be used, which is what current U-Boot
sysreset_syscondriver supports.
Quoted 8 lines
This adds support to the <value> property to the driver, and <mask> semantics is updated to really be a mask to the value if both exist.
Signed-off-by Bin Meng <[email protected]>---
drivers/sysreset/sysreset_syscon.c| 22 +++++++++++++++++-----1 file changed, 17 insertions(+), 5 deletions(-)
PATCH 3/5 riscv: Do not build reset.c if SYSRESET is on
In reply to Bin MengFrom: Bin Meng <[email protected]>
SYSRESET uclass driver already provides all the reset APIs, hence exclude our own ad-hoc reset.c implementation.
---
arch/riscv/lib/Makefile | 2 ++ 1 file changed, 2 insertions(+)
arch/riscv/lib/Makefile +2 -0
@@ -20,7 +20,9 @@ obj-$(CONFIG_SBI) += sbi.o obj-$(CONFIG_SBI_IPI) += sbi_ipi.o endif obj-y += interrupts.o +ifeq ($(CONFIG_$(SPL_)SYSRESET),) obj-y += reset.o +endif obj-y += setjmp.o obj-$(CONFIG_$(SPL_)SMP) += smp.o obj-$(CONFIG_SPL_BUILD) += spl.o
Signature · 1 line
2.7.4
PATCH 3/5 riscv: Do not build reset.c if SYSRESET is on
Hello Bin,
Quoted 28 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: Tuesday, June 23, 2020 11:00 AM
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 3/5] riscv: Do not buildreset.cif SYSRESET is on[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
SYSRESET uclass driver already provides all the reset APIs, hence exclude our own ad-hoc
reset.cimplementation.Signed-off-by Bin Meng <[email protected]>---
arch/riscv/lib/Makefile | 2 ++ 1 file changed, 2 insertions(+)arch/riscv/lib/Makefile +0
-0
arch/riscv/lib/Makefile obj-$(CONFIG_SBI) += sbi.o · line 25
Quoted 6 lines
arch/riscv/lib/Makefile +2
-0@@ -20,7 +20,9 @@ obj-$(CONFIG_SBI) += sbi.o obj-$(CONFIG_SBI_IPI) += sbi_ipi.o endif obj-y += interrupts.o +ifeq ($(CONFIG_$(SPL_)SYSRESET),) obj-y += reset.o +endif
I could see reset get's built when SYSRESET in enabled
CC spl/arch/riscv/lib/interrupts.o CC spl/arch/riscv/lib/reset.o AS spl/arch/riscv/lib/setjmp.o
Should this have been?
ifneq ($(CONFIG_$(SPL_)SYSRESET),)
Thanks & BR,
Sagar
Quoted 5 lines
arch/riscv/lib/Makefile +0
-1obj-y += setjmp.o obj-$(CONFIG_$(SPL_)SMP) += smp.o obj-$(CONFIG_SPL_BUILD) += spl.o --2.7.4
PATCH 3/5 riscv: Do not build reset.c if SYSRESET is on
Hi Sagar,
Quoted 39 lines · Sagar Kadam
Hello Bin,
Quoted 28 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: Tuesday, June 23, 2020 11:00 AM
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 3/5] riscv: Do not buildreset.cif SYSRESET is on[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
SYSRESET uclass driver already provides all the reset APIs, hence exclude our own ad-hoc
reset.cimplementation.Signed-off-by Bin Meng <[email protected]>---
arch/riscv/lib/Makefile | 2 ++ 1 file changed, 2 insertions(+)arch/riscv/lib/Makefile +0
-0arch/riscv/lib/Makefile obj-$(CONFIG_SBI) += sbi.o · line 25
Quoted 6 lines
arch/riscv/lib/Makefile +2
-0@@ -20,7 +20,9 @@ obj-$(CONFIG_SBI) += sbi.o obj-$(CONFIG_SBI_IPI) += sbi_ipi.o endif obj-y += interrupts.o +ifeq ($(CONFIG_$(SPL_)SYSRESET),) obj-y += reset.o +endifI could see reset get's built when SYSRESET in enabled
Quoted 4 lines
CC spl/arch/riscv/lib/interrupts.o CC spl/arch/riscv/lib/reset.o AS spl/arch/riscv/lib/setjmp.o
This is because we don't enable CONFIG_SPL_SYSRESET in the board config. For SPL, normally we don't need to reset.
Quoted 3 lines
Should this have been?
ifneq ($(CONFIG_$(SPL_)SYSRESET),)
Regards,
Bin
PATCH 3/5 riscv: Do not build reset.c if SYSRESET is on
Hi Bin,
Quoted 61 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: Friday, June 26, 2020 7:26 AM
To: Sagar Kadam <[email protected]>
Cc: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; U-Boot Mailing List <u- boot at lists.denx.de>; Bin Meng <[email protected]>
Subject: Re: [PATCH 3/5] riscv: Do not buildreset.cif SYSRESET is on[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
Hi Sagar,
Quoted 7 lines · Sagar Kadam
Hello Bin,
Quoted 4 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: Tuesday, June 23, 2020 11:00 AM
To: Rick Chen <[email protected]>; Simon GlassQuoted 32 lines
Quoted 24 lines
Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 3/5] riscv: Do not buildreset.cif SYSRESET is on[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
SYSRESET uclass driver already provides all the reset APIs, hence exclude our own ad-hoc
reset.cimplementation.Signed-off-by Bin Meng <[email protected]>---
arch/riscv/lib/Makefile | 2 ++ 1 file changed, 2 insertions(+)arch/riscv/lib/Makefile index renamed from arch/riscv/lib/Makefile +0
-0b5e9324..6c503ff 100644
arch/riscv/lib/Makefile obj-$(CONFIG_SBI) += sbi.o · line 25
Quoted 6 lines
arch/riscv/lib/Makefile +2
-0@@ -20,7 +20,9 @@ obj-$(CONFIG_SBI) += sbi.o obj-$(CONFIG_SBI_IPI) += sbi_ipi.o endif obj-y += interrupts.o +ifeq ($(CONFIG_$(SPL_)SYSRESET),) obj-y += reset.o +endifI could see reset get's built when SYSRESET in enabled
Quoted 4 lines
CC spl/arch/riscv/lib/interrupts.o CC spl/arch/riscv/lib/reset.o AS spl/arch/riscv/lib/setjmp.o
Quoted 3 lines
This is because we don't enable
CONFIG_SPL_SYSRESETin the board config. For SPL, normally we don't need to reset.
Ok. Thanks for clarifying.
Looks good.
Quoted 6 lines
Quoted 3 lines
Should this have been?
ifneq ($(CONFIG_$(SPL_)SYSRESET),)Regards,
Bin
PATCH 3/5 riscv: Do not build reset.c if SYSRESET is on
In reply to Bin MengQuoted 14 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 3/5] riscv: Do not buildreset.cif SYSRESET is on[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Quoted 8 lines
SYSRESET uclass driver already provides all the reset APIs, hence exclude our own ad-hoc
reset.cimplementation.Signed-off-by Bin Meng <[email protected]>---
arch/riscv/lib/Makefile| 2 ++1 file changed, 2 insertions(+)
PATCH 4/5 riscv: qemu: Add syscon reboot and poweroff support
In reply to Bin MengFrom: Bin Meng <[email protected]>
This adds syscon reboot and poweroff support to QEMU RISC-V.
---
board/emulation/qemu-riscv/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)
board/emulation/qemu-riscv/Kconfig +4 -0
@@ -53,5 +53,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply NVME imply SPL_RAM_SUPPORT imply SPL_RAM_DEVICE + imply SYSRESET + imply SYSRESET_SYSCON + imply CMD_POWEROFF + imply SYSRESET_CMD_POWEROFF endif
Signature · 1 line
2.7.4
PATCH 4/5 riscv: qemu: Add syscon reboot and poweroff support
Quoted 14 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 4/5] riscv: qemu: Add syscon reboot and poweroff support[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Quoted 7 lines
This adds syscon reboot and poweroff support to QEMU RISC-V.
Signed-off-by Bin Meng <[email protected]>---
board/emulation/qemu-riscv/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
PATCH 5/5 riscv: sifive: fu540: Add gpio-restart support
In reply to Bin MengFrom: Bin Meng <[email protected]>
The HiFive Unleashed board wires GPIO pin#10 to the input of the system reset signal. This adds gpio reboot support.
---
board/sifive/fu540/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
board/sifive/fu540/Kconfig +2 -0
@@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply SMP imply MISC imply SIFIVE_OTP + imply SYSRESET + imply SYSRESET_GPIO endif
Signature · 1 line
2.7.4
PATCH 5/5 riscv: sifive: fu540: Add gpio-restart support
Hi,
Quoted 28 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: Tuesday, June 23, 2020 11:00 AM
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 5/5] riscv: sifive: fu540: Add gpio-restart support[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
The HiFive Unleashed board wires GPIO pin#10 to the input of the system reset signal. This adds gpio reboot support.
Signed-off-by Bin Meng <[email protected]>---
board/sifive/fu540/Kconfig | 2 ++ 1 file changed, 2 insertions(+)board/sifive/fu540/Kconfig index renamed from board/sifive/fu540/Kconfig +0
-086193d7..6f65681 100644
board/sifive/fu540/Kconfig config BOARD_SPECIFIC_OPTIONS # dummy · line 70
Quoted 6 lines
board/sifive/fu540/Kconfig +2
-0@@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply SMP imply MISC imply SIFIVE_OTP + imply SYSRESET + imply SYSRESET_GPIO
Looks Good.
Quoted 3 lines
board/sifive/fu540/Kconfig +0
-1endif --2.7.4
PATCH 5/5 riscv: sifive: fu540: Add gpio-restart support
In reply to Bin MengQuoted 14 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 5/5] riscv: sifive: fu540: Add gpio-restart support[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Quoted 8 lines
The HiFive Unleashed board wires GPIO pin#10 to the input of the system reset signal. This adds gpio reboot support.
Signed-off-by Bin Meng <[email protected]>---
board/sifive/fu540/Kconfig | 2 ++
1 file changed, 2 insertions(+)
PATCH 1/5 sysreset: syscon: Don't assume default value for offset and mask property
In reply to Bin MengQuoted 7 lines · Bin Meng
From: Bin Meng <[email protected]>
Per the DT binding, <offset> is a required property. Let's abort the probe if it is missing. For the <mask> property, current codes assume a default value of zero, which is not correct either.
Quoted 6 lines
Signed-off-by Bin Meng <[email protected]>---
drivers/sysreset/sysreset_syscon.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
PATCH 1/5 sysreset: syscon: Don't assume default value for offset and mask property
In reply to Bin MengQuoted 19 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask property[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Per the DT binding, <offset> is a required property. Let's abort the probe if it is missing. For the <mask> property, current codes assume a default value of zero, which is not correct either.
Quoted 5 lines
Signed-off-by Bin Meng <[email protected]>---
drivers/sysreset/sysreset_syscon.c| 14 ++++++++++++--1 file changed, 12 insertions(+), 2 deletions(-)
PATCH 1/5 sysreset: syscon: Don't assume default value for offset and mask property
Hi Rick,
Quoted 20 lines · Pragnesh Patel
Quoted 20 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask property[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Per the DT binding, <offset> is a required property. Let's abort the probe if it is missing. For the <mask> property, current codes assume a default value of zero, which is not correct either.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Bin Meng <[email protected]>---
drivers/sysreset/sysreset_syscon.c| 14 ++++++++++++--1 file changed, 12 insertions(+), 2 deletions(-)Reviewed-by Pragnesh Patel <[email protected]>
Would you please take the remaining 3 patches soon?
http://patchwork.ozlabs.org/project/uboot/list/?series=185161
Regards,
Bin
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/5 sysreset: syscon: Don't assume default value for offset and mask property
Hi Tom
Quoted 32 lines
From: Bin Meng [mailto:bmeng.cn at gmail.com]
Sent: Friday, July 17, 2020 2:54 PM
To: Pragnesh Patel
Cc: Bin Meng; Rick Jian-Zhi Chen(???); Simon Glass; U-Boot Mailing List; Sagar Kadam
Subject: Re: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask propertyHi Rick,
Quoted 23 lines · Pragnesh Patel
Quoted 23 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask property[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Per the DT binding, <offset> is a required property. Let's abort the probe if it is missing. For the <mask> property, current codes assume a default value of zero, which is not correct either.
Signed-off-by Bin Meng <[email protected]>---
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
drivers/sysreset/sysreset_syscon.c| 14 ++++++++++++--1 file changed, 12 insertions(+), 2 deletions(-)Reviewed-by Pragnesh Patel <[email protected]>Would you please take the remaining 3 patches soon?
http://patchwork.ozlabs.org/project/uboot/list/?series=185161
May I ask for your opinions about these three SYSRESET patchs. If they are OK to be pick up in my next PR, though they have been rejected in previous riscv PR ?
https://www.mail-archive.com/u-boot at lists.denx.de/msg375465.html
Thanks,
Rick
Quoted 3 lines
Regards,
Bin
PATCH 1/5 sysreset: syscon: Don't assume default value for offset and mask property
Hi Rick,
Quoted 40 lines · Rick Chen
Hi Tom
Quoted 37 lines
From: Bin Meng [mailto:bmeng.cn at gmail.com]
Sent: Friday, July 17, 2020 2:54 PM
To: Pragnesh Patel
Cc: Bin Meng; Rick Jian-Zhi Chen(???); Simon Glass; U-Boot Mailing List; Sagar Kadam
Subject: Re: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask propertyHi Rick,
Quoted 27 lines · Pragnesh Patel
Quoted 20 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 23 June 2020 11:00
To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; Pragnesh Patel <[email protected]>; Sagar Kadam <[email protected]>; U-Boot Mailing List <[email protected]>
Cc: Bin Meng <[email protected]>
Subject: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask property[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
From: Bin Meng <[email protected]>
Per the DT binding, <offset> is a required property. Let's abort the probe if it is missing. For the <mask> property, current codes assume a default value of zero, which is not correct either.
Quoted 5 lines
Signed-off-by Bin Meng <[email protected]>---
drivers/sysreset/sysreset_syscon.c| 14 ++++++++++++--1 file changed, 12 insertions(+), 2 deletions(-)Reviewed-by Pragnesh Patel <[email protected]>
Quoted 8 lines
Quoted 2 lines
Would you please take the remaining 3 patches soon?
http://patchwork.ozlabs.org/project/uboot/list/?series=185161May I ask for your opinions about these three SYSRESET patchs. If they are OK to be pick up in my next PR, though they have been rejected in previous riscv PR ?
https://www.mail-archive.com/u-boot at lists.denx.de/msg375465.html
Now the merge window for v2020.10 is open. It's OK to merge this now.
Regards,
Bin