x86/split_lock: Enumerate split lock feature on Sapphire Rapids
PATCH 1/1 x86/split_lock: Enumerate split lock feature on Sapphire Rapids
Add Sapphire Rapids processor to CPU list to enumerate split lock feature.
--- arch/x86/kernel/cpu/intel.c | 1 + 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/intel.c +1 -0
@@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {X86_MATCH_INTEL_FAM6_MODEL (ATOM_TREMONT_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE ,1 ), + X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, 1), {} };
Signature · 1 line
2.19.1
Hi, Thomas, Boris, Ingo,
Quoted 14 lines · Fenghua Yu
Add Sapphire Rapids processor to CPU list to enumerate split lock feature.
Signed-off-by Fenghua Yu <[email protected]>Reviewed-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/intel.c | 1 + 1 file changed, 1 insertion(+)arch/x86/kernel/cpu/intel.c +0
-0
arch/x86/kernel/cpu/intel.c static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = { · line 1153
Quoted 6 lines
arch/x86/kernel/cpu/intel.c +1
-0@@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {X86_MATCH_INTEL_FAM6_MODEL (ATOM_TREMONT_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE ,1 ), + X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, 1), {} };
Any comment on this patch?
Thanks.
-Fenghua
Quoted 12 lines · Fenghua Yu
Hi, Thomas, Boris, Ingo,
Quoted 9 lines · Fenghua Yu
Add Sapphire Rapids processor to CPU list to enumerate split lock feature.
Signed-off-by Fenghua Yu <[email protected]>Reviewed-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/intel.c | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
arch/x86/kernel/cpu/intel.c static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = { · line 1153
Quoted 11 lines
arch/x86/kernel/cpu/intel.c +1
-0@@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {X86_MATCH_INTEL_FAM6_MODEL (ATOM_TREMONT_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE ,1 ), + X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, 1), {} };Any comment on this patch?
The only comment I have is that us needing it is ludicrous :/ What's the bloody point of having it 'enumerated' if you then still have to use FMS lists.
There's nowhere near enough cursing in the comment that goes with that list.
Quoted 27 lines · Peter Zijlstra
Quoted 12 lines · Fenghua Yu
Hi, Thomas, Boris, Ingo,
Quoted 9 lines · Fenghua Yu
Add Sapphire Rapids processor to CPU list to enumerate split lock feature.
Signed-off-by Fenghua Yu <[email protected]>Reviewed-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/intel.c | 1 + 1 file changed, 1 insertion(+)Quoted 13 lines
arch/x86/kernel/cpu/intel.c static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = { · line 1153
Quoted 11 lines
arch/x86/kernel/cpu/intel.c +1
-0@@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {X86_MATCH_INTEL_FAM6_MODEL (ATOM_TREMONT_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE_L ,1 ),X86_MATCH_INTEL_FAM6_MODEL (TIGERLAKE ,1 ), + X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, 1), {} };Any comment on this patch?
Quoted 6 lines
The only comment I have is that us needing it is ludicrous :/ What's the bloody point of having it 'enumerated' if you then still have to use FMS lists.
There's nowhere near enough cursing in the comment that goes with that list.
Code of conduct suggests that we avoid such language :-)
-Tony
Hi, Peter,
Quoted 10 lines · Peter Zijlstra
Quoted 3 lines · Fenghua Yu
Hi, Thomas, Boris, Ingo,
On Fri, Jun 26, 2020 at 02:55:34PM -0700, Fenghua Yu wrote:
The only comment I have is that us needing it is ludicrous :/ What's the bloody point of having it 'enumerated' if you then still have to use FMS lists.
There's nowhere near enough cursing in the comment that goes with that list.
Tony answered Thomas' similar question at
https://lore.kernel.org/lkml/[email protected]/
Is that sufficient enough to answer your question?
Thanks.
-Fenghua