Skip to contentSkip to conversation

Add support for radxa rk3399 and rk3399pro based targets

PATCH New Suniel Mahesh 3 participants 13 messages Jul 4, 2020 – Jul 13, 2020

lore
Share & tools
lore
#0 lore raw

v3 cover Add support for radxa rk3399 and rk3399pro based targets

This patch series adds support for targets based on rk3399 SOC from radxa.

Here are the previous versions of this series[1] [2].

patch #1, adds support for rockpi_n10 base board hosting a RK3399pro SOM. patch #2, adds support for rockpi_4 targets(Model A, B, C) based on rk3399 SOC.

Changes for v3:
- updated readme for rockpi_n10

Changes for v2:
- renamed and updated defconfig from rockpi_4c to rock_pi_4 and board folder from rockpi-4c to rockpi-4, so that this will be valid to board Models A, B, C.
- renamed defconfig from rockpi_n10 to rock_pi_n10
- Changed commit description.
- updated gitlab-ci.yml.
- updated DEVELOPERS.
- updated readme.
- updated extlinux.conf.

[1] http://patchwork.ozlabs.org/project/buildroot/cover/1592369606-14872-1-git-send-email-sunil at amarulasolutions.com/
[2] https://patchwork.ozlabs.org/project/buildroot/cover/1593058045-7013-1-git-send-email-sunil at amarulasolutions.com/

Suniel Mahesh (2):
configs/rock_pi_n10: new defconfig
configs/rock_pi_4: new defconfig

 .gitlab-ci.yml                       |  2 ++
 DEVELOPERS                           |  4 +++
 board/radxa/rockpi-4/extlinux.conf   |  4 +++
 board/radxa/rockpi-4/genimage.cfg    | 39 +++++++++++++++++++++++
 board/radxa/rockpi-4/post-build.sh   |  5 +++
 board/radxa/rockpi-4/readme.txt      | 61 ++++++++++++++++++++++++++++++++++++
 board/radxa/rockpi-n10/extlinux.conf |  4 +++
 board/radxa/rockpi-n10/genimage.cfg  | 39 +++++++++++++++++++++++
 board/radxa/rockpi-n10/post-build.sh |  5 +++
 board/radxa/rockpi-n10/readme.txt    | 61 ++++++++++++++++++++++++++++++++++++
 configs/rock_pi_4_defconfig          | 57 +++++++++++++++++++++++++++++++++
 configs/rock_pi_n10_defconfig        | 57 +++++++++++++++++++++++++++++++++
 12 files changed, 338 insertions(+)
 create mode 100644 board/radxa/rockpi-4/extlinux.conf
 create mode 100644 board/radxa/rockpi-4/genimage.cfg
 create mode 100755 board/radxa/rockpi-4/post-build.sh
 create mode 100644 board/radxa/rockpi-4/readme.txt
 create mode 100644 board/radxa/rockpi-n10/extlinux.conf
 create mode 100644 board/radxa/rockpi-n10/genimage.cfg
 create mode 100755 board/radxa/rockpi-n10/post-build.sh
 create mode 100644 board/radxa/rockpi-n10/readme.txt
 create mode 100644 configs/rock_pi_4_defconfig
 create mode 100644 configs/rock_pi_n10_defconfig
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/2 configs/rock_pi_n10: new defconfig

Add initial support for RK3399PRO SOM based rockpi-n10 target with below features:

- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.7.2
- GPT partition layout is being used
- Default packages from buildroot

---
Changes for v3:
- updated readme for rockpi_n10

Changes for v2:
- renamed defconfig from rockpi_n10 to rock_pi_n10
- updated gitlab-ci.yml
- updated DEVELOPERS
- updated readme
- updated extlinux.conf

---
 .gitlab-ci.yml                       |  1 +
 DEVELOPERS                           |  2 ++
 board/radxa/rockpi-n10/extlinux.conf |  4 +++
 board/radxa/rockpi-n10/genimage.cfg  | 39 +++++++++++++++++++++++
 board/radxa/rockpi-n10/post-build.sh |  5 +++
 board/radxa/rockpi-n10/readme.txt    | 61 ++++++++++++++++++++++++++++++++++++
 configs/rock_pi_n10_defconfig        | 57 +++++++++++++++++++++++++++++++++
 7 files changed, 169 insertions(+)
 create mode 100644 board/radxa/rockpi-n10/extlinux.conf
 create mode 100644 board/radxa/rockpi-n10/genimage.cfg
 create mode 100755 board/radxa/rockpi-n10/post-build.sh
 create mode 100644 board/radxa/rockpi-n10/readme.txt
 create mode 100644 configs/rock_pi_n10_defconfig
.gitlab-ci.yml +1 -0
index 626d1e0..e271770 100644
@@ -323,6 +323,7 @@ riotboard_defconfig: { extends: .defconfig }
 roc_pc_rk3399_defconfig: { extends: .defconfig }
 rock64_defconfig: { extends: .defconfig }
 rockpro64_defconfig: { extends: .defconfig }
+rock_pi_n10_defconfig: { extends: .defconfig }
 roseapplepi_defconfig: { extends: .defconfig }
 s6lx9_microboard_defconfig: { extends: .defconfig }
 sheevaplug_defconfig: { extends: .defconfig }
DEVELOPERS +2 -0
index 742a1f6..05e435d 100644
@@ -2403,11 +2403,13 @@ F:	board/firefly/
 F:	board/friendlyarm/nanopc-t4
 F:	board/friendlyarm/nanopi-m4
 F:	board/orangepi/orangepi-rk3399
+F:	board/radxa/rockpi-n10
 F:	board/pine64/rockpro64
 F: 	configs/nanopc_t4_defconfig
 F: 	configs/nanopi_m4_defconfig
 F:	configs/orangepi_rk3399_defconfig
 F:	configs/roc_pc_rk3399_defconfig
+F:	configs/rock_pi_n10_defconfig
 F:	configs/rockpro64_defconfig
 F:	package/arm-gnu-a-toolchain/
 
board/radxa/rockpi-n10/extlinux.conf new file +4 -0
new file mode 100644
index 0000000..b6a4c97
@@ -0,0 +1,4 @@
+label RK3399_ROCK_PI_N10 linux
+  kernel /Image
+  devicetree /rk3399pro-rock-pi-n10.dtb
+  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk0p4 rw rootwait
board/radxa/rockpi-n10/genimage.cfg new file +39 -0
new file mode 100644
index 0000000..8fbf562
@@ -0,0 +1,39 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"Image",
+			"rk3399pro-rock-pi-n10.dtb",
+			"extlinux"
+		}
+	}
+	size = 112M
+}
+
+image sdcard.img {
+
+	hdimage {
+		gpt = true
+	}
+
+	partition loader1 {
+		image = "idbloader.img"
+		offset = 32K
+	}
+
+	partition loader2 {
+		image = "u-boot.itb"
+		offset = 8M
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+		offset = 16M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
board/radxa/rockpi-n10/post-build.sh new file +5 -0
new file mode 100755
index 0000000..ba29375
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $BINARIES_DIR/extlinux/extlinux.conf
board/radxa/rockpi-n10/readme.txt new file +61 -0

61 lines not on this page · raw message

configs/rock_pi_n10_defconfig new file +57 -0

57 lines not on this page · raw message

Signature · 1 line
2.7.4
#2 lore raw

PATCH v3 1/2 configs/rock_pi_n10: new defconfig

Hello,

Quoted 11 lines · On Sun, 5 Jul 2020 01:46:44 +0530 Suniel Mahesh <[email protected]>…

Add initial support for RK3399PRO SOM based rockpi-n10 target with below features:

- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.7.2
- GPT partition layout is being used
- Default packages from buildroot

I've applied, after doing some minor changes, see below.

Quoted 6 lines
board/radxa/rockpi-n10/genimage.cfg new file +0 -0
new file mode 100644
index 0000000..8fbf562

board/radxa/rockpi-n10/genimage.cfg line 9

Quoted 9 lines
board/radxa/rockpi-n10/genimage.cfg new file +9 -0
@@ -0,0 +1,39 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"Image",
+			"rk3399pro-rock-pi-n10.dtb",
+			"extlinux"
+		}
+	}
+	size = 112M

To be honest, it was not clear why you had this 112MB here. I kept it, but it feels weird. Why 112MB ?

configs/rock_pi_n10_defconfig line 5

Quoted 11 lines
configs/rock_pi_n10_defconfig new file +5 -0
new file mode 100644
index 0000000..96b14bb
@@ -0,0 +1,57 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a72_a53=y
+
+# Linux headers same as kernel, a 5.4 series

You're using a 5.7 kernel :-)

configs/rock_pi_n10_defconfig line 42

Quoted 9 lines
configs/rock_pi_n10_defconfig new file +9 -0
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_7=y
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.7.2"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3399pro-rock-pi-n10"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y

I dropped this line. Indeed, the kernel is loaded by U-Boot from the FAT partition, not from the root filesystem, so it is useless to install it in the rootfs.

Let me know if there was a reason for this.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v3 1/2 configs/rock_pi_n10: new defconfig

Hi Thomas,

Quoted 30 lines · Thomas Petazzoni

Hello,

Quoted 11 lines · On Sun, 5 Jul 2020 01:46:44 +0530 Suniel Mahesh <[email protected]>…

Add initial support for RK3399PRO SOM based rockpi-n10 target with below features:

- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.7.2
- GPT partition layout is being used
- Default packages from buildroot

I've applied, after doing some minor changes, see below.

Review

Quoted 1 line
(quoted diff) +0 -0

b/board/radxa/rockpi-n10/genimage.cfg

Quoted 9 lines

new file mode 100644
index 0000000..8fbf562

board/radxa/rockpi-n10/genimage.cfg new file +4 -0
@@ -0,0 +1,39 @@
+image boot.vfat {
+     vfat {
+             files = {
+                     "Image",
Quoted 9 lines

board/radxa/rockpi-n10/genimage.cfg line 9

Quoted 5 lines
board/radxa/rockpi-n10/genimage.cfg new file +5 -0
+                     "rk3399pro-rock-pi-n10.dtb",
+                     "extlinux"
+             }
+     }
+     size = 112M

To be honest, it was not clear why you had this 112MB here. I kept it, but it feels weird. Why 112MB ?

I am checking with my team, whether they have any specific reason for 112M.
Tested with 64M and the build/target works/boots fine.
I will send changes accordingly with justification.

Quoted 15 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/configs/rock_pi_n10_defconfig

configs/rock_pi_n10_defconfig line 5

Quoted 10 lines

new file mode 100644
index 0000000..96b14bb

configs/rock_pi_n10_defconfig new file +5 -0
@@ -0,0 +1,57 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a72_a53=y
+
+# Linux headers same as kernel, a 5.4 series

You're using a 5.7 kernel :-)

my bad, thanks for the correction.

Quoted 15 lines

configs/rock_pi_n10_defconfig line 42

Quoted 10 lines
configs/rock_pi_n10_defconfig new file +9 -0
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_7=y
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.7.2"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3399pro-rock-pi-n10"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y

I dropped this line. Indeed, the kernel is loaded by U-Boot from the FAT partition, not from the root filesystem, so it is useless to install it in the rootfs.

Quoted 2 lines

Let me know if there was a reason for this.

Yes, the config option looks unnecessary, since the kernel is loaded by U-Boot from the
FAT partition. Thanks for the correction again and the review.

Suniel

Quoted 9 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200713/0f0a4170/attachment.html>

#4 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

In reply to Suniel Mahesh

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:

- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.4.46
- GPT partition layout is being used
- Default packages from buildroot

---
Changes for v3:
- no changes

Changes for v2:
- renamed and updated defconfig from rockpi_4c to rock_pi_4 and board folder from rockpi-4c to rockpi-4, so that this will be valid to board Models A, B, C.
- Changed commit description.
- updated gitlab-ci.yml.
- updated DEVELOPERS.
- updated readme.
- updated extlinux.conf.

---
 .gitlab-ci.yml                     |  1 +
 DEVELOPERS                         |  2 ++
 board/radxa/rockpi-4/extlinux.conf |  4 +++
 board/radxa/rockpi-4/genimage.cfg  | 39 ++++++++++++++++++++++++
 board/radxa/rockpi-4/post-build.sh |  5 ++++
 board/radxa/rockpi-4/readme.txt    | 61 ++++++++++++++++++++++++++++++++++++++
 configs/rock_pi_4_defconfig        | 57 +++++++++++++++++++++++++++++++++++
 7 files changed, 169 insertions(+)
 create mode 100644 board/radxa/rockpi-4/extlinux.conf
 create mode 100644 board/radxa/rockpi-4/genimage.cfg
 create mode 100755 board/radxa/rockpi-4/post-build.sh
 create mode 100644 board/radxa/rockpi-4/readme.txt
 create mode 100644 configs/rock_pi_4_defconfig
.gitlab-ci.yml +1 -0
index e271770..ac4288b 100644
@@ -323,6 +323,7 @@ riotboard_defconfig: { extends: .defconfig }
 roc_pc_rk3399_defconfig: { extends: .defconfig }
 rock64_defconfig: { extends: .defconfig }
 rockpro64_defconfig: { extends: .defconfig }
+rock_pi_4_defconfig: { extends: .defconfig }
 rock_pi_n10_defconfig: { extends: .defconfig }
 roseapplepi_defconfig: { extends: .defconfig }
 s6lx9_microboard_defconfig: { extends: .defconfig }
DEVELOPERS +2 -0
index 05e435d..50fffda 100644
@@ -2403,12 +2403,14 @@ F:	board/firefly/
 F:	board/friendlyarm/nanopc-t4
 F:	board/friendlyarm/nanopi-m4
 F:	board/orangepi/orangepi-rk3399
+F:	board/radxa/rockpi-4
 F:	board/radxa/rockpi-n10
 F:	board/pine64/rockpro64
 F: 	configs/nanopc_t4_defconfig
 F: 	configs/nanopi_m4_defconfig
 F:	configs/orangepi_rk3399_defconfig
 F:	configs/roc_pc_rk3399_defconfig
+F:	configs/rock_pi_4_defconfig
 F:	configs/rock_pi_n10_defconfig
 F:	configs/rockpro64_defconfig
 F:	package/arm-gnu-a-toolchain/
board/radxa/rockpi-4/extlinux.conf new file +4 -0
new file mode 100644
index 0000000..83374f1
@@ -0,0 +1,4 @@
+label RK3399_ROCK_PI_4 linux
+  kernel /Image
+  devicetree /rk3399-rock-pi-4.dtb
+  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk1p4 rw rootwait
board/radxa/rockpi-4/genimage.cfg new file +39 -0
new file mode 100644
index 0000000..88986df
@@ -0,0 +1,39 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"Image",
+			"rk3399-rock-pi-4.dtb",
+			"extlinux"
+		}
+	}
+	size = 112M
+}
+
+image sdcard.img {
+
+	hdimage {
+		gpt = true
+	}
+
+	partition loader1 {
+		image = "idbloader.img"
+		offset = 32K
+	}
+
+	partition loader2 {
+		image = "u-boot.itb"
+		offset = 8M
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+		offset = 16M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
board/radxa/rockpi-4/post-build.sh new file +5 -0
new file mode 100755
index 0000000..ba29375
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $BINARIES_DIR/extlinux/extlinux.conf
board/radxa/rockpi-4/readme.txt new file +61 -0

61 lines not on this page · raw message

configs/rock_pi_4_defconfig new file +57 -0

57 lines not on this page · raw message

Signature · 1 line
2.7.4
#5 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

Hi Suniel,

Quoted 10 lines · Suniel Mahesh

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:

??? - Custom U-Boot 2020.07-rc4
??? ? https://github.com/amarula/u-boot-amarula.git
??? ? branch rock-pi
??? - Linux 5.4.46
??? - GPT partition layout is being used ??? - Default packages from buildroot

Quoted 7 lines

---
Changes for v3:
- no changes

Changes for v2:
- renamed and updated defconfig from rockpi_4c to rock_pi_4 and board

folder

Quoted 1 line

?? from rockpi-4c to rockpi-4, so that this will be valid to board

Models A, B, C.

Quoted 6 lines

- Changed commit description.
- updated gitlab-ci.yml.
- updated DEVELOPERS.
- updated readme.
- updated extlinux.conf.
---

Quoted 6 lines
? .gitlab-ci.yml???????????????????? |? 1 +
? DEVELOPERS???????????????????????? |? 2 ++
? board/radxa/rockpi-4/extlinux.conf |? 4 +++
? board/radxa/rockpi-4/genimage.cfg? | 39 ++++++++++++++++++++++++
? board/radxa/rockpi-4/post-build.sh |? 5 ++++
? board/radxa/rockpi-4/readme.txt??? | 61 

++++++++++++++++++++++++++++++++++++++

Quoted 1 line

? configs/rock_pi_4_defconfig??????? | 57

+++++++++++++++++++++++++++++++++++

Quoted 38 lines

? 7 files changed, 169 insertions(+)
? create mode 100644 board/radxa/rockpi-4/extlinux.conf ? create mode 100644 board/radxa/rockpi-4/genimage.cfg ? create mode 100755 board/radxa/rockpi-4/post-build.sh ? create mode 100644 board/radxa/rockpi-4/readme.txt ? create mode 100644 configs/rock_pi_4_defconfig

.gitlab-ci.yml +1 -0
index e271770..ac4288b 100644
@@ -323,6 +323,7 @@ riotboard_defconfig: { extends: .defconfig }
 ? roc_pc_rk3399_defconfig: { extends: .defconfig }
 ? rock64_defconfig: { extends: .defconfig }
 ? rockpro64_defconfig: { extends: .defconfig }
+rock_pi_4_defconfig: { extends: .defconfig }
 ? rock_pi_n10_defconfig: { extends: .defconfig }
 ? roseapplepi_defconfig: { extends: .defconfig }
 ? s6lx9_microboard_defconfig: { extends: .defconfig }
DEVELOPERS +0 -0
index 05e435d..50fffda 100644
@@ -2403,12 +2403,14 @@ F:??? board/firefly/

? F:??? board/friendlyarm/nanopc-t4
? F:??? board/friendlyarm/nanopi-m4
? F:??? board/orangepi/orangepi-rk3399
+F:??? board/radxa/rockpi-4
? F:??? board/radxa/rockpi-n10
? F:??? board/pine64/rockpro64
? F: ??? configs/nanopc_t4_defconfig
? F: ??? configs/nanopi_m4_defconfig
? F:??? configs/orangepi_rk3399_defconfig
? F:??? configs/roc_pc_rk3399_defconfig
+F:??? configs/rock_pi_4_defconfig
? F:??? configs/rock_pi_n10_defconfig
? F:??? configs/rockpro64_defconfig
? F:??? package/arm-gnu-a-toolchain/

Review

Quoted 1 line
(quoted diff) +0 -0

b/board/radxa/rockpi-4/extlinux.conf

board/radxa/rockpi-4/extlinux.conf line 4

Quoted 9 lines

new file mode 100644
index 0000000..83374f1

board/radxa/rockpi-4/extlinux.conf new file +4 -0
@@ -0,0 +1,4 @@
+label RK3399_ROCK_PI_4 linux
+? kernel /Image
+? devicetree /rk3399-rock-pi-4.dtb
+? append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk1p4 rw 

rootwait

Review

Quoted 1 line
(quoted diff) +0 -0

b/board/radxa/rockpi-4/genimage.cfg

Quoted 21 lines

new file mode 100644
index 0000000..88986df

board/radxa/rockpi-4/genimage.cfg new file +16 -0
@@ -0,0 +1,39 @@
+image boot.vfat {
+??? vfat {
+??? ??? files = {
+??? ??? ??? "Image",
+??? ??? ??? "rk3399-rock-pi-4.dtb",
+??? ??? ??? "extlinux"
+??? ??? }
+??? }
+??? size = 112M
+}
+
+image sdcard.img {
+
+??? hdimage {
+??? ??? gpt = true
+??? }

board/radxa/rockpi-4/genimage.cfg line 26

Quoted 10 lines
board/radxa/rockpi-4/genimage.cfg new file +10 -0
+
+??? partition loader1 {
+??? ??? image = "idbloader.img"
+??? ??? offset = 32K
+??? }
+
+??? partition loader2 {
+??? ??? image = "u-boot.itb"
+??? ??? offset = 8M
+??? }

I think using u-boot-rockchip.bin is simpler.
??????? partition u-boot {
??????????????? offset = "32K"
??????????????? image = "u-boot-rockchip.bin"
??????????????? in-partition-table = false
??????? }

Review

Quoted 14 lines
board/radxa/rockpi-4/genimage.cfg new file +13 -0
+
+??? partition boot {
+??? ??? partition-type = 0xC
+??? ??? bootable = "true"
+??? ??? image = "boot.vfat"
+??? ??? offset = 16M
+??? }
+
+??? partition rootfs {
+??? ??? partition-type = 0x83
+??? ??? image = "rootfs.ext4"
+??? }
+}
(quoted diff) +0 -0

b/board/radxa/rockpi-4/post-build.sh

board/radxa/rockpi-4/post-build.sh line 5

Quoted 10 lines

new file mode 100755
index 0000000..ba29375

board/radxa/rockpi-4/post-build.sh new file +5 -0
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf 

$BINARIES_DIR/extlinux/extlinux.conf

Review

Quoted 1 line
(quoted diff) +0 -0

b/board/radxa/rockpi-4/readme.txt

board/radxa/rockpi-4/readme.txt line 5

Quoted 10 lines

new file mode 100644
index 0000000..1db7569

board/radxa/rockpi-4/readme.txt new file +5 -0
@@ -0,0 +1,61 @@
+RADXA ROCK_PI_4
+================
+https://rockpi.org/rockpi4
+
+ROCK Pi 4 is a Single Board Computer (SBC) from radxa. This guide is 

valid

Quoted 63 lines
board/radxa/rockpi-4/readme.txt new file +56 -0
+for the below models:
+- ROCK PI 4 Model A
+- ROCK PI 4 Model B
+- ROCK PI 4 Model C
+
+Build:
+======
+? $ make rock_pi_4_defconfig
+? $ make
+
+Files created in output directory
+=================================
+
+output/images
+
+??? bl31.elf
+??? boot.vfat
+??? extlinux
+??? idbloader.img
+??? Image
+??? rk3399-rock-pi-4.dtb
+??? rootfs.ext2
+??? rootfs.ext4 -> rootfs.ext2
+??? rootfs.tar
+??? sdcard.img
+??? u-boot.bin
+??? u-boot.itb
+
+Creating bootable SD card:
+==========================
+
+Simply invoke (as root)
+
+sudo dd if=output/images/sdcard.img of=/dev/sdX && sync
+
+Where X is your SD card device.
+
+Booting:
+========
+
+Serial console:
+---------------
+RockPi4 has a 40-pin GPIO header. The pin layout is as follows:
+
+pin 6:? gnd
+pin 8:? tx
+pin 10: rx
+
+Baudrate for this board is 1500000.
+
+Login:
+------
+Enter 'root' as login user, and the prompt is ready.
+
+Wiki link:
+https://wiki.amarulasolutions.com/bsp/rockchip/rk3399/rock-pi-4.html
configs/rock_pi_4_defconfig new file +0 -0
new file mode 100644
index 0000000..2c1737a

configs/rock_pi_4_defconfig line 10

Quoted 10 lines
configs/rock_pi_4_defconfig new file +10 -0
@@ -0,0 +1,57 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a72_a53=y
+
+# Linux headers same as kernel, a 5.4 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y
+
+# Firmware
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y

+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git"

The default URL should be fine.

Quoted 1 line

+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="11a0a46a899fcc3b1fdb214b382f3d7495d88eca"

configs/rock_pi_4_defconfig line 21

Quoted 10 lines
configs/rock_pi_4_defconfig new file +9 -0
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3399"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES=""
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y

+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/amarula/u-boot-amarula.git"

Quoted 1 line

+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="cf2747360fdd1eb0d51dd01a984c7c62c7f714fe"

I recommend using the mainline U-Boot.

configs/rock_pi_4_defconfig line 33

Quoted 10 lines
configs/rock_pi_4_defconfig new file +10 -0
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="rock-pi-4-rk3399"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYTHON=y
+BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"

I think using u-boot-rockchip.bin is simpler.
BR2_TARGET_UBOOT_SPL_NAME="u-boot-rockchip.bin"

Quoted 25 lines
configs/rock_pi_4_defconfig new file +24 -0
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.4.46"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3399-rock-pi-4"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+# Filesystem
+BR2_TARGET_GENERIC_HOSTNAME="rockpi4"
+BR2_TARGET_GENERIC_ISSUE="Welcome to ROCK_PI_4..!!"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="96M"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/radxa/rockpi-4/genimage.cfg"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/radxa/rockpi-4/post-build.sh"
Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Regards,
Yuanhao

#6 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

Quoted 123 lines · Tian Yuanhao

Hi Suniel,

Quoted 10 lines · Suniel Mahesh

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:

- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.4.46
- GPT partition layout is being used
- Default packages from buildroot

Quoted 7 lines

---
Changes for v3:
- no changes

Changes for v2:
- renamed and updated defconfig from rockpi_4c to rock_pi_4 and board

folder

Quoted 1 line

from rockpi-4c to rockpi-4, so that this will be valid to board

Models A, B, C.

Quoted 5 lines

- Changed commit description.
- updated gitlab-ci.yml.
- updated DEVELOPERS.
- updated readme.
- updated extlinux.conf.

Quoted 7 lines
---
 .gitlab-ci.yml                     |  1 +
 DEVELOPERS                         |  2 ++
 board/radxa/rockpi-4/extlinux.conf |  4 +++
 board/radxa/rockpi-4/genimage.cfg  | 39 ++++++++++++++++++++++++
 board/radxa/rockpi-4/post-build.sh |  5 ++++
 board/radxa/rockpi-4/readme.txt    | 61

++++++++++++++++++++++++++++++++++++++

Quoted 1 line
 configs/rock_pi_4_defconfig        | 57

+++++++++++++++++++++++++++++++++++

Review

Quoted 39 lines
 7 files changed, 169 insertions(+)
 create mode 100644 board/radxa/rockpi-4/extlinux.conf
 create mode 100644 board/radxa/rockpi-4/genimage.cfg
 create mode 100755 board/radxa/rockpi-4/post-build.sh
 create mode 100644 board/radxa/rockpi-4/readme.txt
 create mode 100644 configs/rock_pi_4_defconfig
.gitlab-ci.yml +1 -0
index e271770..ac4288b 100644
@@ -323,6 +323,7 @@ riotboard_defconfig: { extends: .defconfig }
 roc_pc_rk3399_defconfig: { extends: .defconfig }
 rock64_defconfig: { extends: .defconfig }
 rockpro64_defconfig: { extends: .defconfig }
+rock_pi_4_defconfig: { extends: .defconfig }
 rock_pi_n10_defconfig: { extends: .defconfig }
 roseapplepi_defconfig: { extends: .defconfig }
 s6lx9_microboard_defconfig: { extends: .defconfig }
DEVELOPERS +2 -0
index 05e435d..50fffda 100644
@@ -2403,12 +2403,14 @@ F:    board/firefly/
 F:    board/friendlyarm/nanopc-t4
 F:    board/friendlyarm/nanopi-m4
 F:    board/orangepi/orangepi-rk3399
+F:    board/radxa/rockpi-4
 F:    board/radxa/rockpi-n10
 F:    board/pine64/rockpro64
 F:     configs/nanopc_t4_defconfig
 F:     configs/nanopi_m4_defconfig
 F:    configs/orangepi_rk3399_defconfig
 F:    configs/roc_pc_rk3399_defconfig
+F:    configs/rock_pi_4_defconfig
 F:    configs/rock_pi_n10_defconfig
 F:    configs/rockpro64_defconfig
 F:    package/arm-gnu-a-toolchain/
(quoted diff) +0 -0

b/board/radxa/rockpi-4/extlinux.conf

board/radxa/rockpi-4/extlinux.conf line 4

Quoted 9 lines

new file mode 100644
index 0000000..83374f1

board/radxa/rockpi-4/extlinux.conf new file +4 -0
@@ -0,0 +1,4 @@
+label RK3399_ROCK_PI_4 linux
+  kernel /Image
+  devicetree /rk3399-rock-pi-4.dtb
+  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk1p4 rw

rootwait

Review

Quoted 1 line
(quoted diff) +0 -0

b/board/radxa/rockpi-4/genimage.cfg

Quoted 21 lines

new file mode 100644
index 0000000..88986df

board/radxa/rockpi-4/genimage.cfg new file +16 -0
@@ -0,0 +1,39 @@
+image boot.vfat {
+    vfat {
+        files = {
+            "Image",
+            "rk3399-rock-pi-4.dtb",
+            "extlinux"
+        }
+    }
+    size = 112M
+}
+
+image sdcard.img {
+
+    hdimage {
+        gpt = true
+    }

board/radxa/rockpi-4/genimage.cfg line 26

Quoted 10 lines
board/radxa/rockpi-4/genimage.cfg new file +10 -0
+
+    partition loader1 {
+        image = "idbloader.img"
+        offset = 32K
+    }
+
+    partition loader2 {
+        image = "u-boot.itb"
+        offset = 8M
+    }

I think using u-boot-rockchip.bin is simpler.

Quoted 6 lines
         partition u-boot {
                 offset = "32K"
                 image = "u-boot-rockchip.bin"
                 in-partition-table = false
         }

Hi Tian,
Rockchip uses unified GPT as its main partition table. We are just following that.
doc/README.rockchip (GPT partition layout)
http://rockchip.wikidot.com/partitions

Quoted 134 lines

Review

Quoted 14 lines
board/radxa/rockpi-4/genimage.cfg new file +13 -0
+
+    partition boot {
+        partition-type = 0xC
+        bootable = "true"
+        image = "boot.vfat"
+        offset = 16M
+    }
+
+    partition rootfs {
+        partition-type = 0x83
+        image = "rootfs.ext4"
+    }
+}
(quoted diff) +0 -0

b/board/radxa/rockpi-4/post-build.sh

board/radxa/rockpi-4/post-build.sh line 5

Quoted 10 lines

new file mode 100755
index 0000000..ba29375

board/radxa/rockpi-4/post-build.sh new file +5 -0
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf

$BINARIES_DIR/extlinux/extlinux.conf

Review

Quoted 1 line
(quoted diff) +0 -0

b/board/radxa/rockpi-4/readme.txt

board/radxa/rockpi-4/readme.txt line 5

Quoted 10 lines

new file mode 100644
index 0000000..1db7569

board/radxa/rockpi-4/readme.txt new file +5 -0
@@ -0,0 +1,61 @@
+RADXA ROCK_PI_4
+================
+https://rockpi.org/rockpi4
+
+ROCK Pi 4 is a Single Board Computer (SBC) from radxa. This guide is

valid

Quoted 63 lines
board/radxa/rockpi-4/readme.txt new file +56 -0
+for the below models:
+- ROCK PI 4 Model A
+- ROCK PI 4 Model B
+- ROCK PI 4 Model C
+
+Build:
+======
+  $ make rock_pi_4_defconfig
+  $ make
+
+Files created in output directory
+=================================
+
+output/images
+
+??? bl31.elf
+??? boot.vfat
+??? extlinux
+??? idbloader.img
+??? Image
+??? rk3399-rock-pi-4.dtb
+??? rootfs.ext2
+??? rootfs.ext4 -> rootfs.ext2
+??? rootfs.tar
+??? sdcard.img
+??? u-boot.bin
+??? u-boot.itb
+
+Creating bootable SD card:
+==========================
+
+Simply invoke (as root)
+
+sudo dd if=output/images/sdcard.img of=/dev/sdX && sync
+
+Where X is your SD card device.
+
+Booting:
+========
+
+Serial console:
+---------------
+RockPi4 has a 40-pin GPIO header. The pin layout is as follows:
+
+pin 6:  gnd
+pin 8:  tx
+pin 10: rx
+
+Baudrate for this board is 1500000.
+
+Login:
+------
+Enter 'root' as login user, and the prompt is ready.
+
+Wiki link:
+https://wiki.amarulasolutions.com/bsp/rockchip/rk3399/rock-pi-4.html
configs/rock_pi_4_defconfig new file +0 -0
new file mode 100644
index 0000000..2c1737a

configs/rock_pi_4_defconfig line 10

Quoted 10 lines
configs/rock_pi_4_defconfig new file +10 -0
@@ -0,0 +1,57 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a72_a53=y
+
+# Linux headers same as kernel, a 5.4 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y
+
+# Firmware
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y

+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="
https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git"

The default URL should be fine.

Quoted 1 line
(quoted diff) +2 -0
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="11a0a46a899fcc3b1fdb214b382f3d7495d88eca"
 > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3399"
 > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
 > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
 > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES=""
 > +
 > +# Bootloader
 > +BR2_TARGET_UBOOT=y
 > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 > +BR2_TARGET_UBOOT_CUSTOM_GIT=y
 >
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="

https://github.com/amarula/u-boot-amarula.git"

Quoted 1 line
Quoted 4 lines

+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="cf2747360fdd1eb0d51dd01a984c7c62c7f714fe"

I recommend using the mainline U-Boot.

Yes Tian agreed, the patches for this target have been mainlined and waiting to be merged. Once that
is done we will use mainline u-boot.

Thanks & Regards
Suniel

Quoted 40 lines

configs/rock_pi_4_defconfig line 33

Quoted 11 lines
configs/rock_pi_4_defconfig new file +10 -0
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="rock-pi-4-rk3399"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYTHON=y
+BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"

I think using u-boot-rockchip.bin is simpler.
BR2_TARGET_UBOOT_SPL_NAME="u-boot-rockchip.bin"

Quoted 25 lines
configs/rock_pi_4_defconfig new file +24 -0
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.4.46"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3399-rock-pi-4"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+# Filesystem
+BR2_TARGET_GENERIC_HOSTNAME="rockpi4"
+BR2_TARGET_GENERIC_ISSUE="Welcome to ROCK_PI_4..!!"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="96M"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/radxa/rockpi-4/genimage.cfg"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/radxa/rockpi-4/post-build.sh"
Quoted 8 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Regards,
Yuanhao

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200706/338f974e/attachment.html>

#7 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

I deleted some content for easy reading.

Quoted 25 lines
Quoted 19 lines

Hi Suniel,

Quoted 10 lines

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:
??? - Custom U-Boot 2020.07-rc4
????? https://github.com/amarula/u-boot-amarula.git
????? branch rock-pi
??? - Linux 5.4.46
??? - GPT partition layout is being used
??? - Default packages from buildroot
...
+??? partition loader1 {

Quoted 8 lines

+??????? image = "idbloader.img"
+??????? offset = 32K
+??? }
+
+??? partition loader2 {
+??????? image = "u-boot.itb"
+??????? offset = 8M
+??? }

Quoted 6 lines

I think using u-boot-rockchip.bin is simpler.
??? partition u-boot {
??????? offset = "32K"
??????? image = "u-boot-rockchip.bin"
??????? in-partition-table = false
??? }

Quoted 5 lines

Hi Tian,
Rockchip uses unified GPT as its main partition table. We are just following that.
doc/README.rockchip (GPT partition layout)
http://rockchip.wikidot.com/partitions

See https://patchwork.kernel.org/patch/11326313/
u-boot-rockchip.bin consists of idbloader.img and u-boot.itb, and contains a gap of 8355840 bytes.
The result is the same as yours, and more simple.

Regards,
Yuanhao

#8 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

Quoted 31 lines · Tian Yuanhao

I deleted some content for easy reading.

Quoted 25 lines
Quoted 19 lines

Hi Suniel,

Quoted 9 lines

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:
- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.4.46
- GPT partition layout is being used
- Default packages from buildroot
...

board/radxa/rockpi-4/genimage.cfg line 26

Quoted 9 lines
board/radxa/rockpi-4/genimage.cfg new file +9 -0
+    partition loader1 {
+        image = "idbloader.img"
+        offset = 32K
+    }
+
+    partition loader2 {
+        image = "u-boot.itb"
+        offset = 8M
+    }
Quoted 6 lines

I think using u-boot-rockchip.bin is simpler.

    partition u-boot {
        offset = "32K"
        image = "u-boot-rockchip.bin"
        in-partition-table = false
    }
Quoted 5 lines

Hi Tian,
Rockchip uses unified GPT as its main partition table. We are just following that.
doc/README.rockchip (GPT partition layout)
http://rockchip.wikidot.com/partitions

Quoted 5 lines

See https://patchwork.kernel.org/patch/11326313/
u-boot-rockchip.bin consists of idbloader.img and u-boot.itb, and contains a gap of 8355840 bytes.
The result is the same as yours, and more simple.

Hi again Yuanhao,

If any user wants to flash images via fastboot, then will it be possible if we use the idea of u-boot-rockchip.bin ?

Suniel

Quoted 4 lines

Regards,
Yuanhao

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200706/df554d6a/attachment.html>

#9 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

Quoted 31 lines
Quoted 31 lines

I deleted some content for easy reading.

Quoted 30 lines
Quoted 19 lines

Hi Suniel,

Quoted 10 lines

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:
??? - Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
????? branch rock-pi
??? - Linux 5.4.46
??? - GPT partition layout is being used
??? - Default packages from buildroot
...
+??? partition loader1 {

Quoted 8 lines

+??????? image = "idbloader.img"
+??????? offset = 32K
+??? }
+
+??? partition loader2 {
+??????? image = "u-boot.itb"
+??????? offset = 8M
+??? }

Quoted 6 lines

I think using u-boot-rockchip.bin is simpler.
??? partition u-boot {
??????? offset = "32K"
??????? image = "u-boot-rockchip.bin"
??????? in-partition-table = false
??? }

Hi Tian,
Rockchip uses unified GPT as its main partition table. We are just following that.
doc/README.rockchip (GPT partition layout)
http://rockchip.wikidot.com/partitions

Quoted 8 lines
Quoted 4 lines

See https://patchwork.kernel.org/patch/11326313/
u-boot-rockchip.bin consists of idbloader.img and u-boot.itb, and contains a gap of 8355840 bytes.
The result is the same as yours, and more simple.

Hi again Yuanhao,
If any user wants to flash images via fastboot, then will it be possible if we use the idea of u-boot-rockchip.bin ? Suniel

I think that's okay, but I have never done it. You better ask Jagan too.

Regards,
Yuanhao
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200706/4074b63a/attachment.html>

#10 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

Quoted 41 lines · Tian Yuanhao

I deleted some content for easy reading.

Hi Suniel,

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:
- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.4.46
- GPT partition layout is being used
- Default packages from buildroot
...

board/radxa/rockpi-4/genimage.cfg new file +9 -0
+    partition loader1 {
+        image = "idbloader.img"
+        offset = 32K
+    }
+
+    partition loader2 {
+        image = "u-boot.itb"
+        offset = 8M
+    }

I think using u-boot-rockchip.bin is simpler.

    partition u-boot {
        offset = "32K"
        image = "u-boot-rockchip.bin"
        in-partition-table = false
    }

Hi Tian,
Rockchip uses unified GPT as its main partition table. We are just following that.
doc/README.rockchip (GPT partition layout)
http://rockchip.wikidot.com/partitions

See https://patchwork.kernel.org/patch/11326313/
u-boot-rockchip.bin consists of idbloader.img and u-boot.itb, and contains a gap of 8355840 bytes.
The result is the same as yours, and more simple.

Quoted 7 lines

Hi again Yuanhao,
If any user wants to flash images via fastboot, then will it be possible if we use the idea of u-boot-rockchip.bin ?
Suniel

I think that's okay, but I have never done it. You better ask Jagan too.

Yes, I will check with jagan. Thanks Yuanhao.

Suniel

Quoted 4 lines

Regards,
Yuanhao

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200706/d46bbcae/attachment.html>

#11 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

In reply to Suniel Mahesh
Quoted 10 lines · On Sun, 5 Jul 2020 01:46:45 +0530 Suniel Mahesh <[email protected]>…

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:

- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.4.46
- GPT partition layout is being used
- Default packages from buildroot

Quoted 4 lines

---
Changes for v3:
- no changes

Applied to master with similar changes than the n10 defconfig.

Regarding the use of u-boot-rockchip.bin, I think I very much prefer that there is one partition for each bootloader stage. Having this huge image u-boot-rockchip.bin, with a huge gap in the middle feels odd, so I tend to prefer the solution implemented by your patch as it is.

Of course, please send some updates when the ATF support and U-Boot support is fully merged, so that we can use mainline and tagged releases.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#12 lore raw

PATCH v3 2/2 configs/rock_pi_4: new defconfig

Hi Thomas,

Quoted 20 lines · Thomas Petazzoni
Quoted 10 lines · On Sun, 5 Jul 2020 01:46:45 +0530 Suniel Mahesh <[email protected]>…

Add initial support for RK3399 based rockpi-4 targets (model A, B, C) with below features:

- Custom U-Boot 2020.07-rc4
https://github.com/amarula/u-boot-amarula.git
branch rock-pi
- Linux 5.4.46
- GPT partition layout is being used
- Default packages from buildroot

Quoted 4 lines

---
Changes for v3:
- no changes

Applied to master with similar changes than the n10 defconfig.

Quoted 8 lines

Regarding the use of u-boot-rockchip.bin, I think I very much prefer that there is one partition for each bootloader stage. Having this huge image u-boot-rockchip.bin, with a huge gap in the middle feels odd, so I tend to prefer the solution implemented by your patch as it is.

Of course, please send some updates when the ATF support and U-Boot support is fully merged, so that we can use mainline and tagged releases.

I will update the target to use mainline u-boot and others once the support is fully
merged and send patches accordingly. Thanks for the review.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200713/49e2a9ee/attachment.html>