arm: cmd_stm32prog: Fix the CONFIG_IS_ENABLED() usage
Subsystems (3)
PATCH 1/1 arm: cmd_stm32prog: Fix the CONFIG_IS_ENABLED() usage
Add parentheses around CONFIG_IS_ENABLED() in the if statement, to fix potential build failures.
---
Fixes the issue as seen with Azure:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=251&view=logs&j=06447dc8-3759-5480-c2ba-b1f5a74bd12e&t=3906ed62-68d1-5fd5-bbe4-e8a557f9b32f
arch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c +1 -1
@@ -147,7 +147,7 @@ static int do_stm32prog(struct cmd_tbl *cmdtp, int flag, int argc,/* Try bootm for legacy and FIT format image */ if (genimg_get_format ((void *)uimage) !=IMAGE_FORMAT_INVALID )do_bootm (cmdtp,0 ,4 , bootm_argv); - else if CONFIG_IS_ENABLED(CMD_BOOTZ) +else if (CONFIG_IS_ENABLED (CMD_BOOTZ ))do_bootz (cmdtp,0 ,4 , bootm_argv); }
Signature · 1 line
2.7.4
PATCH 1/1 arm: cmd_stm32prog: Fix the CONFIG_IS_ENABLED() usage
Hi Bin,
Quoted 32 lines
From: Bin Meng <[email protected]>
Sent: mercredi 8 juillet 2020 09:19Add parentheses around
CONFIG_IS_ENABLED()in the if statement, to fix potential build failures.Signed-off-by Bin Meng <[email protected]>---
Fixes the issue as seen with Azure:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=251&view=logs&j=064
47dc8-3759-5480-c2ba-b1f5a74bd12e&t=3906ed62-68d1-5fd5-bbe4-e8a557f9b32farch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c +1
-1@@ -147,7 +147,7 @@ static int do_stm32prog(struct cmd_tbl *cmdtp, int flag, int argc, /* Try bootm for legacy and FIT format image */ if (genimg_get_format((void *)uimage) != IMAGE_FORMAT_INVALID) do_bootm(cmdtp, 0, 4, bootm_argv); - else if CONFIG_IS_ENABLED(CMD_BOOTZ) + else if (CONFIG_IS_ENABLED(CMD_BOOTZ)) do_bootz(cmdtp, 0, 4, bootm_argv);}
Quoted 2 lines
--
2.7.4
Thanks
Patrick
PATCH 1/1 arm: cmd_stm32prog: Fix the CONFIG_IS_ENABLED() usage
Quoted 35 lines · Patrick DELAUNAY
Hi Bin,
Quoted 32 lines
From: Bin Meng <[email protected]>
Sent: mercredi 8 juillet 2020 09:19Add parentheses around
CONFIG_IS_ENABLED()in the if statement, to fix potential build failures.Signed-off-by Bin Meng <[email protected]>---
Fixes the issue as seen with Azure:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=251&view=logs&j=064
47dc8-3759-5480-c2ba-b1f5a74bd12e&t=3906ed62-68d1-5fd5-bbe4-e8a557f9b32farch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c +1
-1@@ -147,7 +147,7 @@ static int do_stm32prog(struct cmd_tbl *cmdtp, int flag, int argc, /* Try bootm for legacy and FIT format image */ if (genimg_get_format((void *)uimage) != IMAGE_FORMAT_INVALID) do_bootm(cmdtp, 0, 4, bootm_argv); - else if CONFIG_IS_ENABLED(CMD_BOOTZ) + else if (CONFIG_IS_ENABLED(CMD_BOOTZ)) do_bootz(cmdtp, 0, 4, bootm_argv);}
Quoted 5 lines
Quoted 2 lines
--
2.7.4Reviewed-by Patrick Delaunay <[email protected]>
applied to u-boot-x86, thanks!