mmc: meson-gx: limit segments to 1 when dram-access-quirk is needed
Subsystems (2)
PATCH 1/1 mmc: meson-gx: limit segments to 1 when dram-access-quirk is needed
The actual max_segs computation leads to failure while using the broadcom sdio brcmfmac/bcmsdh driver, since the driver tries to make usage of scatter gather.
But with the dram-access-quirk we use a 1,5K SRAM bounce buffer, and the max_segs current value of 3 leads to max transfers to 4,5k, which doesn't work.
This patch sets max_segs to 1 to better describe the hardware limitation, and fix the SDIO functionnality with the brcmfmac/bcmsdh driver on Amlogic G12A/G12B SoCs on boards like SEI510 or Khadas VIM3.
--- drivers/mmc/host/meson-gx-mmc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/mmc/host/meson-gx-mmc.c +4 -2
@@ -1143,9 +1143,11 @@ static int meson_mmc_probe(struct platform_device *pdev) mmc->caps |=MMC_CAP_CMD23 ;if (host->dram_access_quirk) { +/* Limit segments to 1 due to low available sram memory */ + mmc->max_segs =1 ;/* Limit to the available sram memory */ - mmc->max_segs =SD_EMMC_SRAM_DATA_BUF_LEN / mmc->max_blk_size; - mmc->max_blk_count = mmc->max_segs; + mmc->max_blk_count =SD_EMMC_SRAM_DATA_BUF_LEN / + mmc->max_blk_size; }else { mmc->max_blk_count =CMD_CFG_LENGTH_MASK ; mmc->max_segs = SD_EMMC_DESC_BUF_LEN /
Signature · 1 line
2.22.0
Quoted 7 lines · Neil Armstrong
The actual
max_segscomputation leads to failure while using the broadcom sdio brcmfmac/bcmsdh driver, since the driver tries to make usage of scatter gather.But with the dram-access-quirk we use a 1,5K SRAM bounce buffer, and the
max_segscurrent value of 3 leads to max transfers to 4,5k, which doesn't work.
Quoted 8 lines
This patch sets
max_segsto 1 to better describe the hardware limitation, and fix the SDIO functionnality with the brcmfmac/bcmsdh driver on Amlogic G12A/G12B SoCs on boards like SEI510 or Khadas VIM3.Reported-by Art Nikpal <[email protected]>Reported-by Christian Hewitt <[email protected]>Fixes acdc8e71d9bb ("mmc: meson-gx: add dram-access-quirk")Signed-off-by Neil Armstrong <[email protected]>
Quoted 8 lines · Neil Armstrong
The actual
max_segscomputation leads to failure while using the broadcom sdio brcmfmac/bcmsdh driver, since the driver tries to make usage of scatter gather.But with the dram-access-quirk we use a 1,5K SRAM bounce buffer, and the
max_segscurrent value of 3 leads to max transfers to 4,5k, which doesn't work.
Quoted 8 lines
This patch sets
max_segsto 1 to better describe the hardware limitation, and fix the SDIO functionnality with the brcmfmac/bcmsdh driver on Amlogic G12A/G12B SoCs on boards like SEI510 or Khadas VIM3.Reported-by Art Nikpal <[email protected]>Reported-by Christian Hewitt <[email protected]>Fixes acdc8e71d9bb ("mmc: meson-gx: add dram-access-quirk")Signed-off-by Neil Armstrong <[email protected]>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
Quoted 25 lines
--- drivers/mmc/host/meson-gx-mmc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/mmc/host/meson-gx-mmc.c +4
-3@@ -1143,9 +1143,11 @@ static int meson_mmc_probe(struct platform_device *pdev) mmc->caps |=MMC_CAP_CMD23 ;if (host->dram_access_quirk) { +/* Limit segments to 1 due to low available sram memory */ + mmc->max_segs =1 ;/* Limit to the available sram memory */ - mmc->max_segs =SD_EMMC_SRAM_DATA_BUF_LEN / mmc->max_blk_size; - mmc->max_blk_count = mmc->max_segs; + mmc->max_blk_count =SD_EMMC_SRAM_DATA_BUF_LEN / + mmc->max_blk_size; }else { mmc->max_blk_count =CMD_CFG_LENGTH_MASK ; mmc->max_segs = SD_EMMC_DESC_BUF_LEN / --2.22.0
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).
Hello:
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).
Quoted 8 lines · On Mon, 8 Jun 2020 10:44:58 +0200 you wrote:
The actual
max_segscomputation leads to failure while using the broadcom sdio brcmfmac/bcmsdh driver, since the driver tries to make usage of scatter gather.But with the dram-access-quirk we use a 1,5K SRAM bounce buffer, and the
max_segscurrent value of 3 leads to max transfers to 4,5k, which doesn't work.[...]
Here is a summary with links:
- mmc: meson-gx: limit segments to 1 when dram-access-quirk is needed
https://git.kernel.org/khilman/linux-amlogic/c/27a5e7d36d383970affae801d77141deafd536a8
You are awesome, thank you!
Signature · 7 lines
Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/pwbot _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic