dts: add specific compatible type for Terasic DE0-NANO-SoC Board

PATCH Superseded Tim Sander 3 participants 7 messages Feb 12, 2016 – Feb 25, 2016 Device tree bindings

lore

Share & tools

lore

Tim Sander

author

2016-02-12 13:35 UTC #0 lore raw

PATCH 1/1 dts: add specific compatible type for Terasic DE0-NANO-SoC Board

From: Tim Sander <[email protected]>

Add a more specific compatible string:"terasic,de0-nano-soc" for respective board.
Background: when checking for bootspec entries, some board specific fixups
are not apropriate for board of the same platform ("altr,socfpga-cyclone5").
The same aproach is taken with the EBV-Socrates board.

Signed-off-by Tim Sander <[email protected]>

---
 arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +1 -1

index 555e9caf21e1..3a427423168e 100644
@@ -18,7 +18,7 @@
 
 / {
        model = "Terasic DE-0(Atlas)";
-       compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+       compatible = "terasic,de0-nano-soc"," altr,socfpga-cyclone5", "altr,socfpga";
 
        chosen {
                bootargs = "earlyprintk";

Signature · 1 line

1.9.1

Dinh Nguyen

2016-02-24 16:50 UTC #1 lore raw

Hi Tim,

Quoted 7 lines · Tim Sander

From: Tim Sander <[email protected]>
Add a more specific compatible string:"terasic,de0-nano-soc" for respective board.
Background: when checking for bootspec entries, some board specific fixups
are not apropriate for board of the same platform ("altr,socfpga-cyclone5").
The same aproach is taken with the EBV-Socrates board.

Please fix up the spacing in the commit message.

Quoted 10 lines

Signed-off-by Tim Sander <[email protected]>
---
 arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +0 -0
index 555e9caf21e1..3a427423168e 100644

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts line 22

Quoted 6 lines

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +1 -1

@@ -18,7 +18,7 @@
 
 / {
        model = "Terasic DE-0(Atlas)";
-       compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+       compatible = "terasic,de0-nano-soc"," altr,socfpga-cyclone5", "altr,socfpga";

"terasic" is not listed in Documentation/devicetree/bindings/vendor-prefixes.txt.

BR,
Dinh

Tim Sander

author

2016-02-25 10:05 UTC #2 lore raw

PATCH v2 1/1 dts: add specific compatible type for Terasic DE0-NANO-SoC Board

From: Tim Sander <[email protected]>

Add a more specific compatible string:"terasic,de0-nano-soc" for respective board.
Background: when checking for bootspec entries, some board specific fixups are not apropriate for board of the same platform ("altr,socfpga-cyclone5"). The same aproach is taken with the EBV-Socrates board.

Signed-off-by Tim Sander <[email protected]>

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts     | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0

index 72e2c5a..d1f7803 100644
@@ -230,6 +230,7 @@ synology	Synology, Inc.
 tbs	TBS Technologies
 tcl	Toby Churchill Ltd.
 technologic	Technologic Systems
+terasic	Terasic Inc.
 thine	THine Electronics, Inc.
 ti	Texas Instruments
 tlm	Trusted Logic Mobility

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +1 -1

index afea364..704aa9d 100644
@@ -18,7 +18,7 @@
 
 / {
 	model = "Terasic DE-0(Atlas)";
-	compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+	compatible = "terasic,de0-nano-soc","altr,socfpga-cyclone5", "altr,socfpga";
 
 	chosen {
 		bootargs = "earlyprintk";

Signature · 1 line

1.9.1

Steffen Trumtrar

2016-02-25 10:38 UTC #3 lore raw

Hi Tim!

Quoted 18 lines · Tim Sander

From: Tim Sander <[email protected]>
Add a more specific compatible string:"terasic,de0-nano-soc" for respective board.
Background: when checking for bootspec entries, some board specific fixups are not apropriate for board of the same platform ("altr,socfpga-cyclone5"). The same aproach is taken with the EBV-Socrates board.
Signed-off-by Tim Sander <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts     | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/vendor-prefixes.txt +0 -0
index 72e2c5a..d1f7803 100644

Documentation/devicetree/bindings/vendor-prefixes.txt synology Synology, Inc. · line 236

Quoted 7 lines

Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0

@@ -230,6 +230,7 @@ synology	Synology, Inc.
 tbs	TBS Technologies
 tcl	Toby Churchill Ltd.
 technologic	Technologic Systems
+terasic	Terasic Inc.
 thine	THine Electronics, Inc.
 ti	Texas Instruments
 tlm	Trusted Logic Mobility

You should IMHO split this up in two patches.
First patch: add terasic

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts line 21

Quoted 10 lines

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +1 -1

index afea364..704aa9d 100644
@@ -18,7 +18,7 @@
 
 / {
 	model = "Terasic DE-0(Atlas)";
-	compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+	compatible = "terasic,de0-nano-soc","altr,socfpga-cyclone5", "altr,socfpga";

Second patch: this.

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts line 24

Quoted 3 lines

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +0 -0
 	chosen {
 		bootargs = "earlyprintk";

The naming of this board still confuses me though. It has 3 different names now:

- de0_sockit.dts
- Terasic DE-0(Atlas)
- de0-nano-soc

And according to Terasic DE0-Nano-SoC is the same as Atlas-SoC with a different software?! So all three names are actually correct ?! Weird.

Regards,
Steffen

Signature · 4 lines

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Dinh Nguyen

2016-02-25 16:56 UTC #4 lore raw

Quoted 16 lines · Steffen Trumtrar

Hi Tim!
Quoted 13 lines · Tim Sander
From: Tim Sander <[email protected]>
Add a more specific compatible string:"terasic,de0-nano-soc" for respective board.
Background: when checking for bootspec entries, some board specific fixups are not apropriate for board of the same platform ("altr,socfpga-cyclone5"). The same aproach is taken with the EBV-Socrates board.
Signed-off-by Tim Sander <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts     | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Quoted 16 lines

Documentation/devicetree/bindings/vendor-prefixes.txt synology Synology, Inc. · line 236
Quoted 12 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 72e2c5a..d1f7803 100644
@@ -230,6 +230,7 @@ synology	Synology, Inc.
 tbs	TBS Technologies
 tcl	Toby Churchill Ltd.
 technologic	Technologic Systems
+terasic	Terasic Inc.
 thine	THine Electronics, Inc.
 ti	Texas Instruments
 tlm	Trusted Logic Mobility
You should IMHO split this up in two patches.
First patch: add terasic

That's right. That patch will go through the DTS maintainer's tree.

Quoted 11 lines

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts line 21
Quoted 10 lines
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +1 -1
index afea364..704aa9d 100644
@@ -18,7 +18,7 @@
 
 / {
 	model = "Terasic DE-0(Atlas)";
-	compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+	compatible = "terasic,de0-nano-soc","altr,socfpga-cyclone5", "altr,socfpga";

So perhaps, "terasic,de0-sockit"?

Quoted 2 lines

Second patch: this.

And I can take this one.

Quoted 7 lines

arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts line 24
Quoted 3 lines
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +0 -0
 	chosen {
 		bootargs = "earlyprintk";
The naming of this board still confuses me though. It has 3 different names now:

Quoted 7 lines

- de0_sockit.dts
- Terasic DE-0(Atlas)
- de0-nano-soc
And according to Terasic DE0-Nano-SoC is the same as Atlas-SoC with a different software?! So all three names are actually correct ?! Weird.

I had a hard time understanding this myself. But from what I gather from[1], I just name the file de0_sockit.

Dinh

[1]
http://www.terasic.com.tw/cgi-bin/page/archive.pl?Language=English&CategoryNo=13&List=Simple#Category167

Tim Sander

author

2016-02-25 23:34 UTC #5 lore raw

Hi Dinh

Quoted 32 lines · On Thursday 25 February 2016 10:56:28 Dinh Nguyen wrote:

Quoted 31 lines · Steffen Trumtrar
Hi Tim!
Quoted 28 lines · Tim Sander
From: Tim Sander <[email protected]>
Add a more specific compatible string:"terasic,de0-nano-soc" for respective board. Background: when checking for bootspec entries, some board specific fixups are not apropriate for board of the same platform ("altr,socfpga-cyclone5"). The same aproach is taken with the EBV-Socrates board.
Signed-off-by Tim Sander <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts     | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0
b/Documentation/devicetree/bindings/vendor-prefixes.txt index 72e2c5a..d1f7803 100644
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -230,6 +230,7 @@ synology	Synology, Inc.
 
 tbs	TBS Technologies
 tcl	Toby Churchill Ltd.
 technologic	Technologic Systems
 
+terasic	Terasic Inc.
 

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
thine THine Electronics, Inc.
ti Texas Instruments
tlm Trusted Logic Mobility
You should IMHO split this up in two patches.
First patch: add terasic
That's right. That patch will go through the DTS maintainer's tree.

Ah well for such a simple patch it turns out more complicated than thought :-) Will do as soon as there is agreement on a name which does not seem that easy...

Quoted 32 lines

Quoted 8 lines
Quoted 8 lines
(quoted diff) +0 -0
b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts index afea364..704aa9d 100644
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +0 -0
@@ -18,7 +18,7 @@
 
Quoted 7 lines
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts line 24
Quoted 7 lines
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +1 -1
 / {
 
 	model = "Terasic DE-0(Atlas)";
 
-	compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+	compatible = "terasic,de0-nano-soc","altr,socfpga-cyclone5",
 "altr,socfpga";
So perhaps, "terasic,de0-sockit"?
Quoted 1 line
Second patch: this.
And I can take this one.
Quoted 11 lines
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts line 24
Quoted 3 lines
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts +0 -0
 	chosen {
 
 		bootargs = "earlyprintk";
The naming of this board still confuses me though.
It has 3 different names now:
- de0_sockit.dts
- Terasic DE-0(Atlas)
- de0-nano-soc

Quoted 5 lines

Quoted 2 lines
And according to Terasic DE0-Nano-SoC is the same as Atlas-SoC with a different software?! So all three names are actually correct ?! Weird.
I had a hard time understanding this myself. But from what I gather from[1], I just name the file de0_sockit.

As far as i remember there are different de0 and different sockit boards, so the name does not seem to be as concise? I don't care but i would say that de0-nano-soc is the most concise and easier to search for than atlas which might turn up more false postives?

But as long as there is a more selective name than cyclone5 everthing is fine with me.

Best regards
Tim

Dinh Nguyen

2016-02-25 23:38 UTC #6 lore raw

Quoted 5 lines · Tim Sander

As far as i remember there are different de0 and different sockit boards, so the name does not seem to be as concise? I don't care but i would say that de0-nano-soc is the most concise and easier to search for than atlas which might turn up more false postives?

I'm fine with "terasic,de0-nano-soc".

Dinh