Skip to contentSkip to conversation

doc: announce changes to eventdev public data structures

PATCH In review McDaniel, Timothy 6 participants 15 messages Jul 2, 2020 – Aug 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: announce changes to eventdev public data structures

From: "McDaniel, Timothy" <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
doc/guides/rel_notes/deprecation.rst +28 -0
index d1034f6..6af9b40 100644
@@ -130,3 +130,31 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: Three public data structures will be updated in 20.11;
+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
+  ``rte_event_port_conf``.
+  Two new members will be added to the ``rte_event_dev_info`` struct.
+  The first, max_event_port_links, will be a uint8_t, and represents the
+  maximum number of queues that can be linked to a single event port by
+  this device. The second, max_single_link_event_port_queue_pairs, will be a
+  uint8_t, and represents the maximum number of event ports and queues that
+  are optimized for (and only capable of) single-link configurations
+  supported by this device. These ports and queues are not accounted for in
+  max_event_ports or max_event_queues.
+  One new member will be added to the ``rte_event_dev_config`` struct. The
+  nb_single_link_event_port_queues member will be a uint8_t, and will
+  represent the number of event ports and queues that will be singly-linked
+  to each other. These are a subset of the overall event ports and queues.
+  This value cannot exceed nb_event_ports or nb_event_queues. If the
+  device has ports and queues that are optimized for single-link usage, this
+  field is a hint for how many to allocate; otherwise, regular event ports and
+  queues can be used.
+  Finally, the ``rte_event_port_conf`` struct will be
+  modified as follows. The uint8_t implicit_release_disabled field
+  will be replaced by a uint32_t event_port_cfg field. The new field will
+  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
+  will have the same meaning as implicit_release_disabled. The second bit,
+  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
+  to a single event queue.
+
Signature · 1 line
1.7.10
#1 lore raw
Quoted 59 lines

-----Original Message-----
From: McDaniel, Timothy <[email protected]>
Sent: Thursday, July 2, 2020 5:14 PM
To: [email protected]
Cc: [email protected]; Eads, Gage <[email protected]>; Van Haaren, Harry <[email protected]>; [email protected]; [email protected]; Rao, Nikhil <[email protected]>; Carrillo, Erik G <[email protected]>; Gujjar, Abhinandan S <[email protected]>; [email protected]; [email protected]; [email protected]; Mccarthy, Peter <[email protected]>; McDaniel, Timothy <[email protected]>
Subject: [PATCH] doc: announce changes to eventdev public data structures

From: "McDaniel, Timothy" <[email protected]>

---
doc/guides/rel_notes/deprecation.rst | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)
doc/guides/rel_notes/deprecation.rst +28 -1
index d1034f6..6af9b40 100644
@@ -130,3 +130,31 @@ Deprecation Notices
  Python 2 support will be completely removed in 20.11.
  In 20.08, explicit deprecation warnings will be displayed when running
  scripts with Python 2.
+
+* eventdev: Three public data structures will be updated in 20.11;
+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
+  ``rte_event_port_conf``.
+  Two new members will be added to the ``rte_event_dev_info`` struct.
+  The first, max_event_port_links, will be a uint8_t, and represents the
+  maximum number of queues that can be linked to a single event port by
+  this device. The second, max_single_link_event_port_queue_pairs, will be a
+  uint8_t, and represents the maximum number of event ports and queues that
+  are optimized for (and only capable of) single-link configurations
+  supported by this device. These ports and queues are not accounted for in
+  max_event_ports or max_event_queues.
+  One new member will be added to the ``rte_event_dev_config`` struct. The
+  nb_single_link_event_port_queues member will be a uint8_t, and will
+  represent the number of event ports and queues that will be singly-linked
+  to each other. These are a subset of the overall event ports and queues.
+  This value cannot exceed nb_event_ports or nb_event_queues. If the
+  device has ports and queues that are optimized for single-link usage, this
+  field is a hint for how many to allocate; otherwise, regular event ports and
+  queues can be used.
+  Finally, the ``rte_event_port_conf`` struct will be
+  modified as follows. The uint8_t implicit_release_disabled field
+  will be replaced by a uint32_t event_port_cfg field. The new field will
+  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
+  will have the same meaning as implicit_release_disabled. The second bit,
+  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
+  to a single event queue.
+
--
Quoted 1 line

1.7.10

Hello Jerin and DPDK community. Please review and approve the eventdev interface changes announced in this notice.

Thanks,
Tim

#2 lore raw
Quoted 55 lines · Timothy
Quoted 55 lines

-----Original Message-----
From: McDaniel, Timothy <[email protected]>
Sent: Thursday, July 2, 2020 5:14 PM
To: [email protected]
Cc: [email protected]; Eads, Gage <[email protected]>; Van Haaren, Harry <[email protected]>; [email protected]; [email protected]; Rao, Nikhil <[email protected]>; Carrillo, Erik G <[email protected]>; Gujjar, Abhinandan S <[email protected]>; [email protected]; [email protected]; [email protected]; Mccarthy, Peter <[email protected]>; McDaniel, Timothy <[email protected]>
Subject: [PATCH] doc: announce changes to eventdev public data structures

From: "McDaniel, Timothy" <[email protected]>

---
doc/guides/rel_notes/deprecation.rst | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)
doc/guides/rel_notes/deprecation.rst +24 -0
index d1034f6..6af9b40 100644
@@ -130,3 +130,31 @@ Deprecation Notices
  Python 2 support will be completely removed in 20.11.
  In 20.08, explicit deprecation warnings will be displayed when running
  scripts with Python 2.
+
+* eventdev: Three public data structures will be updated in 20.11;
+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
+  ``rte_event_port_conf``.
+  Two new members will be added to the ``rte_event_dev_info`` struct.
+  The first, max_event_port_links, will be a uint8_t, and represents the
+  maximum number of queues that can be linked to a single event port by
+  this device. The second, max_single_link_event_port_queue_pairs, will be a
+  uint8_t, and represents the maximum number of event ports and queues that
+  are optimized for (and only capable of) single-link configurations
+  supported by this device. These ports and queues are not accounted for in
+  max_event_ports or max_event_queues.
+  One new member will be added to the ``rte_event_dev_config`` struct. The
+  nb_single_link_event_port_queues member will be a uint8_t, and will
+  represent the number of event ports and queues that will be singly-linked
+  to each other. These are a subset of the overall event ports and queues.
+  This value cannot exceed nb_event_ports or nb_event_queues. If the
+  device has ports and queues that are optimized for single-link usage, this
+  field is a hint for how many to allocate; otherwise, regular event ports and
+  queues can be used.
+  Finally, the ``rte_event_port_conf`` struct will be
+  modified as follows. The uint8_t implicit_release_disabled field
+  will be replaced by a uint32_t event_port_cfg field. The new field will
+  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
Quoted 8 lines
Quoted 6 lines
doc/guides/rel_notes/deprecation.rst +4 -1
+  will have the same meaning as implicit_release_disabled. The second bit,
+  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
+  to a single event queue.
+
--

1.7.10

Hello Jerin and DPDK community. Please review and approve the eventdev interface changes announced in this notice.

Changes look good to me in general. Could you reword the description such way or similar like below to accommodate
1) DLB PMD requirements
2) Future extensions[1]

I think, We don't need exact mention the data structure member additions, (This is to get the flexibility on additions/deletion on member fields after the patch rework)

something like:

eventdev: ABI change to support DLB PMD and future extensions

The following structures and will be modified to support to DLB PMD and future extension in the eventdev library.

And then please enumerate the structures[2] of your patch which needs change, [2]``rte_event_dev_info``, ``rte_event_dev_config``, and ``rte_event_port_conf``
and structures in [1]. Please mention the patches [1] and your spec change patch as a reference in the description.

[1]
http://patches.dpdk.org/patch/72786/
http://patches.dpdk.org/patch/72787/

Quoted 3 lines

Thanks,
Tim

#3 lore raw

PATCH 1/1 doc: announce changes to eventdev public data structures

In reply to McDaniel, Timothy

From: "McDaniel, Timothy" <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst |   37 +++++++++-------------------------
 1 file changed, 10 insertions(+), 27 deletions(-)
doc/guides/rel_notes/deprecation.rst +10 -27
index ecb1bc4..4809643 100644
@@ -149,30 +149,13 @@ Deprecation Notices
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
 
-* eventdev: Three public data structures will be updated in 20.11;
-  ``rte_event_dev_info``, ``rte_event_dev_config``, and
-  ``rte_event_port_conf``.
-  Two new members will be added to the ``rte_event_dev_info`` struct.
-  The first, max_event_port_links, will be a uint8_t, and represents the
-  maximum number of queues that can be linked to a single event port by
-  this device. The second, max_single_link_event_port_queue_pairs, will be a
-  uint8_t, and represents the maximum number of event ports and queues that
-  are optimized for (and only capable of) single-link configurations
-  supported by this device. These ports and queues are not accounted for in
-  max_event_ports or max_event_queues.
-  One new member will be added to the ``rte_event_dev_config`` struct. The
-  nb_single_link_event_port_queues member will be a uint8_t, and will
-  represent the number of event ports and queues that will be singly-linked
-  to each other. These are a subset of the overall event ports and queues.
-  This value cannot exceed nb_event_ports or nb_event_queues. If the
-  device has ports and queues that are optimized for single-link usage, this
-  field is a hint for how many to allocate; otherwise, regular event ports and
-  queues can be used.
-  Finally, the ``rte_event_port_conf`` struct will be
-  modified as follows. The uint8_t implicit_release_disabled field
-  will be replaced by a uint32_t event_port_cfg field. The new field will
-  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
-  will have the same meaning as implicit_release_disabled. The second bit,
-  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
-  to a single event queue.
-
+* eventdev: ABI change to support DLB PMD and future extensions
+  The following structures and will be modified to support to DLB PMD and future
+  extension in the eventdev library.
+  - ``rte_event_dev_info``
+  - ``rte_event_dev_config``
+  - ``rte_event_port_conf``
+  Patches containing justification, documentation, and proposed modifications
+  can be found at
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
Signature · 1 line
1.7.10
#4 lore raw
Quoted 32 lines · Timothy

From: "McDaniel, Timothy" <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst |   37 +++++++++-------------------------
 1 file changed, 10 insertions(+), 27 deletions(-)
doc/guides/rel_notes/deprecation.rst +0 -16
index ecb1bc4..4809643 100644
@@ -149,30 +149,13 @@ Deprecation Notices
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
 
-* eventdev: Three public data structures will be updated in 20.11;
-  ``rte_event_dev_info``, ``rte_event_dev_config``, and
-  ``rte_event_port_conf``.
-  Two new members will be added to the ``rte_event_dev_info`` struct.
-  The first, max_event_port_links, will be a uint8_t, and represents the
-  maximum number of queues that can be linked to a single event port by
-  this device. The second, max_single_link_event_port_queue_pairs, will be a
-  uint8_t, and represents the maximum number of event ports and queues that
-  are optimized for (and only capable of) single-link configurations
-  supported by this device. These ports and queues are not accounted for in
-  max_event_ports or max_event_queues.
-  One new member will be added to the ``rte_event_dev_config`` struct. The
-  nb_single_link_event_port_queues member will be a uint8_t, and will
-  represent the number of event ports and queues that will be singly-linked
-  to each other. These are a subset of the overall event ports and queues.
-  This value cannot exceed nb_event_ports or nb_event_queues. If the

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 177

Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +0 -10
-  device has ports and queues that are optimized for single-link usage, this
-  field is a hint for how many to allocate; otherwise, regular event ports and
-  queues can be used.
-  Finally, the ``rte_event_port_conf`` struct will be
-  modified as follows. The uint8_t implicit_release_disabled field
-  will be replaced by a uint32_t event_port_cfg field. The new field will
-  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
-  will have the same meaning as implicit_release_disabled. The second bit,
-  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
-  to a single event queue.

Remove this section. It is a duplicate of the below section. One deprecation notice is enough.

Quoted 14 lines
doc/guides/rel_notes/deprecation.rst +10 -2
-
+* eventdev: ABI change to support DLB PMD and future extensions
+  The following structures and will be modified to support to DLB PMD and future
+  extension in the eventdev library.
+  - ``rte_event_dev_info``
+  - ``rte_event_dev_config``
+  - ``rte_event_port_conf``
+  Patches containing justification, documentation, and proposed modifications
+  can be found at
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
--

1.7.10

#5 lore raw

PATCH 1/1 doc: announce changes to eventdev public data structures

In reply to McDaniel, Timothy

From: "McDaniel, Timothy" <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +11 -0
index 99c9806..b9682a7 100644
@@ -148,3 +148,14 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: ABI change to support DLB PMD and future extensions
+  The following structures and will be modified to support to DLB PMD and future
+  extension in the eventdev library.
+  - ``rte_event_dev_info``
+  - ``rte_event_dev_config``
+  - ``rte_event_port_conf``
+  Patches containing justification, documentation, and proposed modifications
+  can be found at:
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
Signature · 1 line
1.7.10
Acked-by on v1 1/1
#6 lore raw
Quoted 2 lines · Timothy

From: "McDaniel, Timothy" <[email protected]>

The patch should have some description and
Please change the subject to: "doc: eventdev ABI change to support DLB PMD"

Quoted 2 lines

We don't use "," in the Signed-off-by. Please change to ``Signed-off-by: McDaniel Timothy <[email protected]>``

Quoted 13 lines
---
 doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +1 -0
index 99c9806..b9682a7 100644
@@ -148,3 +148,14 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 161

Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +10 -0
+* eventdev: ABI change to support DLB PMD and future extensions
+  The following structures and will be modified to support to DLB PMD and future
+  extension in the eventdev library.
+  - ``rte_event_dev_info``
+  - ``rte_event_dev_config``
+  - ``rte_event_port_conf``
+  Patches containing justification, documentation, and proposed modifications
+  can be found at:
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/

The HTML rendering of the above text is not proper. Please run "make doc-guides-html" to check generated HTML output.

You could use the below text as an example for sphinx syntax.

* eventdev: ABI change to support DLB PMD and future extensions:
``rte_event_dev_info``, ``rte_event_dev_config``, ``rte_event_port_conf`` will be modified to support to DLB PMD and future extension in the
eventdev library.
Patches containing justification, documentation, and proposed modifications can be found at:

- https://patches.dpdk.org/patch/71457/
- https://patches.dpdk.org/patch/71456/

With the above changes:

Quoted 3 lines

--
1.7.10

#7 lore raw

PATCH 1/1 doc: eventdev ABI change to support DLB PMD

From: "McDaniel, Timothy" <[email protected]>

The ABI changes associated with this notification will better support devices that:
1. Have limits on the number or queues that may be linked to a port
2. Have ports that are limited to exactly one linked queue
3. Are not able to transparently transfer the event flow_id field

Signed-off-by: McDaniel Timothy
<[email protected]>

---
 doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +11 -0
index 99c9806..bfe6661 100644
@@ -148,3 +148,14 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: ABI changes to support DLB PMD and future extensions:
+  ``rte_event_dev_info``, ``rte_event_dev_config``, ``rte_event_port_conf`` will
+  be modified to support DLB PMD and future extensions in the eventdev library.
+  Patches containing justification, documentation, and proposed modifications
+  can be found at:
+
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
+
+
Signature · 1 line
1.7.10
Acked-by on v1 1/1
#8 lore raw

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

Quoted 2 lines · Timothy

From: "McDaniel, Timothy" <[email protected]>

There is still "," in the name.

Quoted 9 lines

The ABI changes associated with this notification will better support devices that:
1. Have limits on the number or queues that may be linked to a port
2. Have ports that are limited to exactly one linked queue
3. Are not able to transparently transfer the event flow_id field

Signed-off-by: McDaniel Timothy
<[email protected]>

Quoted 26 lines
---
 doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +11 -1
index 99c9806..bfe6661 100644
@@ -148,3 +148,14 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: ABI changes to support DLB PMD and future extensions:
+  ``rte_event_dev_info``, ``rte_event_dev_config``, ``rte_event_port_conf`` will
+  be modified to support DLB PMD and future extensions in the eventdev library.
+  Patches containing justification, documentation, and proposed modifications
+  can be found at:
+
+  - https://patches.dpdk.org/patch/71457/
+  - https://patches.dpdk.org/patch/71456/
+
+
--

1.7.10

#9 lore raw

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

Quoted 26 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Jerin Jacob
Sent: Tuesday, August 4, 2020 1:09 PM
To: McDaniel, Timothy <[email protected]>
Cc: Jerin Jacob <[email protected]>; Mattias Rönnblom <[email protected]>; dpdk-dev <[email protected]>; Gage Eads <[email protected]>; Van Haaren, Harry <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

Quoted 2 lines · Timothy

From: "McDaniel, Timothy" <[email protected]>

There is still "," in the name.

Quoted 7 lines

The ABI changes associated with this notification will better support devices that:
1. Have limits on the number or queues that may be linked to a port 2. Have ports that are limited to exactly one linked queue 3. Are not able to transparently transfer the event flow_id field

Quoted 5 lines
Quoted 2 lines

Signed-off-by: McDaniel Timothy
<[email protected]>

Quoted 49 lines
Quoted 12 lines

---
 doc/guides/rel_notes/deprecation.rst |   11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 99c9806..bfe6661 100644

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 155

Quoted 8 lines
doc/guides/rel_notes/deprecation.rst +5 -0
@@ -148,3 +148,14 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: ABI changes to support DLB PMD and future extensions:
+  ``rte_event_dev_info``, ``rte_event_dev_config``,
+``rte_event_port_conf`` will
+  be modified to support DLB PMD and future extensions in the eventdev

library.

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 160

Quoted 6 lines
doc/guides/rel_notes/deprecation.rst +6 -0
+  Patches containing justification, documentation, and proposed
+modifications
+  can be found at:
+
+  -
+

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa

Quoted 1 line

+

tches.dpdk.org%2Fpatch%2F71457%2F&amp;data=02%7C01%7Chemant.agra wal%

Quoted 1 line

+

40nxp.com%7C0a8caadf8d834b79220b08d838497b8b%7C686ea1d3bc2b4c6fa 92cd

Quoted 1 line

+

99c5c301635%7C0%7C0%7C637321235549807830&amp;sdata=9cH1qyDLlJz%2 BNoI

Quoted 2 lines

+ whoam9rzpuMKGqZJWG6lMDkuoy1A%3D&amp;reserved=0
+ -

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
es.dpdk.org%2Fpatch%2F71456%2F&amp;data=02%7C01%7Chemant.agrawa l%40nxp.com%7C0a8caadf8d834b79220b08d838497b8b%7C686ea1d3bc2b4c6 fa92cd99c5c301635%7C0%7C0%7C637321235549817822&amp;sdata=dHNynX 75PGfiOtIycdm4raCRt5MWQPTWgHi%2Bj9Q331A%3D&amp;reserved=0

Quoted 5 lines
doc/guides/rel_notes/deprecation.rst +2 -1
+
+
--

1.7.10

Acked-by Harry van Haaren
#10 lore raw

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

Quoted 11 lines
Quoted 11 lines
Quoted 1 line

From: "McDaniel, Timothy" <[email protected]>

There is still "," in the name.

Quoted 7 lines

The ABI changes associated with this notification will better support devices that:
1. Have limits on the number or queues that may be linked to a port 2. Have ports that are limited to exactly one linked queue 3. Are not able to transparently transfer the event flow_id field

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

Signed-off-by: McDaniel Timothy
<[email protected]>

Quoted 2 lines
Quoted 1 line

Applied with name fixed, thanks

#11 lore raw

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

Quoted 21 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Wednesday, August 5, 2020 6:40 PM
To: McDaniel, Timothy <[email protected]>
Cc: Jerin Jacob <[email protected]>; [email protected]; Jerin Jacob <[email protected]>; Mattias Rönnblom <[email protected]>; Eads, Gage <[email protected]>; Van Haaren, Harry <[email protected]>; Hemant Agrawal <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

Quoted 11 lines
Quoted 11 lines
Quoted 1 line

From: "McDaniel, Timothy" <[email protected]>

There is still "," in the name.

Quoted 7 lines

The ABI changes associated with this notification will better support devices that:
1. Have limits on the number or queues that may be linked to a port 2. Have ports that are limited to exactly one linked queue 3. Are not able to transparently transfer the event flow_id field

Quoted 9 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

Signed-off-by: McDaniel Timothy
<[email protected]>

Quoted 2 lines
Quoted 1 line

Applied with name fixed, thanks

Thank you Thomas!

Tim

Acked-by on v1 1/1
#12 lore raw

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

In reply to McDaniel, Timothy
Quoted 11 lines

-----Original Message-----
From: McDaniel, Timothy <[email protected]>
Sent: Monday, August 3, 2020 6:56 PM
To: [email protected]
Cc: [email protected]; [email protected]; Eads, Gage <[email protected]>; Van Haaren, Harry <[email protected]>; McDaniel, Timothy <[email protected]>
Subject: [PATCH] doc: eventdev ABI change to support DLB PMD

From: "McDaniel, Timothy" <[email protected]>

Quoted 8 lines

The ABI changes associated with this notification will better support devices that:
1. Have limits on the number or queues that may be linked to a port
2. Have ports that are limited to exactly one linked queue
3. Are not able to transparently transfer the event flow_id field

Signed-off-by: McDaniel Timothy
<[email protected]>

Nitpick: git warns on added extra new blank line at end of file.

<snip>

#13 lore raw
In reply to McDaniel, Timothy
Quoted 12 lines · Timothy

From: "McDaniel, Timothy" <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index d1034f6..6af9b40 100644

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 136

Quoted 7 lines
doc/guides/rel_notes/deprecation.rst +4 -0
@@ -130,3 +130,31 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: Three public data structures will be updated in 20.11;
+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
+  ``rte_event_port_conf``.

At a minimum a sub-bullet here for each of the public data structures, would a gift to readability.

Quoted 25 lines
doc/guides/rel_notes/deprecation.rst +24 -0
+  Two new members will be added to the ``rte_event_dev_info`` struct.
+  The first, max_event_port_links, will be a uint8_t, and represents the
+  maximum number of queues that can be linked to a single event port by
+  this device. The second, max_single_link_event_port_queue_pairs, will be a
+  uint8_t, and represents the maximum number of event ports and queues that
+  are optimized for (and only capable of) single-link configurations
+  supported by this device. These ports and queues are not accounted for in
+  max_event_ports or max_event_queues.
+  One new member will be added to the ``rte_event_dev_config`` struct. The
+  nb_single_link_event_port_queues member will be a uint8_t, and will
+  represent the number of event ports and queues that will be singly-linked
+  to each other. These are a subset of the overall event ports and queues.
+  This value cannot exceed nb_event_ports or nb_event_queues. If the
+  device has ports and queues that are optimized for single-link usage, this
+  field is a hint for how many to allocate; otherwise, regular event ports and
+  queues can be used.
+  Finally, the ``rte_event_port_conf`` struct will be
+  modified as follows. The uint8_t implicit_release_disabled field
+  will be replaced by a uint32_t event_port_cfg field. The new field will
+  initially have two bits assigned. RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL
+  will have the same meaning as implicit_release_disabled. The second bit,
+  RTE_EVENT_PORT_CFG_SINGLE_LINK will be set if the event port links only
+  to a single event queue.
+
#14 lore raw

05/08/2020 11:36, Kinsella, Ray:

Quoted 9 lines · Timothy
Quoted 7 lines

From: "McDaniel, Timothy" <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
Quoted 15 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 136

Quoted 12 lines
doc/guides/rel_notes/deprecation.rst +4 -0
index d1034f6..6af9b40 100644
@@ -130,3 +130,31 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* eventdev: Three public data structures will be updated in 20.11;
+  ``rte_event_dev_info``, ``rte_event_dev_config``, and
+  ``rte_event_port_conf``.

At a minimum a sub-bullet here for each of the public data structures, would a gift to readability.

I've converted the list into bullets while applying.