Skip to contentSkip to conversation

cfg80211: Add feature flag to indicate RSNXE IE support in FT

PATCH In review Veerendranath Jakkam 2 participants 2 messages Aug 4, 2020 – Aug 27, 2020 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cfg80211: Add feature flag to indicate RSNXE IE support in FT

Add a new feature flag that drivers in which FT handshake is offloaded, to advertise support for interoperability with legacy clients which doesn't support using RSNXE IE for MIC calculation in FT handshake. The userspace can choose to enable/disable FT protocols that require RSNXE IE to be used based on this flag advertised by drivers.

include/uapi/linux/nl80211.h +4 -0
index 631f3a99..83e8079 100644
@@ -5820,6 +5820,9 @@ enum nl80211_feature_flags {
  * @NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK: Device wants to do 4-way
  *	handshake with PSK in AP mode (PSK is passed as part of the start AP
  *	command).
+ * @NL80211_EXT_FEATURE_FT_RSNXE: Driver supports RSNXE element in FT handshake
+ *	and interoperable with legacy clients that doesn't support using RSNXE
+ *	IE for MIC computation in FT handshake.
  *
  * @NUM_NL80211_EXT_FEATURES: number of extended features.
  * @MAX_NL80211_EXT_FEATURES: highest extended feature index.
@@ -5878,6 +5881,7 @@ enum nl80211_ext_feature_index {
 	NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_TX_STATUS,
 	NL80211_EXT_FEATURE_OPERATING_CHANNEL_VALIDATION,
 	NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK,
+	NL80211_EXT_FEATURE_FT_RSNXE,
 
 	/* add new features before the definition below */
 	NUM_NL80211_EXT_FEATURES,
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#1 lore raw
Quoted 1 line · Veerendranath Jakkam

Add a new feature flag that drivers in which FT handshake is offloaded,

"that drivers (in which ...)" what? Can set? Are expected to use?

Quoted 2 lines

to advertise support for interoperability with legacy clients which doesn't

don't? or what does "doesn't" refer to?

Quoted 3 lines

support using RSNXE IE for MIC calculation in FT handshake. The
userspace can choose to enable/disable FT protocols that require RSNXE IE to be used based on this flag advertised by drivers.

I can't say I really understand this.

include/uapi/linux/nl80211.h enum nl80211_feature_flags { · line 5825

Quoted 13 lines
include/uapi/linux/nl80211.h +3 -0
index 631f3a99..83e8079 100644
@@ -5820,6 +5820,9 @@ enum nl80211_feature_flags {
  * @NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK: Device wants to do 4-way
  *	handshake with PSK in AP mode (PSK is passed as part of the start AP
  *	command).
+ * @NL80211_EXT_FEATURE_FT_RSNXE: Driver supports RSNXE element in FT handshake
+ *	and interoperable with legacy clients that doesn't support using RSNXE
+ *	IE for MIC computation in FT handshake.

Nor this. Please rewrite the commit message and comment to be more explanatory (and grammatically correct).

johannes