RDMA/bnxt_re: Do not add user qps to flushlist
Subsystems (2)
Selvin Xavier
maintainerPATCH 1/1 RDMA/bnxt_re: Do not add user qps to flushlist
Driver shall add only the kernel qps to the flush list for clean up. During async error events from the HW, driver is adding qps to this list without checking if the qp is kernel qp or not.
Add a check to avoid user qp addition to the flush list.
Fixes 942c9b6ca8de ("RDMA/bnxt_re: Avoid Hard lockup during error CQE processing")
Fixes c50866e2853a ("bnxt_re: fix the regression due to changes in alloc_pbl")
Signed-off-by Selvin Xavier <[email protected]>
--- drivers/infiniband/hw/bnxt_re/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/infiniband/hw/bnxt_re/main.c +2 -1
@@ -821,7 +821,8 @@ static int bnxt_re_handle_qp_async_event(struct creq_qp_event *qp_event,struct ib_event event;unsigned int flags; -if (qp->qplib_qp.state ==CMDQ_MODIFY_QP_NEW_STATE_ERR ) { +if (qp->qplib_qp.state ==CMDQ_MODIFY_QP_NEW_STATE_ERR && +rdma_is_kernel_res (&qp->ib_qp.res)) { flags =bnxt_re_lock_cqs (qp);bnxt_qplib_add_flush_qp (&qp->qplib_qp);bnxt_re_unlock_cqs (qp, flags);
Signature · 1 line
2.5.5
Quoted 4 lines · Selvin Xavier
Driver shall add only the kernel qps to the flush list for clean up. During async error events from the HW, driver is adding qps to this list without checking if the qp is kernel qp or not.
Quoted 8 lines
Add a check to avoid user qp addition to the flush list.
Fixes 942c9b6ca8de ("RDMA/bnxt_re: Avoid Hard lockup during error CQE processing")Fixes c50866e2853a ("bnxt_re: fix the regression due to changes in alloc_pbl")Signed-off-by Selvin Xavier <[email protected]>--- drivers/infiniband/hw/bnxt_re/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to for-rc, thanks
Jason