i2c: mediatek: Fix i2c_spec_values description
PATCH v2 1/1 i2c: mediatek: Fix i2c_spec_values description
From: Matthias Brugger <[email protected]>
The struct i2c_spec_values have it's members documented but is missing the starting '@', which leads to warings like:
drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_low_ns' not described in 'i2c_spec_values'
We also delete min_high_ns member as it is not used in the code.
---
Changes since v1:
delete mint_high_ns member
drivers/i2c/busses/i2c-mt65xx.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/i2c/busses/i2c-mt65xx.c +4 -5
@@ -253,14 +253,13 @@ struct mtk_i2c {/** * struct i2c_spec_values: -* min_low_ns: min LOW period of the SCL clock -* min_su_sta_ns: min set-up time for a repeated START condition -* max_hd_dat_ns: max data hold time -* min_su_dat_ns: min data set-up time +* @min_low_ns: min LOW period of the SCL clock +* @min_su_sta_ns: min set-up time for a repeated START condition +* @max_hd_dat_ns: max data hold time +* @min_su_dat_ns: min data set-up time */ struct i2c_spec_values {unsigned int min_low_ns; -unsigned int min_high_ns;unsigned int min_su_sta_ns;unsigned int max_hd_dat_ns;unsigned int min_su_dat_ns;
Signature · 1 line
2.28.0
Quoted 10 lines · On Fri, 2020-08-07 at 15:19 +0200, [email protected] wrote:
From: Matthias Brugger <[email protected]>
The struct
i2c_spec_valueshave it's members documented but is missing the starting '@', which leads to warings like:
drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_low_ns' not described in 'i2c_spec_values'We also delete
min_high_nsmember as it is not used in the code.Signed-off-by Matthias Brugger <[email protected]>
Quoted 31 lines
---
Changes since v1:
deletemint_high_nsmemberdrivers/i2c/busses/i2c-mt65xx.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)drivers/i2c/busses/i2c-mt65xx.c +4
-5@@ -253,14 +253,13 @@ struct mtk_i2c {/** * struct i2c_spec_values: -* min_low_ns: min LOW period of the SCL clock -* min_su_sta_ns: min set-up time for a repeated START condition -* max_hd_dat_ns: max data hold time -* min_su_dat_ns: min data set-up time +* @min_low_ns: min LOW period of the SCL clock +* @min_su_sta_ns: min set-up time for a repeated START condition +* @max_hd_dat_ns: max data hold time +* @min_su_dat_ns: min data set-up time */ struct i2c_spec_values {unsigned int min_low_ns; -unsigned int min_high_ns;unsigned int min_su_sta_ns;unsigned int max_hd_dat_ns;unsigned int min_su_dat_ns;