Skip to contentSkip to conversation

Add mediatek codec mt6359 driver

PATCH Superseded Jiaxin Yu 3 participants 6 messages Aug 14, 2020 – Aug 15, 2020

Subsystems (4)

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Jiaxin Yu

author
#0 lore raw

v3 cover Add mediatek codec mt6359 driver

Add mediatek codec (MT6359) driver

MT6359 support playback and capture feature.

On downlink path, it includes three DACs for handset, headset, and lineout path. On unlink path, it includeds three ADCs for main mic, second mic, 3rd mic, and headset mic.

By scenario, select *_MUX widget to create damp path. And by select mic_type_mux to choose DMIC/AMIC/....

For example, select these MUX widget to create headset path
(1) DAC In Mux --> "Normal Path"
(2) HPL Mux --> "Audio Playback"
(3) HPR Mux --> "Audio Playback"

v3 changes:
1. Remove calibration related functions.
2. Conbined 'HPL Mux' and 'HPR Mux' to 'HP Mux'.
3. Move the regulator_enable of 'vaud18' to the component probe.
4. Fix some incorrect coding style.

v2 changes:

	1. patchwork link:
		https://patchwork.kernel.org/cover/11706935/
		https://patchwork.kernel.org/patch/11708865/
		https://patchwork.kernel.org/patch/11706937/

v1 changes:

	1.lkml link:
		https://lkml.org/lkml/2020/3/5/1257

Jiaxin Yu (2):
WIP: ASoC: mediatek: mt6359: add codec driver
WIP: dt-bindings: mediatek: mt6359: add codec document

 .../devicetree/bindings/sound/mt6359.yaml     |   68 +
 sound/soc/codecs/Kconfig                      |    8 +
 sound/soc/codecs/Makefile                     |    2 +
 sound/soc/codecs/mt6359.c                     | 2737 +++++++++++++++++
 sound/soc/codecs/mt6359.h                     | 2640 ++++++++++++++++
 5 files changed, 5455 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/mt6359.yaml
 create mode 100644 sound/soc/codecs/mt6359.c
 create mode 100644 sound/soc/codecs/mt6359.h
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH v3 1/2 WIP: ASoC: mediatek: mt6359: add codec driver

Add the mt6359 codec driver.

---
 sound/soc/codecs/Kconfig  |    8 +
 sound/soc/codecs/Makefile |    2 +
 sound/soc/codecs/mt6359.c | 2737 +++++++++++++++++++++++++++++++++++++
 sound/soc/codecs/mt6359.h | 2640 +++++++++++++++++++++++++++++++++++
 4 files changed, 5387 insertions(+)
 create mode 100644 sound/soc/codecs/mt6359.c
 create mode 100644 sound/soc/codecs/mt6359.h
sound/soc/codecs/Kconfig +8 -0
index e2b5597374a18..ec96652f74eee 100644
@@ -126,6 +126,7 @@ config SND_SOC_ALL_CODECS
 	imply SND_SOC_ML26124
 	imply SND_SOC_MT6351
 	imply SND_SOC_MT6358
+	imply SND_SOC_MT6359
 	imply SND_SOC_MT6660
 	imply SND_SOC_NAU8540
 	imply SND_SOC_NAU8810
@@ -1622,6 +1623,13 @@ config SND_SOC_MT6358
 	  Enable support for the platform which uses MT6358 as
 	  external codec device.
 
+config SND_SOC_MT6359
+	tristate "MediaTek MT6359 Codec"
+	depends on MTK_PMIC_WRAP
+	help
+	  Enable support for the platform which uses MT6359 as
+	  external codec device.
+
 config SND_SOC_MT6660
 	tristate "Mediatek MT6660 Speaker Amplifier"
 	depends on I2C
sound/soc/codecs/Makefile +2 -0
index d9f29136f1546..b80c68adcb14c 100644
@@ -120,6 +120,7 @@ snd-soc-msm8916-analog-objs := msm8916-wcd-analog.o
 snd-soc-msm8916-digital-objs := msm8916-wcd-digital.o
 snd-soc-mt6351-objs := mt6351.o
 snd-soc-mt6358-objs := mt6358.o
+snd-soc-mt6359-objs := mt6359.o
 snd-soc-mt6660-objs := mt6660.o
 snd-soc-nau8540-objs := nau8540.o
 snd-soc-nau8810-objs := nau8810.o
@@ -412,6 +413,7 @@ obj-$(CONFIG_SND_SOC_MSM8916_WCD_ANALOG) +=snd-soc-msm8916-analog.o
 obj-$(CONFIG_SND_SOC_MSM8916_WCD_DIGITAL) +=snd-soc-msm8916-digital.o
 obj-$(CONFIG_SND_SOC_MT6351)	+= snd-soc-mt6351.o
 obj-$(CONFIG_SND_SOC_MT6358)	+= snd-soc-mt6358.o
+obj-$(CONFIG_SND_SOC_MT6359)	+= snd-soc-mt6359.o
 obj-$(CONFIG_SND_SOC_MT6660)	+= snd-soc-mt6660.o
 obj-$(CONFIG_SND_SOC_NAU8540)   += snd-soc-nau8540.o
 obj-$(CONFIG_SND_SOC_NAU8810)   += snd-soc-nau8810.o
sound/soc/codecs/mt6359.c new file +2737 -0

2,737 lines not on this page · raw message

sound/soc/codecs/mt6359.h new file +2640 -0

229 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.18.0

Part of the diff is not shown here. View the raw message.

maintainer
#2 lore raw

Re: [PATCH v3 1/2] WIP: ASoC: mediatek: mt6359: add codec driver

On Fri, Aug 14, 2020 at 06:45:53PM +0800, Jiaxin Yu wrote:

This looks mostly good, a couple of very small things:

sound/soc/codecs/mt6359.c line 2707

Quoted 6 lines
sound/soc/codecs/mt6359.c new file +6 -0
+	ret = regulator_enable(priv->avdd_reg);
+	if (ret) {
+		dev_err(&pdev->dev, "%s(), failed to enable regulator!\n",
+			__func__);
+		return ret;
+	}

You need a remove() function to undo this enable.

sound/soc/codecs/mt6359.c line 2716

Quoted 2 lines
sound/soc/codecs/mt6359.c new file +2 -0
+	dev_info(&pdev->dev, "%s(), dev name %s\n",
+		 __func__, dev_name(&pdev->dev));

This isn't really adding anything, just remove it - it's not reading info from the hardware or anything.

author
#3 lore raw

Re: [PATCH v3 1/2] WIP: ASoC: mediatek: mt6359: add codec driver

Quoted 4 lines · Mark Brown

On Fri, Aug 14, 2020 at 06:45:53PM +0800, Jiaxin Yu wrote:

This looks mostly good, a couple of very small things:

Quoted 9 lines

sound/soc/codecs/mt6359.c line 2707

Quoted 6 lines
sound/soc/codecs/mt6359.c new file +6 -0
+	ret = regulator_enable(priv->avdd_reg);
+	if (ret) {
+		dev_err(&pdev->dev, "%s(), failed to enable regulator!\n",
+			__func__);
+		return ret;
+	}

You need a remove() function to undo this enable.

Ok, I will add a remove() function to do regulator_disable() and snd_soc_unregister_component().

Quoted 5 lines

sound/soc/codecs/mt6359.c line 2716

Quoted 2 lines
sound/soc/codecs/mt6359.c new file +2 -0
+	dev_info(&pdev->dev, "%s(), dev name %s\n",
+		 __func__, dev_name(&pdev->dev));

This isn't really adding anything, just remove it - it's not reading info from the hardware or anything.

Yes, it was unnecessary, removed it in PATCH v4.
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#4 lore raw

PATCH v3 2/2 WIP: dt-bindings: mediatek: mt6359: add codec document

In reply to Jiaxin Yu

This patch adds MediaTek MT6359 codec document.

---
 .../devicetree/bindings/sound/mt6359.yaml     | 68 +++++++++++++++++++
 1 file changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/mt6359.yaml
Documentation/devicetree/bindings/sound/mt6359.yaml new file +68 -0
new file mode 100644
index 0000000000000..a669b49965874
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mt6359.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT6359 Codec Device Tree Bindings
+
+maintainers:
+  - Eason Yen <[email protected]>
+  - Jiaxin Yu <[email protected]>
+  - Shane Chien <[email protected]>
+
+description: |
+  The communication between MT6359 and SoC is through Mediatek PMIC wrapper.
+  For more detail, please visit Mediatek PMIC wrapper documentation.
+  Must be a child node of PMIC wrapper.
+
+properties:
+  compatible:
+    const: mediatek,mt6359-sound
+
+  mediatek,dmic-mode:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      Indicates how many data pins are used to transmit two channels of PDM
+      signal. 0 means two wires, 1 means one wire. Default value is 0.
+    enum:
+      - 0 # one wire
+      - 1 # two wires
+
+  mediatek,mic-type-0:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      Specifies the type of mic type connected to adc0
+
+    enum:
+      - 0 # IDLE - mic in turn-off status
+      - 1 # ACC - analog mic with alternating coupling
+      - 2 # DMIC - digital mic
+      - 3 # DCC - analog mic with direct couping
+      - 4 # DCC_ECM_DIFF - analog electret condenser mic with differential mode
+      - 5 # DCC_ECM_SINGLE - analog electret condenser mic with single mode
+
+  mediatek,mic-type-1:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      Specifies the type of mic type connected to adc1
+
+  mediatek,mic-type-2:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      Specifies the type of mic type connected to adc2
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    mt6359codec: mt6359codec {
+      compatible = "mediatek,mt6359-sound";
+      mediatek,dmic-mode = <0>;
+      mediatek,mic-type-0 = <2>;
+    };
+
+...
Signature · 1 line
2.18.0
#5 lore raw
In reply to Jiaxin Yu
Quoted 3 lines · Jiaxin Yu

Jiaxin Yu (2):
WIP: ASoC: mediatek: mt6359: add codec driver
WIP: dt-bindings: mediatek: mt6359: add codec document

Please remove the "WIP: " prefixes and resend again.