ath10k: move enable_pll_clk call to ath10k_core_start()
PATCH 1/1 ath10k: move enable_pll_clk call to ath10k_core_start()
There's no reason to have call for enable_pll_clk in ath10k_bmi_start(), move it to ath10k_core_start() instead. This way it's possible to call ath10k_bmi_start() from sdio.c during firmware dump creation. And also the function call is more visible when it's in core.c.
No functional changes, compile tested only.
--- drivers/net/wireless/ath/ath10k/bmi.c | 8 -------- drivers/net/wireless/ath/ath10k/core.c | 7 +++++++ 2 files changed, 7 insertions(+), 8 deletions(-)
drivers/net/wireless/ath/ath10k/bmi.c +0 -8
@@ -12,17 +12,9 @@void ath10k_bmi_start (struct ath10k *ar) { -int ret; -ath10k_dbg (ar,ATH10K_DBG_BMI ,"bmi start\n" ); ar->bmi.done_sent = false; - -/* Enable hardware clock to speed up firmware download */ -if (ar->hw_params.hw_ops->enable_pll_clk) { - ret = ar->hw_params.hw_ops->enable_pll_clk (ar); -ath10k_dbg (ar,ATH10K_DBG_BMI ,"bmi enable pll ret %d\n" , ret); - } }int ath10k_bmi_done (struct ath10k *ar)
drivers/net/wireless/ath/ath10k/core.c +7 -0
@@ -2614,6 +2614,13 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode, ar->running_fw->fw_file.fw_features)) {ath10k_bmi_start (ar); +/* Enable hardware clock to speed up firmware download */ +if (ar->hw_params.hw_ops->enable_pll_clk) { + status = ar->hw_params.hw_ops->enable_pll_clk (ar); +ath10k_dbg (ar,ATH10K_DBG_BOOT ,"boot enable pll ret %d\n" , + status); + } +if (ath10k_init_configure_target (ar)) { status = -EINVAL ; goto err;
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 8 lines · Kalle Valo
There's no reason to have call for
enable_pll_clkinath10k_bmi_start(), move it toath10k_core_start()instead. This way it's possible to callath10k_bmi_start()fromsdio.cduring firmware dump creation. And also the function call is more visible when it's incore.c.No functional changes, compile tested only.
Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
ad0dc0426468 ath10k: move enable_pll_clk call to ath10k_core_start()
Signature · 3 lines
https://patchwork.kernel.org/patch/11714755/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 8 lines · Kalle Valo
There's no reason to have call for
enable_pll_clkinath10k_bmi_start(), move it toath10k_core_start()instead. This way it's possible to callath10k_bmi_start()fromsdio.cduring firmware dump creation. And also the function call is more visible when it's incore.c.No functional changes, compile tested only.
Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
ad0dc0426468 ath10k: move enable_pll_clk call to ath10k_core_start()
Signature · 9 lines
https://patchwork.kernel.org/patch/11714755/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k