Skip to contentSkip to conversation

MFD for v5.9

DISCUSSION Merged Lee Jones 3 participants 8 messages Aug 11, 2020 – Aug 17, 2020

lore
Share & tools
lore

Lee Jones

author
#0 lore raw

Good morning Linus,

Enjoy!

The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:

Linux 5.8-rc1 (2020-06-14 12:45:04 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git mfd-next-5.9

for you to fetch changes up to ee849ff1fd31f761fc65af04f2649a37e769ceab:

mfd: core: Fix memory leak of 'cell' (2020-08-10 12:27:30 +0100)

----------------------------------------------------------------
- Core Frameworks
- Make better attempt at matching device with the correct OF node
- Allow batch removal of hierarchical sub-devices

- New Drivers
- Add STM32 Clocksource driver
- Add support for Khadas System Control Microcontroller

- Driver Removal
- Remove unused driver for TI's SMSC ECE1099

- New Device Support
- Add support for Intel Emmitsburg PCH to Intel LPSS PCI
- Add support for Intel Tiger Lake PCH-H to Intel LPSS PCI
- Add support for Dialog DA revision to Dialog DA9063

- New Functionality
- Add support for AXP803 to be probed by I2C

- Fix-ups
- Numerous W=1 warning fixes
- Device Tree changes; stm32-lptimer, gateworks-gsc, khadas,mcu, stmfx, cros-ec, j721e-system-controller
- Enabled Regmap 'fast I/O'; stm32-lptimer
- Change BUG_ON to WARN_ON; arizona-core
- Remove superfluous code/initialisation; madera, max14577
- Trivial formatting/spelling issues; madera-core, madera-i2c, da9055, max77693-private
- Switch to of_platform_populate(); sprd-sc27xx-spi
- Expand out set/get brightness/pwm macros; lm3533-ctrlbank
- Disable IRQs on suspend; motorola-cpcap
- Clean-up error handling; intel_soc_pmic_mrfld
- Ensure correct removal order of sub-devices; madera
- Many s/HTTP/HTTPS/ link changes
- Ensure name used with Regmap is unique; syscon

- Bug Fixes
- Properly 'put' clock on unbind and error; arizona-core
- Fix revision handling; da9063
- Fix 'assignment of read-only location' error; kempld-core
- Avoid using the Regmap API when atomic; rn5t618
- Redefine volatile register description; rn5t618
- Use locking to protect event handler; dln2

----------------------------------------------------------------
Adam Thomson (2):
mfd: da9063: Fix revision handling to correctly select reg tables
mfd: da9063: Add support for latest DA silicon revision

Alexander A. Klimov (1):
mfd: Replace HTTP links with HTTPS ones

Andreas Kemnade (2):
mfd: rn5t618: Make restart handler atomic safe
mfd: rn5t618: Fix caching of battery related registers

Andy Shevchenko (3):
mfd: intel-lpss: Add Intel Emmitsburg PCH PCI IDs
mfd: intel-lpss: Add Intel Tiger Lake PCH-H PCI IDs
mfd: dln2: Run event handler loop under spinlock

Benjamin Gaignard (5):
dt-bindings: mfd: Document STM32 low power timer bindings
mfd: stm32: Add defines to be used for clkevent purpose
mfd: stm32: Enable regmap fast_io for stm32-lptimer
clocksource: Add Low Power STM32 timers driver
dt-bindings: mfd: Convert stmfx bindings to json-schema

Charles Keepax (6):
mfd: arizona: Remove BUG_ON usage
mfd: arizona: Ensure 32k clock is put on driver unbind and error
mfd: madera: Remove unused forward declaration of madera_codec_pdata
mfd: madera: Fix minor formatting issues
mfd: mfd-core: Add mechanism for removal of a subset of children
mfd: madera: Improve handling of regulator unbinding

Chunyan Zhang (1):
mfd: sprd: Populate sub-devices defined in DT

Colin Ian King (1):
mfd: max14577: Remove redundant initialization of variable current_bits

Fabio Estevam (2):
dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
dt-bindings: mfd: st,stmfx: Remove I2C unit name

Frank Lee (1):

      mfd: axp20x: Allow the AXP803 to be probed by I2C

Ikjoon Jang (1):
dt-bindings: mfd: Convert ChromeOS EC bindings to json-schema

Johan Hovold (1):
mfd: lm3533: Expand control-bank accessors

Lee Jones (37):
mfd: twl4030-irq: Fix incorrect type in assignment warning
mfd: twl4030-irq: Fix cast to restricted __le32 warning
mfd: tps6586x: Fix cast to restricted __le32 warning
mfd: altera-sysmgr: Fix physical address storing hacks
mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning
mfd: ab3100-core: Fix incompatible types in comparison expression warning
mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue
mfd: tc3589x: Remove invalid use of kerneldoc syntax
mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg
mfd: wm831x-core: Supply description wm831x_reg_{un}lock args
mfd: wm8350-core: Supply description wm8350_reg_{un}lock args
mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()
mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc
mfd: db8500-prcmu: Remove incorrect function header from .probe() function
mfd: omap-usb-host: Remove invalid use of kerneldoc syntax
mfd: omap-usb-host: Provide description for 'pdev' argument to .probe()
mfd: omap-usb-tll: Provide description for 'pdev' argument to .probe()
mfd: atmel-smc: Add missing colon(s) for 'conf' arguments
mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args
mfd: cros_ec_dev: Fix cros_feature_to_{name,cells} struct descriptions
mfd: tps65218: Repair incorrect function argument name 's/tps65218/tps/'
mfd: tps65217: Repair incorrect function argument name 's/tps65217/tps/'
mfd: ab3100-otp: Add missing colon(s) for all documented kerneldoc arguments
mfd: tps65010: Remove delcared and set, but never used variable 'status'
mfd: si476x-cmd: Repair wrongly described function argument 's/response/resp'
mfd: si476x-cmd: Add missing colon(s) for all documented kerneldoc arguments
mfd: si476x-i2c: Add description for si476x_core_fwver_to_revision()'s arg 'func'
mfd: si476x-i2c: Fix spelling mistake in case() statement's FALLTHROUGH comment
mfd: si476x-cmd: Update si476x_cmd_am_rsq_status()'s kerneldoc
mfd: si476x-cmd: Add missing documentation for si476x_cmd_fm_rds_status()'s arg 'report'
mfd: rave-sp: Fix mistake in 'struct rave_sp_deframer's kerneldoc
mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting
mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
mfd: core: Make a best effort attempt to match devices with the correct of_nodes
mfd: core: Fix formatting of MFD helpers
mfd: core: Add OF_MFD_CELL_REG() helper
mfd: core: Fix memory leak of 'cell'

Matti Vaittinen (1):
MAINTAINERS: Add entry for ROHM Power Management ICs

Michael Walle (1):
mfd: smsc-ece1099: Remove driver

Neil Armstrong (4):
dt-bindings: mfd: Add Khadas Microcontroller bindings
mfd: Add support for the Khadas System control Microcontroller
thermal: Add support for the MCU controlled FAN on Khadas boards
MAINTAINERS: Add myself as maintainer for Khadas MCU drivers

Randy Dunlap (2):
mfd: da9055: pdata.h: Drop a duplicated word
mfd: max77693-private: Drop a duplicated word

Roger Quadros (1):
dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller

Stephen Rothwell (1):
mfd: kempld-core: Fix 'assignment of read-only location' error

Suman Anna (1):
mfd: syscon: Use a unique name with regmap_config

Tim Harvey (1):
dt-bindings: mfd: gateworks-gsc: Add 16bit pre-scaled voltage mode

Tony Lindgren (1):
mfd: motorola-cpcap: Disable interrupt for suspend

Xu Wang (1):
mfd: intel_soc_pmic_mrfld: Simplify the return expression of intel_scu_ipc_dev_iowrite8()

 Documentation/devicetree/bindings/mfd/cros-ec.txt  |  76 ------
 .../devicetree/bindings/mfd/gateworks-gsc.yaml     |   5 +-
 .../devicetree/bindings/mfd/google,cros-ec.yaml    | 129 ++++++++++
 .../devicetree/bindings/mfd/khadas,mcu.yaml        |  44 ++++
 .../devicetree/bindings/mfd/st,stm32-lptimer.yaml  |   5 +
 .../devicetree/bindings/mfd/st,stmfx.yaml          | 122 ++++++++++
 Documentation/devicetree/bindings/mfd/stmfx.txt    |  28 ---
 .../bindings/mfd/ti,j721e-system-controller.yaml   |  74 ++++++
 .../devicetree/bindings/mfd/twl-family.txt         |   2 +-
 .../devicetree/bindings/pinctrl/pinctrl-stmfx.txt  | 116 ---------
 Documentation/driver-api/index.rst                 |   1 -
 Documentation/driver-api/smsc_ece1099.rst          |  60 -----
 MAINTAINERS                                        |  41 ++++
 drivers/clocksource/Kconfig                        |   4 +
 drivers/clocksource/Makefile                       |   1 +
 drivers/clocksource/timer-stm32-lp.c               | 221 +++++++++++++++++
 drivers/mfd/Kconfig                                |  33 ++-
 drivers/mfd/Makefile                               |   2 +-
 drivers/mfd/ab3100-core.c                          |   2 +-
 drivers/mfd/ab3100-otp.c                           |  20 +-
 drivers/mfd/ab8500-debugfs.c                       |   2 +-
 drivers/mfd/altera-sysmgr.c                        |  19 +-
 drivers/mfd/arizona-core.c                         |  20 +-
 drivers/mfd/atmel-smc.c                            |   4 +-
 drivers/mfd/axp20x-i2c.c                           |   4 +
 drivers/mfd/cros_ec_dev.c                          |   4 +-
 drivers/mfd/da9063-core.c                          |  31 ---
 drivers/mfd/da9063-i2c.c                           | 271 +++++++++++++++++++--
 drivers/mfd/db8500-prcmu.c                         |   6 +-
 drivers/mfd/dln2.c                                 |   4 +
 drivers/mfd/hi6421-pmic-core.c                     |   2 +-
 drivers/mfd/intel-lpss-pci.c                       |  19 ++
 drivers/mfd/intel_soc_pmic_mrfld.c                 |   7 +-
 drivers/mfd/kempld-core.c                          |  30 +--
 drivers/mfd/khadas-mcu.c                           | 142 +++++++++++
 drivers/mfd/lm3533-ctrlbank.c                      |  94 ++++---
 drivers/mfd/lp873x.c                               |   2 +-
 drivers/mfd/lp87565.c                              |   2 +-
 drivers/mfd/madera-core.c                          |  33 ++-
 drivers/mfd/madera-i2c.c                           |   1 -
 drivers/mfd/max14577.c                             |   2 +-
 drivers/mfd/mfd-core.c                             | 123 +++++++++-
 drivers/mfd/motorola-cpcap.c                       |  23 ++
 drivers/mfd/omap-usb-host.c                        |   6 +-
 drivers/mfd/omap-usb-tll.c                         |   4 +-
 drivers/mfd/rave-sp.c                              |   2 +-
 drivers/mfd/rn5t618.c                              |  46 +++-
 drivers/mfd/si476x-cmd.c                           |  74 +++---
 drivers/mfd/si476x-i2c.c                           |   7 +-
 drivers/mfd/smsc-ece1099.c                         |  87 -------
 drivers/mfd/sprd-sc27xx-spi.c                      |  82 +------
 drivers/mfd/stm32-lptimer.c                        |   1 +
 drivers/mfd/syscon.c                               |   4 +-
 drivers/mfd/tc3589x.c                              |   2 +-
 drivers/mfd/ti_am335x_tscadc.c                     |   2 +-
 drivers/mfd/tps65010.c                             |   5 +-
 drivers/mfd/tps65086.c                             |   2 +-
 drivers/mfd/tps65217.c                             |   6 +-
 drivers/mfd/tps65218.c                             |   6 +-
 drivers/mfd/tps6586x.c                             |   7 +-
 drivers/mfd/tps65912-core.c                        |   2 +-
 drivers/mfd/tps65912-i2c.c                         |   2 +-
 drivers/mfd/tps65912-spi.c                         |   2 +-
 drivers/mfd/twl4030-irq.c                          |   4 +-
 drivers/mfd/wm831x-core.c                          |   4 +
 drivers/mfd/wm8350-core.c                          |   4 +
 drivers/mfd/wm8400-core.c                          |   2 +
 drivers/thermal/Kconfig                            |  11 +
 drivers/thermal/Makefile                           |   1 +
 drivers/thermal/khadas_mcu_fan.c                   | 162 ++++++++++++
 include/linux/mfd/core.h                           |  42 +++-
 include/linux/mfd/da9055/pdata.h                   |   2 +-
 include/linux/mfd/da9063/core.h                    |   1 +
 include/linux/mfd/da9063/registers.h               |  15 +-
 include/linux/mfd/hi6421-pmic.h                    |   2 +-
 include/linux/mfd/khadas-mcu.h                     |  91 +++++++
 include/linux/mfd/lp873x.h                         |   2 +-
 include/linux/mfd/lp87565.h                        |   2 +-
 include/linux/mfd/madera/pdata.h                   |   1 -
 include/linux/mfd/max77693-private.h               |   2 +-
 include/linux/mfd/smsc.h                           | 104 --------
 include/linux/mfd/stm32-lptimer.h                  |   5 +
 include/linux/mfd/ti_am335x_tscadc.h               |   2 +-
 include/linux/mfd/tps65086.h                       |   2 +-
 include/linux/mfd/tps65217.h                       |   2 +-
 include/linux/mfd/tps65218.h                       |   2 +-
 include/linux/mfd/tps65912.h                       |   2 +-
 87 files changed, 1801 insertions(+), 846 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/cros-ec.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/khadas,mcu.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/st,stmfx.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-stmfx.txt
 delete mode 100644 Documentation/driver-api/smsc_ece1099.rst
 create mode 100644 drivers/clocksource/timer-stm32-lp.c
 create mode 100644 drivers/mfd/khadas-mcu.c
 delete mode 100644 drivers/mfd/smsc-ece1099.c
 create mode 100644 drivers/thermal/khadas_mcu_fan.c
 create mode 100644 include/linux/mfd/khadas-mcu.h
 delete mode 100644 include/linux/mfd/smsc.h
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#1 lore raw

Good morning Linus,

[with added [GIT PULL] subject line label this time]

Enjoy!

The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:

Linux 5.8-rc1 (2020-06-14 12:45:04 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git mfd-next-5.9

for you to fetch changes up to ee849ff1fd31f761fc65af04f2649a37e769ceab:

mfd: core: Fix memory leak of 'cell' (2020-08-10 12:27:30 +0100)

----------------------------------------------------------------
- Core Frameworks
- Make better attempt at matching device with the correct OF node
- Allow batch removal of hierarchical sub-devices

- New Drivers
- Add STM32 Clocksource driver
- Add support for Khadas System Control Microcontroller

- Driver Removal
- Remove unused driver for TI's SMSC ECE1099

- New Device Support
- Add support for Intel Emmitsburg PCH to Intel LPSS PCI
- Add support for Intel Tiger Lake PCH-H to Intel LPSS PCI
- Add support for Dialog DA revision to Dialog DA9063

- New Functionality
- Add support for AXP803 to be probed by I2C

- Fix-ups
- Numerous W=1 warning fixes
- Device Tree changes; stm32-lptimer, gateworks-gsc, khadas,mcu, stmfx, cros-ec, j721e-system-controller
- Enabled Regmap 'fast I/O'; stm32-lptimer
- Change BUG_ON to WARN_ON; arizona-core
- Remove superfluous code/initialisation; madera, max14577
- Trivial formatting/spelling issues; madera-core, madera-i2c, da9055, max77693-private
- Switch to of_platform_populate(); sprd-sc27xx-spi
- Expand out set/get brightness/pwm macros; lm3533-ctrlbank
- Disable IRQs on suspend; motorola-cpcap
- Clean-up error handling; intel_soc_pmic_mrfld
- Ensure correct removal order of sub-devices; madera
- Many s/HTTP/HTTPS/ link changes
- Ensure name used with Regmap is unique; syscon

- Bug Fixes
- Properly 'put' clock on unbind and error; arizona-core
- Fix revision handling; da9063
- Fix 'assignment of read-only location' error; kempld-core
- Avoid using the Regmap API when atomic; rn5t618
- Redefine volatile register description; rn5t618
- Use locking to protect event handler; dln2

----------------------------------------------------------------
Adam Thomson (2):
mfd: da9063: Fix revision handling to correctly select reg tables
mfd: da9063: Add support for latest DA silicon revision

Alexander A. Klimov (1):
mfd: Replace HTTP links with HTTPS ones

Andreas Kemnade (2):
mfd: rn5t618: Make restart handler atomic safe
mfd: rn5t618: Fix caching of battery related registers

Andy Shevchenko (3):
mfd: intel-lpss: Add Intel Emmitsburg PCH PCI IDs
mfd: intel-lpss: Add Intel Tiger Lake PCH-H PCI IDs
mfd: dln2: Run event handler loop under spinlock

Benjamin Gaignard (5):
dt-bindings: mfd: Document STM32 low power timer bindings
mfd: stm32: Add defines to be used for clkevent purpose
mfd: stm32: Enable regmap fast_io for stm32-lptimer
clocksource: Add Low Power STM32 timers driver
dt-bindings: mfd: Convert stmfx bindings to json-schema

Charles Keepax (6):
mfd: arizona: Remove BUG_ON usage
mfd: arizona: Ensure 32k clock is put on driver unbind and error
mfd: madera: Remove unused forward declaration of madera_codec_pdata
mfd: madera: Fix minor formatting issues
mfd: mfd-core: Add mechanism for removal of a subset of children
mfd: madera: Improve handling of regulator unbinding

Chunyan Zhang (1):
mfd: sprd: Populate sub-devices defined in DT

Colin Ian King (1):
mfd: max14577: Remove redundant initialization of variable current_bits

Fabio Estevam (2):
dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
dt-bindings: mfd: st,stmfx: Remove I2C unit name

Frank Lee (1):

      mfd: axp20x: Allow the AXP803 to be probed by I2C

Ikjoon Jang (1):
dt-bindings: mfd: Convert ChromeOS EC bindings to json-schema

Johan Hovold (1):
mfd: lm3533: Expand control-bank accessors

Lee Jones (37):
mfd: twl4030-irq: Fix incorrect type in assignment warning
mfd: twl4030-irq: Fix cast to restricted __le32 warning
mfd: tps6586x: Fix cast to restricted __le32 warning
mfd: altera-sysmgr: Fix physical address storing hacks
mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning
mfd: ab3100-core: Fix incompatible types in comparison expression warning
mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue
mfd: tc3589x: Remove invalid use of kerneldoc syntax
mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg
mfd: wm831x-core: Supply description wm831x_reg_{un}lock args
mfd: wm8350-core: Supply description wm8350_reg_{un}lock args
mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()
mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc
mfd: db8500-prcmu: Remove incorrect function header from .probe() function
mfd: omap-usb-host: Remove invalid use of kerneldoc syntax
mfd: omap-usb-host: Provide description for 'pdev' argument to .probe()
mfd: omap-usb-tll: Provide description for 'pdev' argument to .probe()
mfd: atmel-smc: Add missing colon(s) for 'conf' arguments
mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args
mfd: cros_ec_dev: Fix cros_feature_to_{name,cells} struct descriptions
mfd: tps65218: Repair incorrect function argument name 's/tps65218/tps/'
mfd: tps65217: Repair incorrect function argument name 's/tps65217/tps/'
mfd: ab3100-otp: Add missing colon(s) for all documented kerneldoc arguments
mfd: tps65010: Remove delcared and set, but never used variable 'status'
mfd: si476x-cmd: Repair wrongly described function argument 's/response/resp'
mfd: si476x-cmd: Add missing colon(s) for all documented kerneldoc arguments
mfd: si476x-i2c: Add description for si476x_core_fwver_to_revision()'s arg 'func'
mfd: si476x-i2c: Fix spelling mistake in case() statement's FALLTHROUGH comment
mfd: si476x-cmd: Update si476x_cmd_am_rsq_status()'s kerneldoc
mfd: si476x-cmd: Add missing documentation for si476x_cmd_fm_rds_status()'s arg 'report'
mfd: rave-sp: Fix mistake in 'struct rave_sp_deframer's kerneldoc
mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting
mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
mfd: core: Make a best effort attempt to match devices with the correct of_nodes
mfd: core: Fix formatting of MFD helpers
mfd: core: Add OF_MFD_CELL_REG() helper
mfd: core: Fix memory leak of 'cell'

Matti Vaittinen (1):
MAINTAINERS: Add entry for ROHM Power Management ICs

Michael Walle (1):
mfd: smsc-ece1099: Remove driver

Neil Armstrong (4):
dt-bindings: mfd: Add Khadas Microcontroller bindings
mfd: Add support for the Khadas System control Microcontroller
thermal: Add support for the MCU controlled FAN on Khadas boards
MAINTAINERS: Add myself as maintainer for Khadas MCU drivers

Randy Dunlap (2):
mfd: da9055: pdata.h: Drop a duplicated word
mfd: max77693-private: Drop a duplicated word

Roger Quadros (1):
dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller

Stephen Rothwell (1):
mfd: kempld-core: Fix 'assignment of read-only location' error

Suman Anna (1):
mfd: syscon: Use a unique name with regmap_config

Tim Harvey (1):
dt-bindings: mfd: gateworks-gsc: Add 16bit pre-scaled voltage mode

Tony Lindgren (1):
mfd: motorola-cpcap: Disable interrupt for suspend

Xu Wang (1):
mfd: intel_soc_pmic_mrfld: Simplify the return expression of intel_scu_ipc_dev_iowrite8()

 Documentation/devicetree/bindings/mfd/cros-ec.txt  |  76 ------
 .../devicetree/bindings/mfd/gateworks-gsc.yaml     |   5 +-
 .../devicetree/bindings/mfd/google,cros-ec.yaml    | 129 ++++++++++
 .../devicetree/bindings/mfd/khadas,mcu.yaml        |  44 ++++
 .../devicetree/bindings/mfd/st,stm32-lptimer.yaml  |   5 +
 .../devicetree/bindings/mfd/st,stmfx.yaml          | 122 ++++++++++
 Documentation/devicetree/bindings/mfd/stmfx.txt    |  28 ---
 .../bindings/mfd/ti,j721e-system-controller.yaml   |  74 ++++++
 .../devicetree/bindings/mfd/twl-family.txt         |   2 +-
 .../devicetree/bindings/pinctrl/pinctrl-stmfx.txt  | 116 ---------
 Documentation/driver-api/index.rst                 |   1 -
 Documentation/driver-api/smsc_ece1099.rst          |  60 -----
 MAINTAINERS                                        |  41 ++++
 drivers/clocksource/Kconfig                        |   4 +
 drivers/clocksource/Makefile                       |   1 +
 drivers/clocksource/timer-stm32-lp.c               | 221 +++++++++++++++++
 drivers/mfd/Kconfig                                |  33 ++-
 drivers/mfd/Makefile                               |   2 +-
 drivers/mfd/ab3100-core.c                          |   2 +-
 drivers/mfd/ab3100-otp.c                           |  20 +-
 drivers/mfd/ab8500-debugfs.c                       |   2 +-
 drivers/mfd/altera-sysmgr.c                        |  19 +-
 drivers/mfd/arizona-core.c                         |  20 +-
 drivers/mfd/atmel-smc.c                            |   4 +-
 drivers/mfd/axp20x-i2c.c                           |   4 +
 drivers/mfd/cros_ec_dev.c                          |   4 +-
 drivers/mfd/da9063-core.c                          |  31 ---
 drivers/mfd/da9063-i2c.c                           | 271 +++++++++++++++++++--
 drivers/mfd/db8500-prcmu.c                         |   6 +-
 drivers/mfd/dln2.c                                 |   4 +
 drivers/mfd/hi6421-pmic-core.c                     |   2 +-
 drivers/mfd/intel-lpss-pci.c                       |  19 ++
 drivers/mfd/intel_soc_pmic_mrfld.c                 |   7 +-
 drivers/mfd/kempld-core.c                          |  30 +--
 drivers/mfd/khadas-mcu.c                           | 142 +++++++++++
 drivers/mfd/lm3533-ctrlbank.c                      |  94 ++++---
 drivers/mfd/lp873x.c                               |   2 +-
 drivers/mfd/lp87565.c                              |   2 +-
 drivers/mfd/madera-core.c                          |  33 ++-
 drivers/mfd/madera-i2c.c                           |   1 -
 drivers/mfd/max14577.c                             |   2 +-
 drivers/mfd/mfd-core.c                             | 123 +++++++++-
 drivers/mfd/motorola-cpcap.c                       |  23 ++
 drivers/mfd/omap-usb-host.c                        |   6 +-
 drivers/mfd/omap-usb-tll.c                         |   4 +-
 drivers/mfd/rave-sp.c                              |   2 +-
 drivers/mfd/rn5t618.c                              |  46 +++-
 drivers/mfd/si476x-cmd.c                           |  74 +++---
 drivers/mfd/si476x-i2c.c                           |   7 +-
 drivers/mfd/smsc-ece1099.c                         |  87 -------
 drivers/mfd/sprd-sc27xx-spi.c                      |  82 +------
 drivers/mfd/stm32-lptimer.c                        |   1 +
 drivers/mfd/syscon.c                               |   4 +-
 drivers/mfd/tc3589x.c                              |   2 +-
 drivers/mfd/ti_am335x_tscadc.c                     |   2 +-
 drivers/mfd/tps65010.c                             |   5 +-
 drivers/mfd/tps65086.c                             |   2 +-
 drivers/mfd/tps65217.c                             |   6 +-
 drivers/mfd/tps65218.c                             |   6 +-
 drivers/mfd/tps6586x.c                             |   7 +-
 drivers/mfd/tps65912-core.c                        |   2 +-
 drivers/mfd/tps65912-i2c.c                         |   2 +-
 drivers/mfd/tps65912-spi.c                         |   2 +-
 drivers/mfd/twl4030-irq.c                          |   4 +-
 drivers/mfd/wm831x-core.c                          |   4 +
 drivers/mfd/wm8350-core.c                          |   4 +
 drivers/mfd/wm8400-core.c                          |   2 +
 drivers/thermal/Kconfig                            |  11 +
 drivers/thermal/Makefile                           |   1 +
 drivers/thermal/khadas_mcu_fan.c                   | 162 ++++++++++++
 include/linux/mfd/core.h                           |  42 +++-
 include/linux/mfd/da9055/pdata.h                   |   2 +-
 include/linux/mfd/da9063/core.h                    |   1 +
 include/linux/mfd/da9063/registers.h               |  15 +-
 include/linux/mfd/hi6421-pmic.h                    |   2 +-
 include/linux/mfd/khadas-mcu.h                     |  91 +++++++
 include/linux/mfd/lp873x.h                         |   2 +-
 include/linux/mfd/lp87565.h                        |   2 +-
 include/linux/mfd/madera/pdata.h                   |   1 -
 include/linux/mfd/max77693-private.h               |   2 +-
 include/linux/mfd/smsc.h                           | 104 --------
 include/linux/mfd/stm32-lptimer.h                  |   5 +
 include/linux/mfd/ti_am335x_tscadc.h               |   2 +-
 include/linux/mfd/tps65086.h                       |   2 +-
 include/linux/mfd/tps65217.h                       |   2 +-
 include/linux/mfd/tps65218.h                       |   2 +-
 include/linux/mfd/tps65912.h                       |   2 +-
 87 files changed, 1801 insertions(+), 846 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/cros-ec.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/khadas,mcu.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/st,stmfx.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-stmfx.txt
 delete mode 100644 Documentation/driver-api/smsc_ece1099.rst
 create mode 100644 drivers/clocksource/timer-stm32-lp.c
 create mode 100644 drivers/mfd/khadas-mcu.c
 delete mode 100644 drivers/mfd/smsc-ece1099.c
 create mode 100644 drivers/thermal/khadas_mcu_fan.c
 create mode 100644 include/linux/mfd/khadas-mcu.h
 delete mode 100644 include/linux/mfd/smsc.h
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw
In reply to Lee Jones
Quoted 2 lines · Lee Jones

Enjoy!

No.

This causes new compiler warnings.

I pulled, did a basic test-compile, and unpulled.

I refuse to pull garbage that hasn't even seen the most trivial build-test.

And no, "I built it but didn't check for warnings" is not a build test. That's just complete garbage. It's showing the code to the compiler, and not bothering to look at what the compiler said about it.

You can try again next merge window, by now it's too late to send me completely untested garbage and try to fix it up.

Linus

author
#3 lore raw
Quoted 7 lines · Linus Torvalds
Quoted 2 lines · Lee Jones

Enjoy!

No.

This causes new compiler warnings.

Hmm... that's frustrating.

Mea culpa. Apologies for this.

As you know this is unheard of from me.

Quoted 8 lines

I pulled, did a basic test-compile, and unpulled.

I refuse to pull garbage that hasn't even seen the most trivial build-test.

And no, "I built it but didn't check for warnings" is not a build test. That's just complete garbage. It's showing the code to the compiler, and not bothering to look at what the compiler said about it.

Let me give you my 'reason' (I know there is no 'excuse').

I've been grafting on an attempt to rid the kernel of W=1 warnings this cycle. Starting with MFD then working through Backlight, SCSI, Regulator, RemoteProc, IIO, USB, Misc, Pinctrl, GPIO, etc etc, I've managed to extinguish almost 3000 warnings to date. I hope to do something similar this cycle.

Anyway, I forgot to turn W=1 off when testing MFD. I saw that there were a couple of warnings, but I (stupidly) assumed that these were just residue W=1 issues that I would clean-up next cycle. Not realising there were 2 real 'unused variable' problems present.

Quoted 2 lines

You can try again next merge window, by now it's too late to send me completely untested garbage and try to fix it up.

Could I please urge you to reconsider. The branch is well tested (in -next, by private 'kernel test robot' tests and by extensive TuxBuild testing). I have cleaned up the offending line (it was just one line causing the 2 new 'unused variable' issues) and all of my tests are now passing (with W=1 turned off). The branch also extinguishes well over 100 W=1 warnings to boot. It certainly does more good than harm.

If you decide stick with your decision however, I'll also understand.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#4 lore raw

Good evening Linus,

Quoted 11 lines
Quoted 2 lines

You can try again next merge window, by now it's too late to send me completely untested garbage and try to fix it up.

Could I please urge you to reconsider. The branch is well tested (in -next, by private 'kernel test robot' tests and by extensive TuxBuild testing). I have cleaned up the offending line (it was just one line causing the 2 new 'unused variable' issues) and all of my tests are now passing (with W=1 turned off). The branch also extinguishes well over 100 W=1 warnings to boot. It certainly does more good than harm.

Quoted 1 line

If you decide stick with your decision however, I'll also understand.

Here is the new pull request. It has been tested; locally, by TuxBuild and the Intel 'kernel test robot' [0]. Please consider this for addition into v5.9. All of these patches have also soak tested in -next for a considerable amount of time.

[0] https://pastebin.ubuntu.com/p/CjwVcf4Nwd/

The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:

Linux 5.8-rc1 (2020-06-14 12:45:04 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-next-5.9-1

for you to fetch changes up to e15d7f2b81d2e7d93115d46fa931b366c1cdebc2:

mfd: syscon: Use a unique name with regmap_config (2020-08-13 07:51:03 +0100)

----------------------------------------------------------------
- Core Frameworks
- Make better attempt at matching device with the correct OF node
- Allow batch removal of hierarchical sub-devices

- New Drivers
- Add STM32 Clocksource driver
- Add support for Khadas System Control Microcontroller

- Driver Removal
- Remove unused driver for TI's SMSC ECE1099

- New Device Support
- Add support for Intel Emmitsburg PCH to Intel LPSS PCI
- Add support for Intel Tiger Lake PCH-H to Intel LPSS PCI
- Add support for Dialog DA revision to Dialog DA9063

- New Functionality
- Add support for AXP803 to be probed by I2C

- Fix-ups
- Numerous W=1 warning fixes
- Device Tree changes; stm32-lptimer, gateworks-gsc, khadas,mcu, stmfx, cros-ec, j721e-system-controller
- Enabled Regmap 'fast I/O'; stm32-lptimer
- Change BUG_ON to WARN_ON; arizona-core
- Remove superfluous code/initialisation; madera, max14577
- Trivial formatting/spelling issues; madera-core, madera-i2c, da9055, max77693-private
- Switch to of_platform_populate(); sprd-sc27xx-spi
- Expand out set/get brightness/pwm macros; lm3533-ctrlbank
- Disable IRQs on suspend; motorola-cpcap
- Clean-up error handling; intel_soc_pmic_mrfld
- Ensure correct removal order of sub-devices; madera
- Many s/HTTP/HTTPS/ link changes
- Ensure name used with Regmap is unique; syscon

- Bug Fixes
- Properly 'put' clock on unbind and error; arizona-core
- Fix revision handling; da9063
- Fix 'assignment of read-only location' error; kempld-core
- Avoid using the Regmap API when atomic; rn5t618
- Redefine volatile register description; rn5t618
- Use locking to protect event handler; dln2

----------------------------------------------------------------
Adam Thomson (2):
mfd: da9063: Fix revision handling to correctly select reg tables
mfd: da9063: Add support for latest DA silicon revision

Alexander A. Klimov (1):
mfd: Replace HTTP links with HTTPS ones

Andreas Kemnade (2):
mfd: rn5t618: Make restart handler atomic safe
mfd: rn5t618: Fix caching of battery related registers

Andy Shevchenko (3):
mfd: intel-lpss: Add Intel Emmitsburg PCH PCI IDs
mfd: intel-lpss: Add Intel Tiger Lake PCH-H PCI IDs
mfd: dln2: Run event handler loop under spinlock

Benjamin Gaignard (5):
dt-bindings: mfd: Document STM32 low power timer bindings
mfd: stm32: Add defines to be used for clkevent purpose
mfd: stm32: Enable regmap fast_io for stm32-lptimer
clocksource: Add Low Power STM32 timers driver
dt-bindings: mfd: Convert stmfx bindings to json-schema

Charles Keepax (6):
mfd: arizona: Remove BUG_ON usage
mfd: arizona: Ensure 32k clock is put on driver unbind and error
mfd: madera: Remove unused forward declaration of madera_codec_pdata
mfd: madera: Fix minor formatting issues
mfd: mfd-core: Add mechanism for removal of a subset of children
mfd: madera: Improve handling of regulator unbinding

Chunyan Zhang (1):
mfd: sprd: Populate sub-devices defined in DT

Colin Ian King (1):
mfd: max14577: Remove redundant initialization of variable current_bits

Fabio Estevam (2):
dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
dt-bindings: mfd: st,stmfx: Remove I2C unit name

Frank Lee (1):

      mfd: axp20x: Allow the AXP803 to be probed by I2C

Ikjoon Jang (1):
dt-bindings: mfd: Convert ChromeOS EC bindings to json-schema

Johan Hovold (1):
mfd: lm3533: Expand control-bank accessors

Lee Jones (36):
mfd: twl4030-irq: Fix incorrect type in assignment warning
mfd: twl4030-irq: Fix cast to restricted __le32 warning
mfd: tps6586x: Fix cast to restricted __le32 warning
mfd: altera-sysmgr: Fix physical address storing hacks
mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning
mfd: ab3100-core: Fix incompatible types in comparison expression warning
mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue
mfd: tc3589x: Remove invalid use of kerneldoc syntax
mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg
mfd: wm831x-core: Supply description wm831x_reg_{un}lock args
mfd: wm8350-core: Supply description wm8350_reg_{un}lock args
mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()
mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc
mfd: db8500-prcmu: Remove incorrect function header from .probe() function
mfd: omap-usb-host: Remove invalid use of kerneldoc syntax
mfd: omap-usb-host: Provide description for 'pdev' argument to .probe()
mfd: omap-usb-tll: Provide description for 'pdev' argument to .probe()
mfd: atmel-smc: Add missing colon(s) for 'conf' arguments
mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args
mfd: cros_ec_dev: Fix cros_feature_to_{name,cells} struct descriptions
mfd: tps65218: Repair incorrect function argument name 's/tps65218/tps/'
mfd: tps65217: Repair incorrect function argument name 's/tps65217/tps/'
mfd: ab3100-otp: Add missing colon(s) for all documented kerneldoc arguments
mfd: tps65010: Remove delcared and set, but never used variable 'status'
mfd: si476x-cmd: Repair wrongly described function argument 's/response/resp'
mfd: si476x-cmd: Add missing colon(s) for all documented kerneldoc arguments
mfd: si476x-i2c: Add description for si476x_core_fwver_to_revision()'s arg 'func'
mfd: si476x-i2c: Fix spelling mistake in case() statement's FALLTHROUGH comment
mfd: si476x-cmd: Update si476x_cmd_am_rsq_status()'s kerneldoc
mfd: si476x-cmd: Add missing documentation for si476x_cmd_fm_rds_status()'s arg 'report'
mfd: rave-sp: Fix mistake in 'struct rave_sp_deframer's kerneldoc
mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting
mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
mfd: core: Make a best effort attempt to match devices with the correct of_nodes
mfd: core: Fix formatting of MFD helpers
mfd: core: Add OF_MFD_CELL_REG() helper

Matti Vaittinen (1):
MAINTAINERS: Add entry for ROHM Power Management ICs

Michael Walle (1):
mfd: smsc-ece1099: Remove driver

Neil Armstrong (4):
dt-bindings: mfd: Add Khadas Microcontroller bindings
mfd: Add support for the Khadas System control Microcontroller
thermal: Add support for the MCU controlled FAN on Khadas boards
MAINTAINERS: Add myself as maintainer for Khadas MCU drivers

Randy Dunlap (2):
mfd: da9055: pdata.h: Drop a duplicated word
mfd: max77693-private: Drop a duplicated word

Roger Quadros (1):
dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller

Stephen Rothwell (1):
mfd: kempld-core: Fix 'assignment of read-only location' error

Suman Anna (1):
mfd: syscon: Use a unique name with regmap_config

Tim Harvey (1):
dt-bindings: mfd: gateworks-gsc: Add 16bit pre-scaled voltage mode

Tony Lindgren (1):
mfd: motorola-cpcap: Disable interrupt for suspend

Xu Wang (1):
mfd: intel_soc_pmic_mrfld: Simplify the return expression of intel_scu_ipc_dev_iowrite8()

 Documentation/devicetree/bindings/mfd/cros-ec.txt  |  76 ------
 .../devicetree/bindings/mfd/gateworks-gsc.yaml     |   5 +-
 .../devicetree/bindings/mfd/google,cros-ec.yaml    | 129 ++++++++++
 .../devicetree/bindings/mfd/khadas,mcu.yaml        |  44 ++++
 .../devicetree/bindings/mfd/st,stm32-lptimer.yaml  |   5 +
 .../devicetree/bindings/mfd/st,stmfx.yaml          | 122 ++++++++++
 Documentation/devicetree/bindings/mfd/stmfx.txt    |  28 ---
 .../bindings/mfd/ti,j721e-system-controller.yaml   |  74 ++++++
 .../devicetree/bindings/mfd/twl-family.txt         |   2 +-
 .../devicetree/bindings/pinctrl/pinctrl-stmfx.txt  | 116 ---------
 Documentation/driver-api/index.rst                 |   1 -
 Documentation/driver-api/smsc_ece1099.rst          |  60 -----
 MAINTAINERS                                        |  41 ++++
 drivers/clocksource/Kconfig                        |   4 +
 drivers/clocksource/Makefile                       |   1 +
 drivers/clocksource/timer-stm32-lp.c               | 221 +++++++++++++++++
 drivers/mfd/Kconfig                                |  33 ++-
 drivers/mfd/Makefile                               |   2 +-
 drivers/mfd/ab3100-core.c                          |   2 +-
 drivers/mfd/ab3100-otp.c                           |  20 +-
 drivers/mfd/ab8500-debugfs.c                       |   2 +-
 drivers/mfd/altera-sysmgr.c                        |  19 +-
 drivers/mfd/arizona-core.c                         |  20 +-
 drivers/mfd/atmel-smc.c                            |   4 +-
 drivers/mfd/axp20x-i2c.c                           |   4 +
 drivers/mfd/cros_ec_dev.c                          |   4 +-
 drivers/mfd/da9063-core.c                          |  31 ---
 drivers/mfd/da9063-i2c.c                           | 271 +++++++++++++++++++--
 drivers/mfd/db8500-prcmu.c                         |   6 +-
 drivers/mfd/dln2.c                                 |   4 +
 drivers/mfd/hi6421-pmic-core.c                     |   2 +-
 drivers/mfd/intel-lpss-pci.c                       |  19 ++
 drivers/mfd/intel_soc_pmic_mrfld.c                 |   7 +-
 drivers/mfd/kempld-core.c                          |  30 +--
 drivers/mfd/khadas-mcu.c                           | 142 +++++++++++
 drivers/mfd/lm3533-ctrlbank.c                      |  94 ++++---
 drivers/mfd/lp873x.c                               |   2 +-
 drivers/mfd/lp87565.c                              |   2 +-
 drivers/mfd/madera-core.c                          |  33 ++-
 drivers/mfd/madera-i2c.c                           |   1 -
 drivers/mfd/max14577.c                             |   2 +-
 drivers/mfd/mfd-core.c                             | 121 ++++++++-
 drivers/mfd/motorola-cpcap.c                       |  23 ++
 drivers/mfd/omap-usb-host.c                        |   6 +-
 drivers/mfd/omap-usb-tll.c                         |   4 +-
 drivers/mfd/rave-sp.c                              |   2 +-
 drivers/mfd/rn5t618.c                              |  46 +++-
 drivers/mfd/si476x-cmd.c                           |  74 +++---
 drivers/mfd/si476x-i2c.c                           |   7 +-
 drivers/mfd/smsc-ece1099.c                         |  87 -------
 drivers/mfd/sprd-sc27xx-spi.c                      |  82 +------
 drivers/mfd/stm32-lptimer.c                        |   1 +
 drivers/mfd/syscon.c                               |   4 +-
 drivers/mfd/tc3589x.c                              |   2 +-
 drivers/mfd/ti_am335x_tscadc.c                     |   2 +-
 drivers/mfd/tps65010.c                             |   5 +-
 drivers/mfd/tps65086.c                             |   2 +-
 drivers/mfd/tps65217.c                             |   6 +-
 drivers/mfd/tps65218.c                             |   6 +-
 drivers/mfd/tps6586x.c                             |   7 +-
 drivers/mfd/tps65912-core.c                        |   2 +-
 drivers/mfd/tps65912-i2c.c                         |   2 +-
 drivers/mfd/tps65912-spi.c                         |   2 +-
 drivers/mfd/twl4030-irq.c                          |   4 +-
 drivers/mfd/wm831x-core.c                          |   4 +
 drivers/mfd/wm8350-core.c                          |   4 +
 drivers/mfd/wm8400-core.c                          |   2 +
 drivers/thermal/Kconfig                            |  11 +
 drivers/thermal/Makefile                           |   1 +
 drivers/thermal/khadas_mcu_fan.c                   | 162 ++++++++++++
 include/linux/mfd/core.h                           |  42 +++-
 include/linux/mfd/da9055/pdata.h                   |   2 +-
 include/linux/mfd/da9063/core.h                    |   1 +
 include/linux/mfd/da9063/registers.h               |  15 +-
 include/linux/mfd/hi6421-pmic.h                    |   2 +-
 include/linux/mfd/khadas-mcu.h                     |  91 +++++++
 include/linux/mfd/lp873x.h                         |   2 +-
 include/linux/mfd/lp87565.h                        |   2 +-
 include/linux/mfd/madera/pdata.h                   |   1 -
 include/linux/mfd/max77693-private.h               |   2 +-
 include/linux/mfd/smsc.h                           | 104 --------
 include/linux/mfd/stm32-lptimer.h                  |   5 +
 include/linux/mfd/ti_am335x_tscadc.h               |   2 +-
 include/linux/mfd/tps65086.h                       |   2 +-
 include/linux/mfd/tps65217.h                       |   2 +-
 include/linux/mfd/tps65218.h                       |   2 +-
 include/linux/mfd/tps65912.h                       |   2 +-
 87 files changed, 1799 insertions(+), 846 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/cros-ec.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/khadas,mcu.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/st,stmfx.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/stmfx.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-stmfx.txt
 delete mode 100644 Documentation/driver-api/smsc_ece1099.rst
 create mode 100644 drivers/clocksource/timer-stm32-lp.c
 create mode 100644 drivers/mfd/khadas-mcu.c
 delete mode 100644 drivers/mfd/smsc-ece1099.c
 create mode 100644 drivers/thermal/khadas_mcu_fan.c
 create mode 100644 include/linux/mfd/khadas-mcu.h
 delete mode 100644 include/linux/mfd/smsc.h
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw
Quoted 5 lines · Lee Jones

Here is the new pull request. It has been tested; locally, by TuxBuild and the Intel 'kernel test robot' [0]. Please consider this for addition into v5.9. All of these patches have also soak tested in -next for a considerable amount of time.

I'm extremely annoyed by this all, but I've pulled this.

Please just *STOP* doing any W=1 fixes (and most definitely W=2 ones - many of those warnings are just plain garbage and indicate more about the compiler than they do about the code) if you can't then make damn sure that the warnings that actually matter are always *ALWAY* taken care of.

I absolutely abhor warnings in the default build, just because they only result in people ignoring them. Which is exactly what happened bvecause you then tried to care about the more-or-less worthless W=1 ones.

So a clean build is really important to me. And developers who don't check and follow up on warnings in the normal build are something that pisses me off no end.

Now something like 25 commits are pointlessly rebased just because you didn't check warnings properly.

Linus

author
#6 lore raw
Quoted 20 lines · Linus Torvalds
Quoted 5 lines · Lee Jones

Here is the new pull request. It has been tested; locally, by TuxBuild and the Intel 'kernel test robot' [0]. Please consider this for addition into v5.9. All of these patches have also soak tested in -next for a considerable amount of time.

I'm extremely annoyed by this all, but I've pulled this.

Please just *STOP* doing any W=1 fixes (and most definitely W=2 ones - many of those warnings are just plain garbage and indicate more about the compiler than they do about the code) if you can't then make damn sure that the warnings that actually matter are always *ALWAY* taken care of.

I absolutely abhor warnings in the default build, just because they only result in people ignoring them. Which is exactly what happened bvecause you then tried to care about the more-or-less worthless W=1 ones.

Quoted 6 lines

So a clean build is really important to me. And developers who don't check and follow up on warnings in the normal build are something that pisses me off no end.

Now something like 25 commits are pointlessly rebased just because you didn't check warnings properly.

Your point is clear.

Allowing a W=0 warning into my pull-request was a genuine mistake (most of us are only human after all). It will be treated as a learning point, safeguards will be put into place at my end and this situation should not be repeated in the future.

I shall continue with my W=1 push (not going to touch W=2s however). It's understandable that to you W=0s are paramount, but as long as none are introduced then fixing up W=1s can only help to improve the code-base (not withstanding 'type-limits' of course!) and ensure it's more in sync/aligned with itself [thinking API documentation warnings here]).

Thanks for pulling though. It is appreciated.

Apologies again for the fuss.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
merge bot Merged
#7 lore raw
In reply to Lee Jones
The pull request you sent on Fri, 14 Aug 2020 15:42:06 +0100:

The pull request you sent on Fri, 14 Aug 2020 15:42:06 +0100:

Quoted 1 line

git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-next-5.9-1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/884e0d3dd59dde1c1f0fbb5b9db2bcdc581982c7

Thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html