Skip to contentSkip to conversation

ath11k: Add IPQ6018 support

PATCH Superseded Anilkumar Kolli 3 participants 19 messages Aug 24, 2020 – Sep 7, 2020 3 messages not in the archive

Subsystems (3)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v6 cover ath11k: Add IPQ6018 support

IPQ6018 has a 5G radio and 2G radio with 2x2
and shares IPQ8074 configuration.

Tested on: IPQ6018 WLAN.HK.2.2-02134-QCAHKSWPL_SILICONZ-1 Tested on: IPQ8074 WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1

Anilkumar Kolli (3):
dt: bindings: net: update compatible for ath11k
ath11k: copy ce service configs to hw_params
ath11k: add IPQ6018 support

V2:
- Added devicetree reviewers
V3:
- addressed dt bindinds comments
- Reworked on Kalles patches
- copied ce svc configs to hw_params
V4:
- updated dt patch (Rob)
V5:
- Fixes errors in 'make dt_binding_check' (Rob)
V6:
- Rebased on latest ath.git top of tree

 .../bindings/net/wireless/qcom,ath11k.yaml         |   4 +-
 drivers/net/wireless/ath/ath11k/ahb.c              | 125 ++++++++++++++++++++-
 drivers/net/wireless/ath/ath11k/core.c             |  18 ++-
 drivers/net/wireless/ath/ath11k/core.h             |   1 +
 drivers/net/wireless/ath/ath11k/hw.h               |   2 +
 5 files changed, 138 insertions(+), 12 deletions(-)
Signature · 7 lines
2.7.4


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw

PATCH v6 1/3 dt: bindings: net: update compatible for ath11k

Add IPQ6018 wireless driver support,
its based on ath11k driver.

---
V3:
- Use 'enum' rather than oneOf+const.
V4:
- removed oneOf, use just enum (Rob)
V5:
- Fixes errors in 'make dt_binding_check' (Rob)

 Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +3 -1
index a1717db36dba..4b365c9d9378 100644
@@ -17,7 +17,9 @@ description: |
 
 properties:
   compatible:
-    const: qcom,ipq8074-wifi
+    enum:
+      - qcom,ipq8074-wifi
+      - qcom,ipq6018-wifi
 
   reg:
     maxItems: 1
Signature · 7 lines
2.7.4


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
maintainer Reviewed-by on v6 1/3
#2 lore raw

Re: [PATCH v6 1/3] dt: bindings: net: update compatible for ath11k

Quoted 12 lines · Anilkumar Kolli

Add IPQ6018 wireless driver support,
its based on ath11k driver.

---
V3:
- Use 'enum' rather than oneOf+const.
V4:
- removed oneOf, use just enum (Rob)
V5:
- Fixes errors in 'make dt_binding_check' (Rob)

Quoted 3 lines
 Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 3 lines
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#3 lore raw

PATCH v6 2/3 ath11k: copy ce service configs to hw_params

In reply to Anilkumar Kolli

No functional changes, added target ce service configurations to hw_params.

---
V3:
- added ce svc configs in hw_params

 drivers/net/wireless/ath/ath11k/ahb.c  | 14 +++++++++-----
 drivers/net/wireless/ath/ath11k/core.c |  6 ------
 drivers/net/wireless/ath/ath11k/hw.h   |  2 ++
 3 files changed, 11 insertions(+), 11 deletions(-)
drivers/net/wireless/ath/ath11k/ahb.c +9 -5
index 8466c62a83d6..a45a7d62f283 100644
@@ -159,7 +159,7 @@ static const struct ce_pipe_config target_ce_config_wlan[] = {
  * This table is derived from the CE_PCI TABLE, above.
  * It is passed to the Target at startup for use by firmware.
  */
-static const struct service_to_pipe target_service_to_ce_map_wlan[] = {
+static const struct service_to_pipe target_service_to_ce_map_wlan_ipq8074[] = {
 	{
 		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_VO),
 		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
@@ -579,8 +579,8 @@ static void ath11k_ahb_init_qmi_ce_config(struct ath11k_base *ab)
 
 	cfg->tgt_ce_len = ARRAY_SIZE(target_ce_config_wlan) - 1;
 	cfg->tgt_ce = target_ce_config_wlan;
-	cfg->svc_to_ce_map_len = ARRAY_SIZE(target_service_to_ce_map_wlan);
-	cfg->svc_to_ce_map = target_service_to_ce_map_wlan;
+	cfg->svc_to_ce_map_len = ab->hw_params.svc_to_ce_map_len;
+	cfg->svc_to_ce_map = ab->hw_params.svc_to_ce_map;
 	ab->qmi.service_ins_id = ATH11K_QMI_WLFW_SERVICE_INS_ID_V01_IPQ8074;
 }
 
@@ -789,8 +789,8 @@ static int ath11k_ahb_map_service_to_pipe(struct ath11k_base *ab, u16 service_id
 	bool ul_set = false, dl_set = false;
 	int i;
 
-	for (i = 0; i < ARRAY_SIZE(target_service_to_ce_map_wlan); i++) {
-		entry = &target_service_to_ce_map_wlan[i];
+	for (i = 0; i < ab->hw_params.svc_to_ce_map_len; i++) {
+		entry = &ab->hw_params.svc_to_ce_map[i];
 
 		if (__le32_to_cpu(entry->service_id) != service_id)
 			continue;
@@ -890,6 +890,10 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
 		goto err_hal_srng_deinit;
 	}
 
+	ab->hw_params.svc_to_ce_map_len =
+			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
+	ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+
 	ath11k_ahb_init_qmi_ce_config(ab);
 
 	ret = ath11k_core_init(ab);
drivers/net/wireless/ath/ath11k/core.c +0 -6
index 437b1123a34f..61a6f395c436 100644
@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}
-
 	ret = ath11k_core_soc_create(ab);
 	if (ret) {
 		ath11k_err(ab, "failed to create soc core: %d\n", ret);
drivers/net/wireless/ath/ath11k/hw.h +2 -0
index d15fa7fd6d5d..ebe691cb4a13 100644
@@ -129,6 +129,8 @@ struct ath11k_hw_params {
 	} fw;
 
 	const struct ath11k_hw_ops *hw_ops;
+	const struct service_to_pipe *svc_to_ce_map;
+	int svc_to_ce_map_len;
 
 	const struct ath11k_hw_ring_mask *ring_mask;
 
Signature · 7 lines
2.7.4


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#4 lore raw

Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params

Quoted 3 lines · Anilkumar Kolli

No functional changes, added target ce service configurations to hw_params.

[...]

drivers/net/wireless/ath/ath11k/core.c int ath11k_core_init(struct ath11k_base *ab) · line 819

Quoted 11 lines
drivers/net/wireless/ath/ath11k/core.c +0 -5
@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}

This is very suspicious.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#5 lore raw

Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params

In reply to Anilkumar Kolli
Quoted 3 lines · Anilkumar Kolli

No functional changes, added target ce service configurations to hw_params.

[...]

drivers/net/wireless/ath/ath11k/core.c int ath11k_core_init(struct ath11k_base *ab) · line 819

Quoted 11 lines
drivers/net/wireless/ath/ath11k/core.c +0 -5
@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}

This is very suspicious.

Signature · 6 lines
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw

Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params

Quoted 14 lines · Kalle Valo
Quoted 3 lines · Anilkumar Kolli

No functional changes, added target ce service configurations to hw_params.

[...]

Quoted 6 lines
drivers/net/wireless/ath/ath11k/core.c +0 -0
@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
Quoted 7 lines

drivers/net/wireless/ath/ath11k/core.c int ath11k_core_init(struct ath11k_base *ab) · line 819

Quoted 5 lines
drivers/net/wireless/ath/ath11k/core.c +0 -5
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}

This is very suspicious.

ath11k_core_pre_init() is calling ath11k_init_hw_params(), again calling same function in ath11k_core_init() is not needed. Will send this as a new patch ?

Thanks
Anil

Signature · 3 lines
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#8 lore raw

Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params

Quoted 24 lines · [email protected] writes:
Quoted 15 lines · Kalle Valo
Quoted 4 lines · Anilkumar Kolli

No functional changes, added target ce service configurations to hw_params.

[...]

Quoted 6 lines
drivers/net/wireless/ath/ath11k/core.c +0 -0
@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
Quoted 7 lines

drivers/net/wireless/ath/ath11k/core.c int ath11k_core_init(struct ath11k_base *ab) · line 819

Quoted 5 lines
drivers/net/wireless/ath/ath11k/core.c +0 -5
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}

This is very suspicious.

Quoted 4 lines

ath11k_core_pre_init() is calling ath11k_init_hw_params(), again calling same function in ath11k_core_init() is not needed.

Will send this as a new patch ?

Yes, please send this in a new patch with a proper commit log explaining the situation.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#9 lore raw

Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params

In reply to [email protected]
Quoted 24 lines · [email protected] writes:
Quoted 15 lines · Kalle Valo
Quoted 4 lines · Anilkumar Kolli

No functional changes, added target ce service configurations to hw_params.

[...]

Quoted 6 lines
drivers/net/wireless/ath/ath11k/core.c +0 -0
@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
Quoted 7 lines

drivers/net/wireless/ath/ath11k/core.c int ath11k_core_init(struct ath11k_base *ab) · line 819

Quoted 5 lines
drivers/net/wireless/ath/ath11k/core.c +0 -5
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}

This is very suspicious.

Quoted 4 lines

ath11k_core_pre_init() is calling ath11k_init_hw_params(), again calling same function in ath11k_core_init() is not needed.

Will send this as a new patch ?

Yes, please send this in a new patch with a proper commit log explaining the situation.

Signature · 6 lines
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#10 lore raw

Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params

In reply to a message not in the archive
Quoted 14 lines · Kalle Valo
Quoted 3 lines · Anilkumar Kolli

No functional changes, added target ce service configurations to hw_params.

[...]

Quoted 6 lines
drivers/net/wireless/ath/ath11k/core.c +0 -0
@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
Quoted 7 lines

drivers/net/wireless/ath/ath11k/core.c int ath11k_core_init(struct ath11k_base *ab) · line 819

Quoted 5 lines
drivers/net/wireless/ath/ath11k/core.c +0 -5
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}

This is very suspicious.

ath11k_core_pre_init() is calling ath11k_init_hw_params(), again calling same function in ath11k_core_init() is not needed. Will send this as a new patch ?

Thanks
Anil

#11 lore raw

PATCH v6 3/3 ath11k: add IPQ6018 support

In reply to Anilkumar Kolli

IPQ6018 has one 5G and one 2G radio with 2x2,
shares ipq8074 configurations.

---
 drivers/net/wireless/ath/ath11k/ahb.c  | 115 ++++++++++++++++++++++++++++++++-
 drivers/net/wireless/ath/ath11k/core.c |  12 ++++
 drivers/net/wireless/ath/ath11k/core.h |   1 +
 3 files changed, 126 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/ahb.c +113 -2
index a45a7d62f283..f9e1c4001015 100644
@@ -20,6 +20,9 @@ static const struct of_device_id ath11k_ahb_of_match[] = {
 	{ .compatible = "qcom,ipq8074-wifi",
 	  .data = (void *)ATH11K_HW_IPQ8074,
 	},
+	{ .compatible = "qcom,ipq6018-wifi",
+	  .data = (void *)ATH11K_HW_IPQ6018,
+	},
 	{ }
 };
 
@@ -271,6 +274,108 @@ static const struct service_to_pipe target_service_to_ce_map_wlan_ipq8074[] = {
 	{ /* terminator entry */ }
 };
 
+static const struct service_to_pipe target_service_to_ce_map_wlan_ipq6018[] = {
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_VO),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(3),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_VO),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(2),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_BK),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(3),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_BK),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(2),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_BE),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(3),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_BE),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(2),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_VI),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(3),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_DATA_VI),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(2),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_CONTROL),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(3),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_CONTROL),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(2),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC1),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(7),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC1),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(2),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_RSVD_CTRL),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(0),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_RSVD_CTRL),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(1),
+	},
+	{ /* not used */
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_TEST_RAW_STREAMS),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(0),
+	},
+	{ /* not used */
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_TEST_RAW_STREAMS),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(1),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_HTT_DATA_MSG),
+		.pipedir = __cpu_to_le32(PIPEDIR_OUT),	/* out = UL = host -> target */
+		.pipenum = __cpu_to_le32(4),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_HTT_DATA_MSG),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(1),
+	},
+	{
+		.service_id = __cpu_to_le32(ATH11K_HTC_SVC_ID_PKT_LOG),
+		.pipedir = __cpu_to_le32(PIPEDIR_IN),	/* in = DL = target -> host */
+		.pipenum = __cpu_to_le32(5),
+	},
+
+	/* (Additions here) */
+
+	{ /* terminator entry */ }
+};
+
 #define ATH11K_IRQ_CE0_OFFSET 4
 
 static const char *irq_name[ATH11K_IRQ_NUM_MAX] = {
@@ -890,9 +995,15 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
 		goto err_hal_srng_deinit;
 	}
 
-	ab->hw_params.svc_to_ce_map_len =
+	if (ab->hw_rev == ATH11K_HW_IPQ8074) {
+		ab->hw_params.svc_to_ce_map_len =
 			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
-	ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+		ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+	} else if (ab->hw_rev == ATH11K_HW_IPQ6018) {
+		ab->hw_params.svc_to_ce_map_len =
+			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq6018);
+		ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq6018;
+	}
 
 	ath11k_ahb_init_qmi_ce_config(ab);
 
drivers/net/wireless/ath/ath11k/core.c +12 -0
index 61a6f395c436..d7b015ea40c2 100644
@@ -69,6 +69,18 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
 		.htt_peer_map_v2 = false,
 		.tcl_0_only = true,
 	},
+	{
+		.hw_rev = ATH11K_HW_IPQ6018,
+		.name = "ipq6018 hw1.0",
+		.fw = {
+			.dir = "IPQ6018/hw1.0",
+			.board_size = 256 * 1024,
+			.cal_size = 256 * 1024,
+		},
+		.max_radios = 2,
+		.bdf_addr = 0x4ABC0000,
+		.hw_ops = &ipq6018_ops,
+	},
 };
 
 static int ath11k_core_create_board_name(struct ath11k_base *ab, char *name,
drivers/net/wireless/ath/ath11k/core.h +1 -0
index d21191c51e10..b9b6dc6f179f 100644
@@ -90,6 +90,7 @@ struct ath11k_skb_rxcb {
 
 enum ath11k_hw_rev {
 	ATH11K_HW_IPQ8074,
+	ATH11K_HW_IPQ6018,
 	ATH11K_HW_QCA6390_HW20,
 };
 
Signature · 7 lines
2.7.4


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#12 lore raw

Re: [PATCH v6 3/3] ath11k: add IPQ6018 support

Quoted 4 lines · Anilkumar Kolli

IPQ6018 has one 5G and one 2G radio with 2x2,
shares ipq8074 configurations.

[...]

Quoted 5 lines
drivers/net/wireless/ath/ath11k/ahb.c +0 -1
@@ -890,9 +995,15 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
 		goto err_hal_srng_deinit;
 	}
 
-	ab->hw_params.svc_to_ce_map_len =

drivers/net/wireless/ath/ath11k/ahb.c static int ath11k_ahb_probe(struct platform_device *pdev) · line 1006

Quoted 10 lines
drivers/net/wireless/ath/ath11k/ahb.c +8 -1
+	if (ab->hw_rev == ATH11K_HW_IPQ8074) {
+		ab->hw_params.svc_to_ce_map_len =
 			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
-	ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+		ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+	} else if (ab->hw_rev == ATH11K_HW_IPQ6018) {
+		ab->hw_params.svc_to_ce_map_len =
+			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq6018);
+		ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq6018;
+	}

The idea of having ab->hw_params is to avoid the need for hw_rev sprinkled all over the code, this here defeats the purpose. I recommend checking if my proposal from an earlier version is implementable:

"You could copy the map arrays to hw.c, as an example see how
ath11k_hw_ring_mask_ipq8074 is implemented. That way we don't need any new hw_rev checks."

Signature · 6 lines
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#13 lore raw

Re: [PATCH v6 3/3] ath11k: add IPQ6018 support

In reply to Anilkumar Kolli
Quoted 4 lines · Anilkumar Kolli

IPQ6018 has one 5G and one 2G radio with 2x2,
shares ipq8074 configurations.

[...]

Quoted 5 lines
drivers/net/wireless/ath/ath11k/ahb.c +0 -1
@@ -890,9 +995,15 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
 		goto err_hal_srng_deinit;
 	}
 
-	ab->hw_params.svc_to_ce_map_len =

drivers/net/wireless/ath/ath11k/ahb.c static int ath11k_ahb_probe(struct platform_device *pdev) · line 1006

Quoted 10 lines
drivers/net/wireless/ath/ath11k/ahb.c +8 -1
+	if (ab->hw_rev == ATH11K_HW_IPQ8074) {
+		ab->hw_params.svc_to_ce_map_len =
 			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
-	ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+		ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+	} else if (ab->hw_rev == ATH11K_HW_IPQ6018) {
+		ab->hw_params.svc_to_ce_map_len =
+			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq6018);
+		ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq6018;
+	}

The idea of having ab->hw_params is to avoid the need for hw_rev sprinkled all over the code, this here defeats the purpose. I recommend checking if my proposal from an earlier version is implementable:

"You could copy the map arrays to hw.c, as an example see how
ath11k_hw_ring_mask_ipq8074 is implemented. That way we don't need any new hw_rev checks."

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

A message that is not in the archive (sent off-list or not yet received): [email protected]

#15 lore raw

Re: [PATCH v6 3/3] ath11k: add IPQ6018 support

Quoted 32 lines · Kalle Valo
Quoted 4 lines · Anilkumar Kolli

IPQ6018 has one 5G and one 2G radio with 2x2,
shares ipq8074 configurations.

[...]

Quoted 8 lines
drivers/net/wireless/ath/ath11k/ahb.c +2 -1
@@ -890,9 +995,15 @@ static int ath11k_ahb_probe(struct 
 platform_device *pdev)
 		goto err_hal_srng_deinit;
 	}
 
-	ab->hw_params.svc_to_ce_map_len =
+	if (ab->hw_rev == ATH11K_HW_IPQ8074) {
+		ab->hw_params.svc_to_ce_map_len =

drivers/net/wireless/ath/ath11k/ahb.c static int ath11k_ahb_probe(struct · line 1009

Quoted 10 lines
drivers/net/wireless/ath/ath11k/ahb.c +6 -1
 			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
-	ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+		ab->hw_params.svc_to_ce_map = 
 target_service_to_ce_map_wlan_ipq8074;
+	} else if (ab->hw_rev == ATH11K_HW_IPQ6018) {
+		ab->hw_params.svc_to_ce_map_len =
+			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq6018);
+		ab->hw_params.svc_to_ce_map = 
 target_service_to_ce_map_wlan_ipq6018;
+	}

The idea of having ab->hw_params is to avoid the need for hw_rev sprinkled all over the code, this here defeats the purpose. I recommend checking if my proposal from an earlier version is implementable:

Quoted 3 lines

"You could copy the map arrays to hw.c, as an example see how
ath11k_hw_ring_mask_ipq8074 is implemented. That way we don't need any new hw_rev checks."

Thanks for the details, will address and send in next patch set.

Thanks
Anil

Signature · 3 lines
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#16 lore raw

Re: [PATCH v6 3/3] ath11k: add IPQ6018 support

In reply to a message not in the archive
Quoted 32 lines · Kalle Valo
Quoted 4 lines · Anilkumar Kolli

IPQ6018 has one 5G and one 2G radio with 2x2,
shares ipq8074 configurations.

[...]

Quoted 8 lines
drivers/net/wireless/ath/ath11k/ahb.c +2 -1
@@ -890,9 +995,15 @@ static int ath11k_ahb_probe(struct 
 platform_device *pdev)
 		goto err_hal_srng_deinit;
 	}
 
-	ab->hw_params.svc_to_ce_map_len =
+	if (ab->hw_rev == ATH11K_HW_IPQ8074) {
+		ab->hw_params.svc_to_ce_map_len =

drivers/net/wireless/ath/ath11k/ahb.c static int ath11k_ahb_probe(struct · line 1009

Quoted 10 lines
drivers/net/wireless/ath/ath11k/ahb.c +6 -1
 			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
-	ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
+		ab->hw_params.svc_to_ce_map = 
 target_service_to_ce_map_wlan_ipq8074;
+	} else if (ab->hw_rev == ATH11K_HW_IPQ6018) {
+		ab->hw_params.svc_to_ce_map_len =
+			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq6018);
+		ab->hw_params.svc_to_ce_map = 
 target_service_to_ce_map_wlan_ipq6018;
+	}

The idea of having ab->hw_params is to avoid the need for hw_rev sprinkled all over the code, this here defeats the purpose. I recommend checking if my proposal from an earlier version is implementable:

Quoted 3 lines

"You could copy the map arrays to hw.c, as an example see how
ath11k_hw_ring_mask_ipq8074 is implemented. That way we don't need any new hw_rev checks."

Thanks for the details, will address and send in next patch set.

Thanks
Anil

#17 lore raw
In reply to Anilkumar Kolli
Quoted 5 lines · Anilkumar Kolli

IPQ6018 has a 5G radio and 2G radio with 2x2
and shares IPQ8074 configuration.

Tested on: IPQ6018 WLAN.HK.2.2-02134-QCAHKSWPL_SILICONZ-1 Tested on: IPQ8074 WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1

I don't store the cover letters to git, so please move the Tested-on tags to actual patches so that they are properly archived.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#18 lore raw
In reply to Anilkumar Kolli
Quoted 5 lines · Anilkumar Kolli

IPQ6018 has a 5G radio and 2G radio with 2x2
and shares IPQ8074 configuration.

Tested on: IPQ6018 WLAN.HK.2.2-02134-QCAHKSWPL_SILICONZ-1 Tested on: IPQ8074 WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1

I don't store the cover letters to git, so please move the Tested-on tags to actual patches so that they are properly archived.

Signature · 6 lines
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k

A message that is not in the archive (sent off-list or not yet received): [email protected]

#20 lore raw
Quoted 10 lines · Kalle Valo
Quoted 5 lines · Anilkumar Kolli

IPQ6018 has a 5G radio and 2G radio with 2x2
and shares IPQ8074 configuration.

Tested on: IPQ6018 WLAN.HK.2.2-02134-QCAHKSWPL_SILICONZ-1 Tested on: IPQ8074 WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1

I don't store the cover letters to git, so please move the Tested-on tags to actual patches so that they are properly archived.

Sure.

Thanks
Anil

Signature · 3 lines
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#21 lore raw
In reply to a message not in the archive
Quoted 10 lines · Kalle Valo
Quoted 5 lines · Anilkumar Kolli

IPQ6018 has a 5G radio and 2G radio with 2x2
and shares IPQ8074 configuration.

Tested on: IPQ6018 WLAN.HK.2.2-02134-QCAHKSWPL_SILICONZ-1 Tested on: IPQ8074 WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1

I don't store the cover letters to git, so please move the Tested-on tags to actual patches so that they are properly archived.

Sure.

Thanks
Anil