Skip to contentSkip to conversation

serial: qcom_geni_serial: To correct QUP Version detection logic

PATCH In review Paras Sharma 2 participants 3 messages Sep 2, 2020 – Sep 10, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: qcom_geni_serial: To correct QUP Version detection logic

The current implementation reduces the sampling rate by half if qup HW version is greater is than 2.5 by checking if the geni SE major version is greater than 2 and geni SE minor version is greater than 5.

This implementation fails when the version is 3 or greater.

Hence new implementation checks if version is greater than or equal to 0x20050000 which would work for any future version.

---
 drivers/tty/serial/qcom_geni_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/qcom_geni_serial.c +1 -1
index f0b1b47..e18b431 100644
@@ -1000,7 +1000,7 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
 	sampling_rate = UART_OVERSAMPLING;
 	/* Sampling rate is halved for IP versions >= 2.5 */
 	ver = geni_se_get_qup_hw_version(&port->se);
-	if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+	if (ver >= 0x20050000)
 		sampling_rate /= 2;
 
 	clk_rate = get_clk_div_rate(baud, sampling_rate, &clk_div);
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw
Quoted 7 lines · Paras Sharma

The current implementation reduces the sampling rate by half if qup HW version is greater is than 2.5 by checking if the geni SE major version is greater than 2 and geni SE minor version is greater than 5.

This implementation fails when the version is 3 or greater.

Quoted 7 lines

Hence new implementation checks if version is greater than or equal to 0x20050000 which would work for any future version.

---
 drivers/tty/serial/qcom_geni_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Is this a v2 patch? What changed from the first one?

drivers/tty/serial/qcom_geni_serial.c static void qcom_geni_serial_set_termios(struct uart_port *uport, · line 1003

Quoted 11 lines
drivers/tty/serial/qcom_geni_serial.c +1 -1
index f0b1b47..e18b431 100644
@@ -1000,7 +1000,7 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
 	sampling_rate = UART_OVERSAMPLING;
 	/* Sampling rate is halved for IP versions >= 2.5 */
 	ver = geni_se_get_qup_hw_version(&port->se);
-	if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+	if (ver >= 0x20050000)

That's an odd "magic value", can't you use the existing macros to define this somehow so it makes sense?

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Paras Sharma

The current implementation reduces the sampling rate by half if qup HW version is greater is than 2.5 by checking if the geni SE major version is greater than 2 and geni SE minor version is greater than 5.

This implementation fails when the version is 3 or greater.

Hence new implementation checks if version is greater than or equal to 0x20050000 which would work for any future version.

Quoted 6 lines
Quoted 4 lines
---
 drivers/tty/serial/qcom_geni_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Is this a v2 patch? What changed from the first one?

This patch is in continuation of https://patchwork.kernel.org/patch/11708805/ .
It should have been V3 , i will correct it in my next patch .
In the previous version ,i had added a new condition to separately check if QUP se major version is greater than or equal to 3. In this ,i replaced the older logic of separately checking major and minor versions for 2.5 and 3 with value of Qup version 0x20050000 . This checks for version greater than 2.5 directly.
This would reduce the logic and will work for any future versions.

Quoted 17 lines
Quoted 7 lines
drivers/tty/serial/qcom_geni_serial.c +0 -0
index f0b1b47..e18b431 100644

drivers/tty/serial/qcom_geni_serial.c static void qcom_geni_serial_set_termios(struct · line 1005

Quoted 7 lines
drivers/tty/serial/qcom_geni_serial.c +1 -1
@@ -1000,7 +1000,7 @@ static void qcom_geni_serial_set_termios(struct 
 uart_port *uport,
 	sampling_rate = UART_OVERSAMPLING;
 	/* Sampling rate is halved for IP versions >= 2.5 */
 	ver = geni_se_get_qup_hw_version(&port->se);
-	if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 
 5)
+	if (ver >= 0x20050000)

That's an odd "magic value", can't you use the existing macros to define this somehow so it makes sense?

The stable tag is not required because the board supporting version > 3 is not in any of the previous kernel versions. I will define a separate macro for this value in my next patch.

Quoted 4 lines

thanks,

greg k-h