vdpa/mlx5: fix completion queue assertion
Subsystems (2)
PATCH 1/1 vdpa/mlx5: fix completion queue assertion
The CQ configuration enables the collapse feature in HW what cause HW to write all the completions in the first CQE.
When this feature is enabled the HW doesn't switch the owner bit when it starts a new cycle of the CQ, not like working without the collapse feature.
The current SW CQ polling wrongly added an assertion to validate the owner bit switch what causes a panic in debug mode.
Remove the aforementioned assertion.
--- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 -- 1 file changed, 2 deletions(-)
drivers/vdpa/mlx5/mlx5_vdpa_event.c +0 -2
@@ -205,8 +205,6 @@ comp = (cur_wqe_counter +1u - next_wqe_counter) & cq_mask;if (comp) { cq->cq_ci += comp; -MLX5_ASSERT (!!(cq->cq_ci & cq_size) == -MLX5_CQE_OWNER (last_word.op_own));MLX5_ASSERT (MLX5_CQE_OPCODE (last_word.op_own) !=MLX5_CQE_INVALID ); if (unlikely(!(MLX5_CQE_OPCODE(last_word.op_own) ==
Signature · 1 line
1.8.3.1
Quoted 26 lines · Matan Azrad
The CQ configuration enables the collapse feature in HW what cause HW to write all the completions in the first CQE.
When this feature is enabled the HW doesn't switch the owner bit when it starts a new cycle of the CQ, not like working without the collapse feature.The current SW CQ polling wrongly added an assertion to validate the owner bit switch what causes a panic in debug mode.
Remove the aforementioned assertion.
Fixes c5f714e50b0e ("vdpa/mlx5: optimize completion queue poll")Signed-off-by Matan Azrad <[email protected]>Acked-by Xueming Li <[email protected]>--- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 -- 1 file changed, 2 deletions(-)drivers/vdpa/mlx5/mlx5_vdpa_event.c +0
-0
drivers/vdpa/mlx5/mlx5_vdpa_event.c line 210
Quoted 8 lines
drivers/vdpa/mlx5/mlx5_vdpa_event.c +0
-2@@ -205,8 +205,6 @@ comp = (cur_wqe_counter +1u - next_wqe_counter) & cq_mask;if (comp) { cq->cq_ci += comp; -MLX5_ASSERT (!!(cq->cq_ci & cq_size) == -MLX5_CQE_OWNER (last_word.op_own));MLX5_ASSERT (MLX5_CQE_OPCODE (last_word.op_own) !=MLX5_CQE_INVALID ); if (unlikely(!(MLX5_CQE_OPCODE(last_word.op_own) ==
Thanks,
Maxime
Maxime Coquelin
AppliedQuoted 11 lines · Matan Azrad
The CQ configuration enables the collapse feature in HW what cause HW to write all the completions in the first CQE.
When this feature is enabled the HW doesn't switch the owner bit when it starts a new cycle of the CQ, not like working without the collapse feature.The current SW CQ polling wrongly added an assertion to validate the owner bit switch what causes a panic in debug mode.
Remove the aforementioned assertion.
Quoted 8 lines
Fixes c5f714e50b0e ("vdpa/mlx5: optimize completion queue poll")Signed-off-by Matan Azrad <[email protected]>Acked-by Xueming Li <[email protected]>--- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 -- 1 file changed, 2 deletions(-)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime