Skip to contentSkip to conversation

Remove MT6779 UART3 clock support

PATCH In review Hanks Chen 2 participants 11 messages Jul 22, 2020 – Sep 25, 2020

Subsystems (4)
lore
Share & tools
lore

Hanks Chen

author
#0 lore raw

v2 cover Remove MT6779 UART3 clock support

remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support" -- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support" -- remove Fixes tag

Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support

 drivers/clk/mediatek/clk-mt6779.c      | 2 --
 include/dt-bindings/clock/mt6779-clk.h | 1 -
 2 files changed, 3 deletions(-)
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH v2 1/2 dt-bindings: clock: remove UART3 clock support

remove the redundant clk interface of uart.

---
 include/dt-bindings/clock/mt6779-clk.h | 1 -
 1 file changed, 1 deletion(-)
include/dt-bindings/clock/mt6779-clk.h +0 -1
index b083139afbd2..2b5f2354d7eb 100644
@@ -229,7 +229,6 @@
 #define CLK_INFRA_UART0			21
 #define CLK_INFRA_UART1			22
 #define CLK_INFRA_UART2			23
-#define CLK_INFRA_UART3			24
 #define CLK_INFRA_GCE_26M		25
 #define CLK_INFRA_CQ_DMA_FPC		26
 #define CLK_INFRA_BTIF			27
Signature · 1 line
2.18.0
maintainer Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: clock: remove UART3 clock support

Quoted 3 lines · Hanks Chen

remove the redundant clk interface of uart.

Quoted 17 lines
---
  include/dt-bindings/clock/mt6779-clk.h | 1 -
  1 file changed, 1 deletion(-)
include/dt-bindings/clock/mt6779-clk.h +0 -1
index b083139afbd2..2b5f2354d7eb 100644
@@ -229,7 +229,6 @@
  #define CLK_INFRA_UART0			21
  #define CLK_INFRA_UART1			22
  #define CLK_INFRA_UART2			23
-#define CLK_INFRA_UART3			24
  #define CLK_INFRA_GCE_26M		25
  #define CLK_INFRA_CQ_DMA_FPC		26
  #define CLK_INFRA_BTIF			27
author
#3 lore raw

PATCH v2 2/2 clk: mediatek: remove UART3 clock support

In reply to Hanks Chen

CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

---
 drivers/clk/mediatek/clk-mt6779.c | 2 --
 1 file changed, 2 deletions(-)
drivers/clk/mediatek/clk-mt6779.c +0 -2
index 9766cccf5844..75f2235486be 100644
@@ -923,8 +923,6 @@ static const struct mtk_gate infra_clks[] = {
 		    "uart_sel", 23),
 	GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",
 		    "uart_sel", 24),
-	GATE_INFRA0(CLK_INFRA_UART3, "infra_uart3",
-		    "uart_sel", 25),
 	GATE_INFRA0(CLK_INFRA_GCE_26M, "infra_gce_26m",
 		    "axi_sel", 27),
 	GATE_INFRA0(CLK_INFRA_CQ_DMA_FPC, "infra_cqdma_fpc",
Signature · 1 line
2.18.0
maintainer Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] clk: mediatek: remove UART3 clock support

Quoted 4 lines · Hanks Chen

CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Quoted 18 lines
---
  drivers/clk/mediatek/clk-mt6779.c | 2 --
  1 file changed, 2 deletions(-)
drivers/clk/mediatek/clk-mt6779.c +0 -2
index 9766cccf5844..75f2235486be 100644
@@ -923,8 +923,6 @@ static const struct mtk_gate infra_clks[] = {
  		    "uart_sel", 23),
  	GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",
  		    "uart_sel", 24),
-	GATE_INFRA0(CLK_INFRA_UART3, "infra_uart3",
-		    "uart_sel", 25),
  	GATE_INFRA0(CLK_INFRA_GCE_26M, "infra_gce_26m",
  		    "axi_sel", 27),
  	GATE_INFRA0(CLK_INFRA_CQ_DMA_FPC, "infra_cqdma_fpc",
maintainer
#5 lore raw
In reply to Hanks Chen
Quoted 6 lines · Hanks Chen

remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"

Sorry just another comment. I think we can make this one patch deleting everything.

Quoted 12 lines

-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support" -- remove Fixes tag

Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support

  drivers/clk/mediatek/clk-mt6779.c      | 2 --
  include/dt-bindings/clock/mt6779-clk.h | 1 -
  2 files changed, 3 deletions(-)
author
#6 lore raw
Quoted 11 lines · Matthias Brugger
Quoted 6 lines · Hanks Chen

remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"

Sorry just another comment. I think we can make this one patch deleting everything.

Sorry, I don't understand the comment. Do I need to merge them into one big patch?
Btw, if I use one patch, I would get check patch fail.
---
[2020-07-22 19:12:49,046 ERROR] Run check patch results:
WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
---

Hanks

Quoted 12 lines
Quoted 12 lines

-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support" -- remove Fixes tag

Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support

  drivers/clk/mediatek/clk-mt6779.c      | 2 --
  include/dt-bindings/clock/mt6779-clk.h | 1 -
  2 files changed, 3 deletions(-)
maintainer
#7 lore raw
Quoted 12 lines · Hanks Chen
Quoted 11 lines · Matthias Brugger
Quoted 6 lines · Hanks Chen

remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"

Sorry just another comment. I think we can make this one patch deleting everything.

Quoted 9 lines

Sorry, I don't understand the comment. Do I need to merge them into one big patch?
Btw, if I use one patch, I would get check patch fail.
---
[2020-07-22 19:12:49,046 ERROR] Run check patch results:
WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
---

Hm, I think that's a debatable error message from checkpatch, but let's leave it as it is.

Regards,
Matthias

Quoted 16 lines

Hanks

Quoted 12 lines
Quoted 12 lines

-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support" -- remove Fixes tag

Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support

   drivers/clk/mediatek/clk-mt6779.c      | 2 --
   include/dt-bindings/clock/mt6779-clk.h | 1 -
   2 files changed, 3 deletions(-)
author
#8 lore raw

Hi all,

Gentle ping on this patch.

Thanks!

Hanks Chen

Quoted 47 lines · Matthias Brugger
Quoted 12 lines · Hanks Chen
Quoted 11 lines · Matthias Brugger
Quoted 6 lines · Hanks Chen

remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"

Sorry just another comment. I think we can make this one patch deleting everything.

Quoted 9 lines

Sorry, I don't understand the comment. Do I need to merge them into one big patch?
Btw, if I use one patch, I would get check patch fail.
---
[2020-07-22 19:12:49,046 ERROR] Run check patch results:
WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
---

Hm, I think that's a debatable error message from checkpatch, but let's leave it as it is.

Regards,
Matthias

Quoted 16 lines

Hanks

Quoted 12 lines
Quoted 12 lines

-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support" -- remove Fixes tag

Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support

   drivers/clk/mediatek/clk-mt6779.c      | 2 --
   include/dt-bindings/clock/mt6779-clk.h | 1 -
   2 files changed, 3 deletions(-)
author
#9 lore raw

Hi all,

Gentle ping on this patch set.

Thanks!

Hanks Chen

Quoted 62 lines · Hanks Chen

Hi all,

Gentle ping on this patch.

Thanks!

Hanks Chen

Quoted 24 lines · Matthias Brugger
Quoted 12 lines · Hanks Chen
Quoted 11 lines · Matthias Brugger
Quoted 6 lines · Hanks Chen

remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"

Sorry just another comment. I think we can make this one patch deleting everything.

Quoted 9 lines

Sorry, I don't understand the comment. Do I need to merge them into one big patch?
Btw, if I use one patch, I would get check patch fail.
---
[2020-07-22 19:12:49,046 ERROR] Run check patch results:
WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
---

Quoted 23 lines

Hm, I think that's a debatable error message from checkpatch, but let's leave it as it is.

Regards,
Matthias

Quoted 16 lines

Hanks

Quoted 12 lines
Quoted 12 lines

-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support" -- remove Fixes tag

Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support

   drivers/clk/mediatek/clk-mt6779.c      | 2 --
   include/dt-bindings/clock/mt6779-clk.h | 1 -
   2 files changed, 3 deletions(-)

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#10 lore raw

Hi Michael & Stephen,

Gentle ping on this clk patch.

Thanks.

Regards,
Hanks

Quoted 78 lines · Hanks Chen

Hi all,

Gentle ping on this patch set.

Thanks!

Hanks Chen

Quoted 58 lines · Hanks Chen

Hi all,

Gentle ping on this patch.

Thanks!

Hanks Chen

Quoted 24 lines · Matthias Brugger
Quoted 12 lines · Hanks Chen
Quoted 11 lines · Matthias Brugger
Quoted 6 lines · Hanks Chen

remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"

Sorry just another comment. I think we can make this one patch deleting everything.

Quoted 9 lines

Sorry, I don't understand the comment. Do I need to merge them into one big patch?
Btw, if I use one patch, I would get check patch fail.
---
[2020-07-22 19:12:49,046 ERROR] Run check patch results:
WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
---

Quoted 23 lines

Hm, I think that's a debatable error message from checkpatch, but let's leave it as it is.

Regards,
Matthias

Quoted 16 lines

Hanks

Quoted 12 lines
Quoted 12 lines

-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support" -- remove Fixes tag

Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support

   drivers/clk/mediatek/clk-mt6779.c      | 2 --
   include/dt-bindings/clock/mt6779-clk.h | 1 -
   2 files changed, 3 deletions(-)
Quoted 4 lines

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek