Skip to contentSkip to conversation

webkitgtk: remove '-fno-omit-frame-pointer' for x86

PATCH In review kai 4 participants 8 messages Nov 9, 2020 – Nov 10, 2020

lore
Share & tools
lore

kai

author
#0 lore raw

PATCH 1/1 webkitgtk: remove '-fno-omit-frame-pointer' for x86

From: Kai Kang <[email protected]>

It fails to compile webkitgtk for qemux86 if compile option '-fno-omit-frame-pointer' is applied:

| TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
| internal compiler error: in find_oldest_value_reg, at regcprop.c:438
| 47 | }

---
 meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.30.2.bb +1 -0
index 1acba6be1d..11fdb59034 100644
@@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
 # which is not enough for binaries larger than 32 MiB
 CFLAGS_append_arc = " -mlong-calls"
 CXXFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
 
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
Signature · 1 line
2.17.1
#1 lore raw

This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?

Alex

Quoted 36 lines · kai

From: Kai Kang <[email protected]>

It fails to compile webkitgtk for qemux86 if compile option '-fno-omit-frame-pointer' is applied:

| TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
| internal compiler error: in find_oldest_value_reg, at regcprop.c:438
| 47 | }

---
 meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.30.2.bb +1 -1
index 1acba6be1d..11fdb59034 100644
@@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
 # which is not enough for binaries larger than 32 MiB
 CFLAGS_append_arc = " -mlong-calls"
 CXXFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
 
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
--

2.17.1

author
#2 lore raw
Quoted 1 line · Alexander Kanavin

This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?

Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:

SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"

which expands to

SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"

then it fails to compile webkitgtk. It could be reproduced with upper config line.

Regards,
Kai

Quoted 50 lines

Alex

On Mon, 9 Nov 2020 at 01:32, kai <[email protected] <mailto:[email protected]>> wrote:

    From: Kai Kang <[email protected]
    <mailto:[email protected]>>

    It fails to compile webkitgtk for qemux86 if compile option
    '-fno-omit-frame-pointer' is applied:

    |
    TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
    Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
    | internal compiler error: in find_oldest_value_reg, at regcprop.c:438
    |    47 | }

    Signed-off-by: Kai Kang <[email protected]
    <mailto:[email protected]>>
    ---
     meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
    <http://webkitgtk_2.30.2.bb> | 1 +
     1 file changed, 1 insertion(+)

    diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
    <http://webkitgtk_2.30.2.bb>
    b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
    <http://webkitgtk_2.30.2.bb>
    index 1acba6be1d..11fdb59034 100644
    --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
    <http://webkitgtk_2.30.2.bb>
    +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
    <http://webkitgtk_2.30.2.bb>
    @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
     # which is not enough for binaries larger than 32 MiB
     CFLAGS_append_arc = " -mlong-calls"
     CXXFLAGS_append_arc = " -mlong-calls"
    +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"

     # Javascript JIT is not supported on powerpc
     EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
    -- 
    2.17.1
#3 lore raw

Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.

Alex

Quoted 69 lines · kai

On 11/9/20 3:32 PM, Alexander Kanavin wrote:

This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?

Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:

SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"

which expands to

SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"

then it fails to compile webkitgtk. It could be reproduced with upper config line.

Regards,
Kai

Alex

Quoted 36 lines · kai

From: Kai Kang <[email protected]>

It fails to compile webkitgtk for qemux86 if compile option '-fno-omit-frame-pointer' is applied:

| TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
| internal compiler error: in find_oldest_value_reg, at regcprop.c:438
| 47 | }

---
 meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.30.2.bb +1 -1
index 1acba6be1d..11fdb59034 100644
@@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
 # which is not enough for binaries larger than 32 MiB
 CFLAGS_append_arc = " -mlong-calls"
 CXXFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
 
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
--

2.17.1

author
#4 lore raw
Quoted 1 line · Alexander Kanavin

Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.

I suppose '-fomit-frame-pointer' is common compile flag that other people may also meet this error.

Regards,
Kai

Quoted 81 lines

Alex

On Mon, 9 Nov 2020 at 08:52, kai <[email protected] <mailto:[email protected]>> wrote:

    On 11/9/20 3:32 PM, Alexander Kanavin wrote:
Quoted 2 lines

This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?

Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:

SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"

which expands to

SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION}
-fno-omit-frame-pointer -fvisibility=default"

then it fails to compile webkitgtk. It could be reproduced with upper config line.

Regards,
Kai

Quoted 50 lines
    Alex

    On Mon, 9 Nov 2020 at 01:32, kai <[email protected]
    <mailto:[email protected]>> wrote:

        From: Kai Kang <[email protected]
        <mailto:[email protected]>>

        It fails to compile webkitgtk for qemux86 if compile option
        '-fno-omit-frame-pointer' is applied:

        |
        TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
        Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
        | internal compiler error: in find_oldest_value_reg, at
        regcprop.c:438
        |    47 | }

        Signed-off-by: Kai Kang <[email protected]
        <mailto:[email protected]>>
        ---
         meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
        <http://webkitgtk_2.30.2.bb> | 1 +
         1 file changed, 1 insertion(+)

        diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
        <http://webkitgtk_2.30.2.bb>
        b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
        <http://webkitgtk_2.30.2.bb>
        index 1acba6be1d..11fdb59034 100644
        --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
        <http://webkitgtk_2.30.2.bb>
        +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
        <http://webkitgtk_2.30.2.bb>
        @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
         # which is not enough for binaries larger than 32 MiB
         CFLAGS_append_arc = " -mlong-calls"
         CXXFLAGS_append_arc = " -mlong-calls"
        +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"

         # Javascript JIT is not supported on powerpc
         EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
        -- 
        2.17.1
#5 lore raw
Quoted 7 lines · kai

On 11/9/20 4:07 PM, Alexander Kanavin wrote:

Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.

I suppose '-fomit-frame-pointer' is common compile flag that other people may also meet this error.

Quoted 22 lines

Regards,
Kai

Alex

Quoted 15 lines · kai

On 11/9/20 3:32 PM, Alexander Kanavin wrote:

This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?

Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:

SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"

which expands to

SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"

then it fails to compile webkitgtk. It could be reproduced with upper config line.

since we do not have global file to control this its fine if you alter PROFILING_OPTIMIZATION inside this recipe
something like PROFILING_OPTIMIZATION_remove = "..."

Quoted 52 lines
Quoted 48 lines

Regards,
Kai

Alex

Quoted 34 lines · kai

From: Kai Kang <[email protected]>

It fails to compile webkitgtk for qemux86 if compile option '-fno-omit-frame-pointer' is applied:

| TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
| internal compiler error: in find_oldest_value_reg, at regcprop.c:438
| 47 | }

---
 meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.30.2.bb +1 -1
index 1acba6be1d..11fdb59034 100644
@@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
 # which is not enough for binaries larger than 32 MiB
 CFLAGS_append_arc = " -mlong-calls"
 CXXFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
 
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
--

2.17.1

author
#6 lore raw
Quoted 24 lines · Khem Raj
Quoted 23 lines · kai

On 11/9/20 4:07 PM, Alexander Kanavin wrote:

Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.

I suppose '-fomit-frame-pointer' is common compile flag that other people may also meet this error.

Regards,
Kai

Alex

Quoted 10 lines · kai

On 11/9/20 3:32 PM, Alexander Kanavin wrote:

This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?

Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:

SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"

which expands to

Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"

then it fails to compile webkitgtk. It could be reproduced with upper config line.

since we do not have global file to control this its fine if you alter PROFILING_OPTIMIZATION inside this recipe
something like PROFILING_OPTIMIZATION_remove = "..."

OK. I'll follow the snippet such as:

recipes-devtools/binutils/binutils_2.35.bb:SELECTED_OPTIMIZATION_remove_mipsarch = "-O2"

Thanks,
Kai

Quoted 53 lines
Quoted 53 lines
Quoted 47 lines

Regards,
Kai

Alex

Quoted 33 lines · kai

From: Kai Kang <[email protected]>

It fails to compile webkitgtk for qemux86 if compile option '-fno-omit-frame-pointer' is applied:

| TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
| internal compiler error: in find_oldest_value_reg, at regcprop.c:438
| 47 | }

---
  meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
  1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.30.2.bb +1 -1
index 1acba6be1d..11fdb59034 100644
@@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
  # which is not enough for binaries larger than 32 MiB
  CFLAGS_append_arc = " -mlong-calls"
  CXXFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
 
  # Javascript JIT is not supported on powerpc
  EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
--

2.17.1

#7 lore raw
Quoted 33 lines · kai

On 11/10/20 2:58 AM, Khem Raj wrote:

On Mon, Nov 9, 2020 at 12:18 AM kai <[email protected]> wrote:

On 11/9/20 4:07 PM, Alexander Kanavin wrote:

Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.

I suppose '-fomit-frame-pointer' is common compile flag that other people may also meet this error.

Regards,
Kai

Alex

On Mon, 9 Nov 2020 at 08:52, kai <[email protected]> wrote:

On 11/9/20 3:32 PM, Alexander Kanavin wrote:

This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?

Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:

SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"

which expands to

SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"

then it fails to compile webkitgtk. It could be reproduced with upper config line.

Quoted 7 lines

since we do not have global file to control this its fine if you alter PROFILING_OPTIMIZATION inside this recipe
something like PROFILING_OPTIMIZATION_remove = "..." -fno-omit-frame-pointer
OK. I'll follow the snippet such as:

recipes-devtools/binutils/binutils_2.35.bb:SELECTED_OPTIMIZATION_remove_mipsarch = "-O2"

If you want to ensure that something is built without frame pointers then appending "-fomit-frame-pointer" is clearer (and more robust) than trying to remove "-fno-omit-frame-pointer".

Quoted 62 lines

Thanks,
Kai

Regards,
Kai

Alex

On Mon, 9 Nov 2020 at 01:32, kai <[email protected]> wrote:

From: Kai Kang <[email protected]>

It fails to compile webkitgtk for qemux86 if compile option '-fno-omit-frame-pointer' is applied:

| TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
| internal compiler error: in find_oldest_value_reg, at regcprop.c:438
| 47 | }

---
 meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.30.2.bb +1 -1
index 1acba6be1d..11fdb59034 100644
@@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
 # which is not enough for binaries larger than 32 MiB
 CFLAGS_append_arc = " -mlong-calls"
 CXXFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
 
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
--

2.17.1