clk: eswin: Add CLK_IGNORE_UNUSED to NoC clock
Subsystems (2)
[email protected]
maintainerPATCH 1/1 clk: eswin: Add CLK_IGNORE_UNUSED to NoC clock
From: Xuyang Dong <[email protected]>
The gate_noc_nsp_clk provides the essential clock source for NPU, DSP, and PCIe subsystems. During kernel init, the clock framework attempts to disable unused clocks when clk_ignore_unused kernel parameter is not set.
However, gate_noc_nsp_clk is required to remain enabled for these critical subsystems to function properly, causing PCIe boot failures when auto-disabled.
Add CLK_IGNORE_UNUSED flag to gate_noc_nsp_clk to ensure it stays enabled even when clk_ignore_unused is not specified in kernel command line.
--- drivers/clk/eswin/clk-eic7700.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/clk/eswin/clk-eic7700.c +2 -1
@@ -791,7 +791,8 @@ static struct eswin_clk_info eic7700_clks[] = { EIC7700_CLK_MUX_CPU_ROOT_3MUX1_GFREE, CLK_SET_RATE_PARENT, EIC7700_REG_OFFSET_U84, 27, 0),ESWIN_GATE_TYPE (EIC7700_CLK_GATE_NOC_NSP_CLK ,"gate_noc_nsp_clk" , -EIC7700_CLK_DIV_NOC_NSP_DYNM ,CLK_SET_RATE_PARENT , +EIC7700_CLK_DIV_NOC_NSP_DYNM , +CLK_SET_RATE_PARENT |CLK_IGNORE_UNUSED ,EIC7700_REG_OFFSET_NOC ,31 ,0 ), ESWIN_GATE_TYPE(EIC7700_CLK_GATE_BOOTSPI, "gate_clk_bootspi", EIC7700_CLK_MUX_BOOTSPI_CLK_2MUX1_GFREE,
Signature · 1 line
2.34.1
Quoted 10 lines · On Fri, Jun 05, 2026 at 05:21:18PM +0800, [email protected] wrote:
From: Xuyang Dong <[email protected]>
The
gate_noc_nsp_clkprovides the essential clock source for NPU, DSP, and PCIe subsystems. During kernel init, the clock framework attempts to disable unused clocks whenclk_ignore_unusedkernel parameter is not set.
However,gate_noc_nsp_clkis required to remain enabled for these critical subsystems to function properly, causing PCIe boot failures when auto-disabled.
Quoted 6 lines
Add
CLK_IGNORE_UNUSEDflag togate_noc_nsp_clkto ensure it stays enabled even whenclk_ignore_unusedis not specified in kernel command line.Fixes cd44f127c1d4 ("clk: eswin: Add eic7700 clock driver")Signed-off-by Xuyang Dong <[email protected]>
FYI, I posted a series to implement sync_state support for the clk subsystem, which should fix these type of issues for the long term. If you happen to have time, I would appreciate it if you have time to test this series on your hardware, and drop a Tested-by.
https://lore.kernel.org/linux-clk/[email protected]/
I have a new series ready that I'm planning to post tomorrow. I'm waiting to hear back about the ongoing conversation on that thread.
Once this lands, there shouldn't be much need for the CLK_IGNORE_UNUSED flag. I'm curious if you revert this patch in your tree if the need for the flag goes away with the sync_state changes applied.
Let's get your change in the tree though. If we merged sync_state today, it won't be eligible to be backported to the stable kernels, and the CLK_IGNORE_UNUSED flag is an easier backport.
Brian
Xuyang Dong
maintainerQuoted 31 lines · On Fri, Jun 05, 2026 at 05:21:18PM +0800, [email protected] wrote:
Quoted 10 lines
From: Xuyang Dong <[email protected]>
The
gate_noc_nsp_clkprovides the essential clock source for NPU, DSP, and PCIe subsystems. During kernel init, the clock framework attempts to disable unused clocks whenclk_ignore_unusedkernel parameter is not set.
However,gate_noc_nsp_clkis required to remain enabled for these critical subsystems to function properly, causing PCIe boot failures when auto-disabled.Quoted 6 lines
Add
CLK_IGNORE_UNUSEDflag togate_noc_nsp_clkto ensure it stays enabled even whenclk_ignore_unusedis not specified in kernel command line.Fixes cd44f127c1d4 ("clk: eswin: Add eic7700 clock driver")Signed-off-by Xuyang Dong <[email protected]>Reviewed-by Brian Masney <[email protected]>FYI, I posted a series to implement
sync_statesupport for the clk subsystem, which should fix these type of issues for the long term. If you happen to have time, I would appreciate it if you have time to test this series on your hardware, and drop a Tested-by.https://lore.kernel.org/linux-clk/[email protected]/
I have a new series ready that I'm planning to post tomorrow. I'm waiting to hear back about the ongoing conversation on that thread.
Quoted 8 lines
Once this lands, there shouldn't be much need for the
CLK_IGNORE_UNUSEDflag. I'm curious if you revert this patch in your tree if the need for the flag goes away with thesync_statechanges applied.Let's get your change in the tree though. If we merged
sync_statetoday, it won't be eligible to be backported to the stable kernels, and theCLK_IGNORE_UNUSEDflag is an easier backport.
Hi Brian,
Thank you for your patch set above. However, we still need this fix patch at the moment, because gate_noc_nsp_clk still needs to be enabled when accessing PCIe.
Best regards,
Xuyang Dong
Quoted 21 lines · Xuyang Dong
Quoted 12 lines
Reviewed-by Brian Masney <[email protected]>FYI, I posted a series to implement
sync_statesupport for the clk subsystem, which should fix these type of issues for the long term. If you happen to have time, I would appreciate it if you have time to test this series on your hardware, and drop a Tested-by.https://lore.kernel.org/linux-clk/[email protected]/
I have a new series ready that I'm planning to post tomorrow. I'm waiting to hear back about the ongoing conversation on that thread.
Quoted 8 lines
Once this lands, there shouldn't be much need for the
CLK_IGNORE_UNUSEDflag. I'm curious if you revert this patch in your tree if the need for the flag goes away with thesync_statechanges applied.Let's get your change in the tree though. If we merged
sync_statetoday, it won't be eligible to be backported to the stable kernels, and theCLK_IGNORE_UNUSEDflag is an easier backport.
Quoted 5 lines
Hi Brian,
Thank you for your patch set above. However, we still need this fix patch at the moment, because
gate_noc_nsp_clkstill needs to be enabled when accessing PCIe.
Yes, I agree this is also needed.
Brian