iio: add missing select REMAP_SPI, IIO_BUFFER, and IIO_TRIGGERED_BUFFER
cover iio: add missing select REMAP_SPI, IIO_BUFFER, and IIO_TRIGGERED_BUFFER
The following drivers make use of IIO_BUFFER and IIO_TRIGGERED_BUFFER, but they don't select the required modules in their Kconfig entries. There is also one case where REGMAP_SPI must be selected as well.
These entries have been missing since the drivers where introduced in most cases, but in some occasions they were not added while adding support for triggered buffers. If anyone wants to know, please take a look at the Fixes: tags for more information.
Usually you will not notice the missing dependencies, but tiny config files where those drivers are include will lead to multiple errors when compiling and linking.
I have already sent a series that fixes this issue (mainly focused on REGMAP*) [1] in some drivers, and this one attempts to complete the job at least for REGMAP*, IIO_BUFFER and IIO_TRIGGERED_BUFFER.
---
Javier Carrasco (13):
iio: accel: kx022a: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: adc: ad7944: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: adc: ti-ads124s08: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: adc: ti-ads8688: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: adc: ti-lmp92064: add missing select REGMAP_SPI in Kconfig
iio: adc: ti-lmp92064: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: dac: ad3552r: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: dac: ad5766: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: chemical: ens160: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: light: bu27008: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: magnetometer: af8133j: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
iio: proximity: mb1232: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
drivers/iio/accel/Kconfig | 2 ++ drivers/iio/adc/Kconfig | 9 +++++++++ drivers/iio/chemical/Kconfig | 2 ++ drivers/iio/dac/Kconfig | 4 ++++ drivers/iio/light/Kconfig | 2 ++ drivers/iio/magnetometer/Kconfig | 2 ++ drivers/iio/pressure/Kconfig | 3 +++ drivers/iio/proximity/Kconfig | 2 ++ 8 files changed, 26 insertions(+)
---
base-commit: c02d24a5af66a9806922391493205a344749f2c4
change-id: 20241003-iio-select-209410bf9170
Best regards,
Signature · 1 line
Javier Carrasco <[email protected]>
PATCH 1/13 iio: accel: kx022a: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/accel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/accel/Kconfig +2 -0
@@ -447,6 +447,8 @@ config IIO_ST_ACCEL_SPI_3AXIS config IIO_KX022A tristate + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER config IIO_KX022A_SPI tristate "Kionix KX022A tri-axis digital accelerometer SPI interface"
Signature · 1 line
2.43.0
Re: [PATCH 01/13] iio: accel: kx022a: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 7c1d1677b322 ("iio: accel: Support Kionix/ROHM KX022A accelerometer")Signed-off-by Javier Carrasco <[email protected]>
Re: [PATCH 01/13] iio: accel: kx022a: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 4 lines · On Fri, 4 Oct 2024 11:17:34 +0300 Matti Vaittinen <[email protected]>…
Quoted 3 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Quoted 8 lines
Quoted 4 lines
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 7c1d1677b322 ("iio: accel: Support Kionix/ROHM KX022A accelerometer")Signed-off-by Javier Carrasco <[email protected]>Acked-by Matti Vaittinen <[email protected]>
Applied to the fixes-togreg branch of iio.git.
J
PATCH 2/13 iio: adc: ad7944: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
@@ -328,6 +328,8 @@ config AD7923 config AD7944 tristate "Analog Devices AD7944 and similar ADCs driver" depends on SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices AD7944, AD7985, AD7986 ADCs.
Signature · 1 line
2.43.0
Re: [PATCH 02/13] iio: adc: ad7944: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 8 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes d1efcf8871db ("iio: adc: ad7944: add driver for AD7944/AD7985/AD7986")Signed-off-by Javier Carrasco <[email protected]>---
Re: [PATCH 02/13] iio: adc: ad7944: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 4 lines · On Thu, 3 Oct 2024 18:00:45 -0500 David Lechner <[email protected]> wrote:
Quoted 3 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Quoted 8 lines
Quoted 5 lines
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes d1efcf8871db ("iio: adc: ad7944: add driver for AD7944/AD7985/AD7986")Signed-off-by Javier Carrasco <[email protected]>---
Reviewed-by David Lechner <[email protected]>
Applied to the fixes-togreg branch of iio.git.
Thanks,
J
PATCH 3/13 iio: adc: ti-ads124s08: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
@@ -1493,6 +1493,8 @@ config TI_ADS8688 config TI_ADS124S08 tristate "Texas Instruments ADS124S08" depends on SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADS124S08 and ADS124S06 ADC chips
Signature · 1 line
2.43.0
PATCH 4/13 iio: adc: ti-ads8688: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
@@ -1483,6 +1483,8 @@ config TI_ADS8344 config TI_ADS8688 tristate "Texas Instruments ADS8688" depends on SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADS8684 and and ADS8688 ADC chips
Signature · 1 line
2.43.0
Re: [PATCH 04/13] iio: adc: ti-ads8688: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Fixes 2a86487786b5 ("iio: adc: ti-ads8688: add trigger and buffer support")Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Signed-off-by Javier Carrasco <[email protected]>
Quoted 21 lines
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/adc/Kconfig +2
-0@@ -1483,6 +1483,8 @@ config TI_ADS8344 config TI_ADS8688 tristate "Texas Instruments ADS8688" depends on SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADS8684 and and ADS8688 ADC chipsSignature · 2 lines
-- 2.43.0
Jonathan Cameron
maintainerRe: [PATCH 04/13] iio: adc: ti-ads8688: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoQuoted 5 lines · On Thu, 03 Oct 2024 23:04:50 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Fixes 2a86487786b5 ("iio: adc: ti-ads8688: add trigger and buffer support")Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.
Fixes tag must be part of the tag block.
Also this one looks to be a false positive. The driver includes buffer.h but doesn't actually have buffered support.
Quoted 20 lines
Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/adc/Kconfig +2
-0@@ -1483,6 +1483,8 @@ config TI_ADS8344 config TI_ADS8688 tristate "Texas Instruments ADS8688" depends on SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADS8684 and and ADS8688 ADC chips
Re: [PATCH 04/13] iio: adc: ti-ads8688: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 6 lines · Jonathan Cameron
Quoted 3 lines · On Thu, 03 Oct 2024 23:04:50 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Quoted 7 lines
Quoted 2 lines
Fixes 2a86487786b5 ("iio: adc: ti-ads8688: add trigger and buffer support")Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes tag must be part of the tag block.
Also this one looks to be a false positive. The driver includes
buffer.hbut doesn't actually have buffered support.
Are you sure? These are the errors I get when I compile the ti-ads8688.c:
ld: drivers/iio/adc/ti-ads8688.o: in function `ads8688_probe':
ti-ads8688.c:(.text+0x1cf): undefined reference to `devm_iio_triggered_buffer_setup_ext'
ld: drivers/iio/adc/ti-ads8688.o: in function `ads8688_trigger_handler':
ti-ads8688.c:(.text+0x3be): undefined reference to `iio_push_to_buffers'
ld: ti-ads8688.c:(.text+0x3c9): undefined reference to `iio_trigger_notify_done'
make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1 make[1]: *** [/home/jc/pw/linux/linux-next/Makefile:1173: vmlinux] Error 2
make: *** [Makefile:224: __sub-make] Error 2
And I see the offending functions in its code. Am I missing something here or are we talking about different drivers?
Quoted 21 lines
Quoted 20 lines
Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/adc/Kconfig +2
-0@@ -1483,6 +1483,8 @@ config TI_ADS8344 config TI_ADS8688 tristate "Texas Instruments ADS8688" depends on SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADS8684 and and ADS8688 ADC chips
Jonathan Cameron
maintainerRe: [PATCH 04/13] iio: adc: ti-ads8688: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 28 lines · On Sat, 5 Oct 2024 20:21:06 +0200 Javier Carrasco…
Quoted 6 lines · Jonathan Cameron
Quoted 3 lines · On Thu, 03 Oct 2024 23:04:50 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Quoted 7 lines
Quoted 2 lines
Fixes 2a86487786b5 ("iio: adc: ti-ads8688: add trigger and buffer support")Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes tag must be part of the tag block.
Also this one looks to be a false positive. The driver includes
buffer.hbut doesn't actually have buffered support.Are you sure? These are the errors I get when I compile the
ti-ads8688.c:ld:
drivers/iio/adc/ti-ads8688.o: in function `ads8688_probe':
ti-ads8688.c:(.text+0x1cf): undefined reference to `devm_iio_triggered_buffer_setup_ext'
ld:drivers/iio/adc/ti-ads8688.o: in function `ads8688_trigger_handler':
ti-ads8688.c:(.text+0x3be): undefined reference to `iio_push_to_buffers'
ld: ti-ads8688.c:(.text+0x3c9): undefined reference to `iio_trigger_notify_done'
make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1 make[1]: *** [/home/jc/pw/linux/linux-next/Makefile:1173: vmlinux] Error 2
make: *** [Makefile:224: __sub-make] Error 2
Quoted 2 lines
And I see the offending functions in its code. Am I missing something here or are we talking about different drivers?
Miss read by me. I picked up on the 8344 in diff. That does have a spurious include so I stopped looking closer!
Anyhow, now applied to the fixes-togreg branch of iio.git and marked for stable.
Sorry about that!
Thanks,
Jonathan
Quoted 23 lines
Quoted 22 lines
Quoted 21 lines
Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/adc/Kconfig +2
-0@@ -1483,6 +1483,8 @@ config TI_ADS8344 config TI_ADS8688 tristate "Texas Instruments ADS8688" depends on SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADS8684 and and ADS8688 ADC chips
PATCH 5/13 iio: adc: ti-lmp92064: add missing select REGMAP_SPI in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_spi, but does not select the required module.
Add the missing 'select REGMAP_SPI'.
--- drivers/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/adc/Kconfig +1 -0
@@ -1531,6 +1531,7 @@ config TI_AM335X_ADC config TI_LMP92064 tristate "Texas Instruments LMP92064 ADC driver" depends on SPI + select REGMAP_SPI help Say yes here to build support for the LMP92064 Precision Current and Voltage sensor.
Signature · 1 line
2.43.0
Re: [PATCH 05/13] iio: adc: ti-lmp92064: add missing select REGMAP_SPI in Kconfig
Quoted 6 lines · On Thu, 03 Oct 2024 23:04:51 +0200 Javier Carrasco…
This driver makes use of
regmap_spi, but does not select the required module.
Add the missing 'selectREGMAP_SPI'.Fixes 627198942641 ("iio: adc: add ADC driver for the TI LMP92064 controller")Signed-off-by Javier Carrasco <[email protected]>
Applied to the fixes-togreg branch of iio.git.
Thanks,
J
Quoted 17 lines
--- drivers/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/iio/adc/Kconfig +1
-0@@ -1531,6 +1531,7 @@ config TI_AM335X_ADC config TI_LMP92064 tristate "Texas Instruments LMP92064 ADC driver" depends on SPI + select REGMAP_SPI help Say yes here to build support for the LMP92064 Precision Current and Voltage sensor.
PATCH 6/13 iio: adc: ti-lmp92064: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
@@ -1532,6 +1532,8 @@ config TI_LMP92064 tristate "Texas Instruments LMP92064 ADC driver" depends on SPI select REGMAP_SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for the LMP92064 Precision Current and Voltage sensor.
Signature · 1 line
2.43.0
Re: [PATCH 06/13] iio: adc: ti-lmp92064: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · On Thu, 03 Oct 2024 23:04:52 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 6c7bc1d27bb2 ("iio: adc: ti-lmp92064: add buffering support")Signed-off-by Javier Carrasco <[email protected]>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
Quoted 18 lines
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/adc/Kconfig +2
-0@@ -1532,6 +1532,8 @@ config TI_LMP92064 tristate "Texas Instruments LMP92064 ADC driver" depends on SPI select REGMAP_SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for the LMP92064 Precision Current and Voltage sensor.
PATCH 7/13 iio: dac: ad3552r: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/dac/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/dac/Kconfig +2 -0
@@ -9,6 +9,8 @@ menu "Digital to analog converters" config AD3552R tristate "Analog Devices AD3552R DAC driver" depends on SPI_MASTER + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices AD3552R Digital to Analog Converter.
Signature · 1 line
2.43.0
Re: [PATCH 07/13] iio: dac: ad3552r: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · On Thu, 03 Oct 2024 23:04:53 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support")Signed-off-by Javier Carrasco <[email protected]>
Applied to the fixes-togreg branch of iio.git
Thanks,
J
Quoted 18 lines
--- drivers/iio/dac/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/dac/Kconfig +2
-0@@ -9,6 +9,8 @@ menu "Digital to analog converters" config AD3552R tristate "Analog Devices AD3552R DAC driver" depends on SPI_MASTER + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices AD3552R Digital to Analog Converter.
PATCH 8/13 iio: dac: ad5766: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/dac/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/dac/Kconfig +2 -0
@@ -254,6 +254,8 @@ config AD5764 config AD5766 tristate "Analog Devices AD5766/AD5767 DAC driver" depends on SPI_MASTER + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices AD5766, AD5767 Digital to Analog Converter.
Signature · 1 line
2.43.0
Re: [PATCH 08/13] iio: dac: ad5766: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · On Thu, 03 Oct 2024 23:04:54 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 885b9790c25a ("drivers:iio:dac:ad5766.c: Add trigger buffer")Signed-off-by Javier Carrasco <[email protected]>
Applied to the fixes-togreg branch of iio.git.
thanks,
J
Quoted 18 lines
--- drivers/iio/dac/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/dac/Kconfig +2
-0@@ -254,6 +254,8 @@ config AD5764 config AD5766 tristate "Analog Devices AD5766/AD5767 DAC driver" depends on SPI_MASTER + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices AD5766, AD5767 Digital to Analog Converter.
PATCH 9/13 iio: chemical: ens160: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/chemical/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/chemical/Kconfig +2 -0
@@ -80,6 +80,8 @@ config ENS160 tristate "ScioSense ENS160 sensor driver" depends on (I2C || SPI) select REGMAP + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER select ENS160_I2C if I2C select ENS160_SPI if SPI help
Signature · 1 line
2.43.0
Re: [PATCH 09/13] iio: chemical: ens160: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 0fc26596b4b3 ("iio: chemical: ens160: add triggered buffer support")Signed-off-by Javier Carrasco <[email protected]>
Acked-by: Gustavo Silva
<[email protected]>
Re: [PATCH 09/13] iio: chemical: ens160: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 11 lines · On Fri, 4 Oct 2024 11:27:49 -0300 Gustavo Silva <[email protected]> wrote:
Quoted 7 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 0fc26596b4b3 ("iio: chemical: ens160: add triggered buffer support")Signed-off-by Javier Carrasco <[email protected]>Acked-by: Gustavo Silva
<[email protected]>
Applied
PATCH 10/13 iio: light: bu27008: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/light/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/light/Kconfig +2 -0
@@ -335,6 +335,8 @@ config ROHM_BU27008 depends on I2C select REGMAP_I2C select IIO_GTS_HELPER + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Enable support for the ROHM BU27008 color sensor. The ROHM BU27008 is a sensor with 5 photodiodes (red, green,
Signature · 1 line
2.43.0
Re: [PATCH 10/13] iio: light: bu27008: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 41ff93d14f78 ("iio: light: ROHM BU27008 color sensor")Signed-off-by Javier Carrasco <[email protected]>
Re: [PATCH 10/13] iio: light: bu27008: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 11 lines · On Fri, 4 Oct 2024 11:16:05 +0300 Matti Vaittinen <[email protected]>…
Quoted 7 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 41ff93d14f78 ("iio: light: ROHM BU27008 color sensor")Signed-off-by Javier Carrasco <[email protected]>Acked-by Matti Vaittinen <[email protected]>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
PATCH 11/13 iio: magnetometer: af8133j: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/magnetometer/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/magnetometer/Kconfig +2 -0
@@ -11,6 +11,8 @@ config AF8133J depends on I2C depends on OF select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Voltafield AF8133J I2C-based 3-axis magnetometer chip.
Signature · 1 line
2.43.0
Re: [PATCH 11/13] iio: magnetometer: af8133j: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 28 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 1d8f4b04621f ("iio: magnetometer: add a driver for Voltafield AF8133J magnetometer")Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/magnetometer/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/magnetometer/Kconfig +2
-0@@ -11,6 +11,8 @@ config AF8133J depends on I2C depends on OF select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Voltafield AF8133J I2C-based 3-axis magnetometer chip.Signature · 2 lines
-- 2.43.0
Signature · 2 lines
Best regards, Andrey Skvortsov
Re: [PATCH 11/13] iio: magnetometer: af8133j: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 26 lines · On Fri, 4 Oct 2024 11:58:13 +0300 Andrey Skvortsov…
Quoted 25 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 1d8f4b04621f ("iio: magnetometer: add a driver for Voltafield AF8133J magnetometer")Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/magnetometer/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/magnetometer/Kconfig +2
-0@@ -11,6 +11,8 @@ config AF8133J depends on I2C depends on OF select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Voltafield AF8133J I2C-based 3-axis magnetometer chip.
Quoted 6 lines
Quoted 3 lines
Signature · 1 line
2.43.0Reviewed-by Andrey Skvortsov <[email protected]>
Applied to the fixes-togreg branch of iio.git
PATCH 12/13 iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/pressure/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
drivers/iio/pressure/Kconfig +3 -0
@@ -19,6 +19,9 @@ config ABP060MG config ROHM_BM1390 tristate "ROHM BM1390GLV-Z pressure sensor driver" depends on I2C + select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z can measure pressures ranging from 300 hPa to 1300 hPa with
Signature · 1 line
2.43.0
Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")Signed-off-by Javier Carrasco <[email protected]>
Jonathan Cameron
maintainerRe: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoQuoted 6 lines · On Thu, 03 Oct 2024 23:04:58 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the patch description to refer to the bm1390 which seems to be the right name and add a note on this as it looks suspect otherwise.
Quoted 20 lines
Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/pressure/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/iio/pressure/Kconfig +3
-0@@ -19,6 +19,9 @@ config ABP060MG config ROHM_BM1390 tristate "ROHM BM1390GLV-Z pressure sensor driver" depends on I2C + select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z can measure pressures ranging from 300 hPa to 1300 hPa with
Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 6 lines · Jonathan Cameron
Quoted 3 lines · On Thu, 03 Oct 2024 23:04:58 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Quoted 7 lines
Quoted 3 lines
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the patch description to refer to the bm1390 which seems to be the right name and add a note on this as it looks suspect otherwise.
Yes, it seems that there was a typo in the title of the patch that added the driver (The "Fixes:" is therefore right as it is), and I propagated it in the title of this patch as well. But you are right, the driver's name is indeed bm1390.
Quoted 21 lines
Quoted 20 lines
Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/pressure/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/iio/pressure/Kconfig +3
-0@@ -19,6 +19,9 @@ config ABP060MG config ROHM_BM1390 tristate "ROHM BM1390GLV-Z pressure sensor driver" depends on I2C + select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z can measure pressures ranging from 300 hPa to 1300 hPa with
Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 10 lines · Javier Carrasco
Quoted 9 lines · Jonathan Cameron
Quoted 6 lines · On Thu, 03 Oct 2024 23:04:58 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
Quoted 8 lines
Quoted 4 lines
Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the patch description to refer to the bm1390 which seems to be the right name and add a note on this as it looks suspect otherwise.
Yes, it seems that there was a typo in the title of the patch that added the driver (The "Fixes:" is therefore right as it is), and I propagated it in the title of this patch as well. But you are right, the driver's name is indeed bm1390.
Yep. I typoed the original patch. The correct sensor model is BM1390GLV-Z. I got things mixed up in my head as I was simultaneously writing drivers the BU270xx light sensors, a BD71851 power management IC and BU18xxxx video serializer and deserializer. All the B?<bunch of numbers> part IDs got better of me :)
Yours,
-- Matti
Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Jonathan CameronQuoted 2 lines · Jonathan Cameron
On Thu, 03 Oct 2024 23:04:58 +0200
Javier Carrasco <[email protected]> wrote:
...
Quoted 4 lines
Quoted 1 line
Fixes 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the patch description to refer to the bm1390 which seems to be the right name and add a note on this as it looks suspect otherwise.
Fixes tag shouldn't be mangled, even if it has a typo.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jonathan Cameron
maintainerRe: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 4 lines · On Thu, 10 Oct 2024 16:46:19 +0300 Andy Shevchenko…
Quoted 2 lines · Jonathan Cameron
On Thu, 03 Oct 2024 23:04:58 +0200
Javier Carrasco <[email protected]> wrote:
Quoted 9 lines
...
Quoted 4 lines
Quoted 1 line
Fixes 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the patch description to refer to the bm1390 which seems to be the right name and add a note on this as it looks suspect otherwise.
Fixes tag shouldn't be mangled, even if it has a typo.
Agreed. I added a note above it and modified name of this patch to reflect the correct driver.
Jonathan
PATCH 13/13 iio: proximity: mb1232: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/proximity/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/proximity/Kconfig +2 -0
@@ -86,6 +86,8 @@ config LIDAR_LITE_V2 config MB1232 tristate "MaxSonar I2CXL family ultrasonic sensors" depends on I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say Y to build a driver for the ultrasonic sensors I2CXL of MaxBotix which have an i2c interface. It can be used to measure
Signature · 1 line
2.43.0
Re: [PATCH 13/13] iio: proximity: mb1232: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Quoted 7 lines · On Thu, 03 Oct 2024 23:04:59 +0200 Javier Carrasco…
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 16b05261537e ("mb1232.c: add distance iio sensor with i2c")Signed-off-by Javier Carrasco <[email protected]>
Applied.
Thanks for going through looking for these. Hopefully this will reduce chance of us getting a rand config hitting this in the future!
Jonathan
Quoted 18 lines
--- drivers/iio/proximity/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/proximity/Kconfig +2
-0@@ -86,6 +86,8 @@ config LIDAR_LITE_V2 config MB1232 tristate "MaxSonar I2CXL family ultrasonic sensors" depends on I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say Y to build a driver for the ultrasonic sensors I2CXL of MaxBotix which have an i2c interface. It can be used to measure