kasan: add workqueue and timer stack for generic KASAN
Subsystems (2)
v3 cover kasan: add workqueue and timer stack for generic KASAN
Syzbot reports many UAF issues for workqueue or timer, see [1] and [2]. In some of these access/allocation happened in process_one_work(), we see the free stack is useless in KASAN report, it doesn't help programmers to solve UAF on workqueue. The same may stand for times.
This patchset improves KASAN reports by making them to have workqueue queueing stack and timer stack information. It is useful for programmers to solve use-after-free or double-free memory issue.
Generic KASAN also records the last two workqueue and timer stacks and prints them in KASAN report. It is only suitable for generic KASAN.
[1]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22+process_one_work [2]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22%20expire_timers [3]https://bugzilla.kernel.org/show_bug.cgi?id=198437
Walter Wu (6):
timer: kasan: record timer stack
workqueue: kasan: record workqueue stack
kasan: print timer and workqueue stacklib/test_kasan.c: add timer test caselib/test_kasan.c: add workqueue test case
kasan: update documentation for generic kasan
---
Changes since v2:
- modify kasan document to be more readable.
Thanks for Marco suggestion.
Changes since v1:
- Thanks for Marco and Thomas suggestion.
- Remove unnecessary code and fix commit log
- reuse kasan_record_aux_stack() and aux_stack
to record timer and workqueue stack.
- change the aux stack title for common name.
---
Documentation/dev-tools/kasan.rst | 4 ++-- kernel/time/timer.c | 3 +++ kernel/workqueue.c | 3 +++ lib/test_kasan.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ mm/kasan/report.c | 4 ++-- 5 files changed, 64 insertions(+), 4 deletions(-)
Quoted 17 lines · Walter Wu
Syzbot reports many UAF issues for workqueue or timer, see [1] and [2]. In some of these access/allocation happened in
process_one_work(), we see the free stack is useless in KASAN report, it doesn't help programmers to solve UAF on workqueue. The same may stand for times.This patchset improves KASAN reports by making them to have workqueue queueing stack and timer stack information. It is useful for programmers to solve use-after-free or double-free memory issue.
Generic KASAN also records the last two workqueue and timer stacks and prints them in KASAN report. It is only suitable for generic KASAN.
[1]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22+process_one_work [2]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22%20expire_timers [3]https://bugzilla.kernel.org/show_bug.cgi?id=198437
Quoted 7 lines
Walter Wu (6):
timer: kasan: record timer stack
workqueue: kasan: record workqueue stack
kasan: print timer and workqueue stacklib/test_kasan.c: add timer test caselib/test_kasan.c: add workqueue test case
kasan: update documentation for generic kasan
Quoted 26 lines
---
Changes since v2:
- modify kasan document to be more readable.
Thanks for Marco suggestion.Changes since v1:
- Thanks for Marco and Thomas suggestion.
- Remove unnecessary code and fix commit log
- reusekasan_record_aux_stack()andaux_stack
to record timer and workqueue stack.
- change the aux stack title for common name.---
Documentation/dev-tools/kasan.rst | 4 ++-- kernel/time/timer.c | 3 +++ kernel/workqueue.c | 3 +++ lib/test_kasan.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ mm/kasan/report.c | 4 ++-- 5 files changed, 64 insertions(+), 4 deletions(-)--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20200825015654.27781-1-walter-zh.wu%40mediatek.com.
Andrey Konovalov
Reviewed-byQuoted 27 lines · Marco Elver' via kasan-dev
Quoted 17 lines · Walter Wu
Syzbot reports many UAF issues for workqueue or timer, see [1] and [2]. In some of these access/allocation happened in
process_one_work(), we see the free stack is useless in KASAN report, it doesn't help programmers to solve UAF on workqueue. The same may stand for times.This patchset improves KASAN reports by making them to have workqueue queueing stack and timer stack information. It is useful for programmers to solve use-after-free or double-free memory issue.
Generic KASAN also records the last two workqueue and timer stacks and prints them in KASAN report. It is only suitable for generic KASAN.
[1]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22+process_one_work [2]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22%20expire_timers [3]https://bugzilla.kernel.org/show_bug.cgi?id=198437
Quoted 7 lines
Walter Wu (6):
timer: kasan: record timer stack
workqueue: kasan: record workqueue stack
kasan: print timer and workqueue stacklib/test_kasan.c: add timer test caselib/test_kasan.c: add workqueue test case
kasan: update documentation for generic kasan
Quoted 1 line
Acked-by Marco Elver <[email protected]>
Quoted 34 lines
Quoted 25 lines
---
Changes since v2:
- modify kasan document to be more readable.
Thanks for Marco suggestion.Changes since v1:
- Thanks for Marco and Thomas suggestion.
- Remove unnecessary code and fix commit log
- reusekasan_record_aux_stack()andaux_stack
to record timer and workqueue stack.
- change the aux stack title for common name.---
Documentation/dev-tools/kasan.rst | 4 ++-- kernel/time/timer.c | 3 +++ kernel/workqueue.c | 3 +++ lib/test_kasan.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ mm/kasan/report.c | 4 ++-- 5 files changed, 64 insertions(+), 4 deletions(-)Quoted 4 lines
--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20200825015654.27781-1-walter-zh.wu%40mediatek.com.--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/CANpmjNOvj%2B%3Dv7VDVDXpsUNZ9o0%2BKoJVJs0MjLhwr0XpYcYQZ5g%40mail.gmail.com.
Dmitry Vyukov
Reviewed-byQuoted 30 lines · Andrey Konovalov' via kasan-dev
Quoted 27 lines · Marco Elver' via kasan-dev
Quoted 24 lines · Walter Wu
Syzbot reports many UAF issues for workqueue or timer, see [1] and [2]. In some of these access/allocation happened in
process_one_work(), we see the free stack is useless in KASAN report, it doesn't help programmers to solve UAF on workqueue. The same may stand for times.This patchset improves KASAN reports by making them to have workqueue queueing stack and timer stack information. It is useful for programmers to solve use-after-free or double-free memory issue.
Generic KASAN also records the last two workqueue and timer stacks and prints them in KASAN report. It is only suitable for generic KASAN.
[1]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22+process_one_work [2]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22%20expire_timers [3]https://bugzilla.kernel.org/show_bug.cgi?id=198437
Walter Wu (6):
timer: kasan: record timer stack
workqueue: kasan: record workqueue stack
kasan: print timer and workqueue stacklib/test_kasan.c: add timer test caselib/test_kasan.c: add workqueue test case
kasan: update documentation for generic kasan
Quoted 3 lines
Quoted 1 line
Acked-by Marco Elver <[email protected]>Reviewed-by Andrey Konovalov <[email protected]>
Thanks! The UAF reports with RCU stacks that I see now are just 🔥🔥🔥
Quoted 36 lines
Quoted 27 lines
Quoted 22 lines
---
Changes since v2:
- modify kasan document to be more readable.
Thanks for Marco suggestion.Changes since v1:
- Thanks for Marco and Thomas suggestion.
- Remove unnecessary code and fix commit log
- reusekasan_record_aux_stack()andaux_stack
to record timer and workqueue stack.
- change the aux stack title for common name.---
Documentation/dev-tools/kasan.rst | 4 ++-- kernel/time/timer.c | 3 +++ kernel/workqueue.c | 3 +++ lib/test_kasan.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ mm/kasan/report.c | 4 ++-- 5 files changed, 64 insertions(+), 4 deletions(-)Quoted 4 lines
--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20200825015654.27781-1-walter-zh.wu%40mediatek.com.Quoted 4 lines
--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/CANpmjNOvj%2B%3Dv7VDVDXpsUNZ9o0%2BKoJVJs0MjLhwr0XpYcYQZ5g%40mail.gmail.com.--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/CAAeHK%2ByVShDPCxVKDsO_5SwoM2ZG7x7byUJ74PtB7ekY61L2YQ%40mail.gmail.com.
Quoted 38 lines · Dmitry Vyukov
Quoted 5 lines · Andrey Konovalov' via kasan-dev
Quoted 2 lines · Marco Elver' via kasan-dev
On Tue, 25 Aug 2020 at 03:57, Walter Wu <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Syzbot reports many UAF issues for workqueue or timer, see [1] and
[2].
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
In some of these access/allocation happened in
process_one_work(), we see the free stack is useless in KASAN report, it doesn't help programmers to solve UAF on workqueue. The same may stand for times.This patchset improves KASAN reports by making them to have workqueue queueing stack and timer stack information. It is useful for
programmers
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
to solve use-after-free or double-free memory issue.
Generic KASAN also records the last two workqueue and timer stacks
and
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
prints them in KASAN report. It is only suitable for generic KASAN.
[1]
https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22+process_one_work
Quoted 1 line
Quoted 1 line
Quoted 1 line
[2]
https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22%20expire_timers
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
[3]https://bugzilla.kernel.org/show_bug.cgi?id=198437
Walter Wu (6):
timer: kasan: record timer stack
workqueue: kasan: record workqueue stack
kasan: print timer and workqueue stacklib/test_kasan.c: add timer test caselib/test_kasan.c: add workqueue test case
kasan: update documentation for generic kasan
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Acked-by Marco Elver <[email protected]>Reviewed-by Andrey Konovalov <[email protected]>Reviewed-by Dmitry Vyukov <[email protected]>Thanks! The UAF reports with RCU stacks that I see now are just 🔥🔥🔥
Hi Walter,
This patchset needs to be rebased onto the KASAN-KUNIT patches, which just recently went into the mm tree.
Thanks!
Quoted 57 lines · Andrey Konovalov
On Sun, Sep 13, 2020 at 12:17 PM Dmitry Vyukov <[email protected]> wrote:
On Wed, Aug 26, 2020 at 2:30 PM 'Andrey Konovalov' via kasan-dev
<[email protected]> wrote:
>
> On Tue, Aug 25, 2020 at 10:26 AM 'Marco Elver' via kasan-dev > <[email protected]> wrote:
> >
> > On Tue, 25 Aug 2020 at 03:57, Walter Wu <[email protected]> wrote:
> > >
> > > Syzbot reports many UAF issues for workqueue or timer, see [1] and [2].
> > > In some of these access/allocation happened inprocess_one_work(),
> > > we see the free stack is useless in KASAN report, it doesn't help
> > > programmers to solve UAF on workqueue. The same may stand for times.
> > >
> > > This patchset improves KASAN reports by making them to have workqueue
> > > queueing stack and timer stack information. It is useful for programmers
> > > to solve use-after-free or double-free memory issue. > > >
> > > Generic KASAN also records the last two workqueue and timer stacks and
> > > prints them in KASAN report. It is only suitable for generic KASAN.
> > >
> > > [1]https://groups.google.com/g/syzkaller-bugs/search?q=% 22use-after-free%22+process_one_work
> > > [2]https://groups.google.com/g/syzkaller-bugs/search?q=% 22use-after-free%22%20expire_timers
> > > [3]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > >
> > > Walter Wu (6):
> > > timer: kasan: record timer stack
> > > workqueue: kasan: record workqueue stack
> > > kasan: print timer and workqueue stack
> > >lib/test_kasan.c: add timer test case
> > >lib/test_kasan.c: add workqueue test case
> > > kasan: update documentation for generic kasan > >
> > Acked-by: Marco Elver <[email protected]>
>
> Reviewed-by: Andrey Konovalov <[email protected]>Reviewed-by Dmitry Vyukov <[email protected]>Thanks! The UAF reports with RCU stacks that I see now are just 🔥🔥🔥
Quoted 8 lines
Hi Walter,
This patchset needs to be rebased onto the KASAN-KUNIT patches, which just recently went into the mm tree.
Thanks!
Hi Dmitry, Andrey,
Got it.
Thanks for your review and reminder.
Walter