Skip to contentSkip to conversation

Use memset_io to access I/O memory

PATCH In review Shane Chien 2 participants 4 messages Sep 18, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Use memset_io to access I/O memory

From: "Shane.Chien" <[email protected]>

Use memset_io to access I/O memory, instead of
memset.

Shane.Chien (1):
ASoC: Use memset_io to access I/O memory

 sound/core/pcm_native.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 5 lines
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#1 lore raw

PATCH 1/1 ASoC: Use memset_io to access I/O memory

From: "Shane.Chien" <[email protected]>

Use memset_io to access I/O memory, instead of
memset.

---
 sound/core/pcm_native.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/pcm_native.c +1 -1
index 9e0b2d7..a4efa84 100644
@@ -756,7 +756,7 @@ static int snd_pcm_hw_params(struct snd_pcm_substream *substream,
 
 	/* clear the buffer for avoiding possible kernel info leaks */
 	if (runtime->dma_area && !substream->ops->copy_user)
-		memset(runtime->dma_area, 0, runtime->dma_bytes);
+		memset_io(runtime->dma_area, 0, runtime->dma_bytes);
 
 	snd_pcm_timer_resolution_change(substream);
 	snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP);
Signature · 5 lines
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#2 lore raw

Re: [PATCH] ASoC: Use memset_io to access I/O memory

sound/core/pcm_native.c static int snd_pcm_hw_params(struct snd_pcm_substream *substream, · line 759

Quoted 4 lines · Shane Chien
sound/core/pcm_native.c +1 -1
 	/* clear the buffer for avoiding possible kernel info leaks */
 	if (runtime->dma_area && !substream->ops->copy_user)
-		memset(runtime->dma_area, 0, runtime->dma_bytes);
+		memset_io(runtime->dma_area, 0, runtime->dma_bytes);

This is regular RAM that will be accessed by the devices rather than memory mapped regions provided by devices, the _io variants are normally for memory mapped regions on devices.

#3 lore raw
In reply to Shane Chien
Quoted 4 lines · Shane Chien

From: "Shane.Chien" <[email protected]>

Use memset_io to access I/O memory, instead of
memset.

Please don't send cover letters for single patches, if there is anything that needs saying put it in the changelog of the patch or after the --- if it's administrative stuff. This reduces mail volume and ensures that any important information is recorded in the changelog rather than being lost.