ext4: delete invalid comments near mb_buddy_adjust_border
PATCH 1/1 ext4: delete invalid comments near mb_buddy_adjust_border
From: Chunguang Xu <[email protected]>
The comment near mb_buddy_adjust_border seems meaningless, just clear it.
Signed-off-by Chunguang Xu <[email protected]>
--- fs/ext4/mballoc.c | 3 --- 1 file changed, 3 deletions(-)
fs/ext4/mballoc.c +0 -3
@@ -1397,9 +1397,6 @@ void ext4_set_bits(void *bm, int cur, int len) } } -/* -* _________________________________________________________________ */ -static inline int mb_buddy_adjust_border (int * bit,void * bitmap,int side) {if (mb_test_bit (*bit + side, bitmap)) {
Signature · 1 line
1.8.3.1
PATCH 1/1 ext4: make mb_check_counter per group
From: Chunguang Xu <[email protected]>
Make bb_check_counter per group, so each group has the same chance to be checked, which can expose errors more easily.
Signed-off-by Chunguang Xu <[email protected]>
--- fs/ext4/ext4.h | 3 +++ fs/ext4/mballoc.c | 7 ++----- 2 files changed, 5 insertions(+), 5 deletions(-)
fs/ext4/ext4.h +3 -0
@@ -3153,6 +3153,9 @@ int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset,struct ext4_group_info {unsigned long bb_state; +#ifdef AGGRESSIVE_CHECK +unsigned long bb_check_counter; +#endif struct rb_root bb_free_root;ext4_grpblk_t bb_first_free;/* first free block */ ext4_grpblk_t bb_free;/* total free blocks */
fs/ext4/mballoc.c +2 -5
@@ -619,11 +619,8 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,void *buddy;void *buddy2; - { -static int mb_check_counter; -if (mb_check_counter++ %100 !=0 ) -return 0 ; - } +if (e4b->bd_info->bb_check_counter++ %10 ) +return 0 ;while (order >1 ) { buddy =mb_find_buddy (e4b, order, &max);
Signature · 1 line
1.8.3.1
Re: [PATCH] ext4: make mb_check_counter per group
Quoted 6 lines · Chunguang Xu
From: Chunguang Xu <[email protected]>
Make
bb_check_counterper group, so each group has the same chance to be checked, which can expose errors more easily.Signed-off-by Chunguang Xu <[email protected]>
Applied, thanks.
- Ted
Quoted 6 lines · Chunguang Xu
From: Chunguang Xu <[email protected]>
The comment near
mb_buddy_adjust_borderseems meaningless, just clear it.Signed-off-by Chunguang Xu <[email protected]>
Applied, thanks.
- Ted