Skip to contentSkip to conversation

ath11k: remove auto_start from channel config struct

PATCH In review Kalle Valo 1 participant 3 messages Sep 29, 2020 – Oct 1, 2020

Subsystems (3)
lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

PATCH v2 1/1 ath11k: remove auto_start from channel config struct

From: Manivannan Sadhasivam <[email protected]>

Recent change in MHI bus removed the option to auto start the channels during MHI driver probe. The channel will only be started when the MHI client driver like QRTR gets probed. So, remove the option from ath11k channel config struct.

Fixes 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")

---

v2

* cc also linux-wireless so that this goes to patchwork

 drivers/net/wireless/ath/ath11k/mhi.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/wireless/ath/ath11k/mhi.c +0 -4
index aded9a719d51..47a1ce1bee4f 100644
@@ -24,7 +24,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = false,
-		.auto_start = false,
 	},
 	{
 		.num = 1,
@@ -39,7 +38,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = false,
-		.auto_start = false,
 	},
 	{
 		.num = 20,
@@ -54,7 +52,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = false,
-		.auto_start = true,
 	},
 	{
 		.num = 21,
@@ -69,7 +66,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
 		.offload_channel = false,
 		.doorbell_mode_switch = false,
 		.auto_queue = true,
-		.auto_start = true,
 	},
 };
 
Signature · 1 line
2.7.4
author
#1 lore raw
Quoted 9 lines · Kalle Valo

Recent change in MHI bus removed the option to auto start the channels during MHI driver probe. The channel will only be started when the MHI client driver like QRTR gets probed. So, remove the option from ath11k channel config struct.

Fixes 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")

To avoid breaking ath11k we decided to postpone this change after the merge window, it's a lot easier to deal at that time.

Patch set to Changes Requested.

Signature · 3 lines
https://patchwork.kernel.org/patch/11805307/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
author
#2 lore raw
In reply to Kalle Valo
Quoted 9 lines · Kalle Valo

Recent change in MHI bus removed the option to auto start the channels during MHI driver probe. The channel will only be started when the MHI client driver like QRTR gets probed. So, remove the option from ath11k channel config struct.

Fixes 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")

To avoid breaking ath11k we decided to postpone this change after the merge window, it's a lot easier to deal at that time.

Patch set to Changes Requested.

Signature · 9 lines
https://patchwork.kernel.org/patch/11805307/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k