Skip to contentSkip to conversation

Allow building Tegra video driver with COMPILE_TEST

PATCH In review Sowjanya Komatineni 3 participants 6 messages Sep 30, 2020 – Oct 30, 2020

Subsystems (6)
lore
Share & tools
lore

Sowjanya Komatineni

author maintainer
#0 lore raw

cover Allow building Tegra video driver with COMPILE_TEST

This series enables COMPILE_TEST for Tegra video driver.

Tegra video driver has dependency on host1x driver. So this series also includes a patch to allow building host1x driver with COMPILE_TEST for all platforms.

Sowjanya Komatineni (2):
gpu: host1x: Allow COMPILE_TEST to build host1x driver on all
platforms
media: tegra-video: Allow building driver with COMPILE_TEST

 drivers/gpu/host1x/Kconfig                | 2 +-
 drivers/staging/media/tegra-video/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
author maintainer
#1 lore raw

PATCH 1/2 gpu: host1x: Allow COMPILE_TEST to build host1x driver on all platforms

Tegra V4L2 driver has dependency on this host1x driver and currently host1x driver is allowed to build with COMPILE_TEST only on ARM and this also limits Tegra V4L2 driver building.

So, this patch allows building host1x driver with COMPILE_TEST on all platforms.

---
 drivers/gpu/host1x/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/host1x/Kconfig +1 -1
index 6dab94a..977a0ac 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config TEGRA_HOST1X
 	tristate "NVIDIA Tegra host1x driver"
-	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+	depends on ARCH_TEGRA || COMPILE_TEST
 	select IOMMU_IOVA
 	help
 	  Driver for the NVIDIA Tegra host1x hardware.
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH v1 1/2] gpu: host1x: Allow COMPILE_TEST to build host1x driver on all platforms

Thierry,

Quoted 6 lines · Sowjanya Komatineni

Tegra V4L2 driver has dependency on this host1x driver and currently host1x driver is allowed to build with COMPILE_TEST only on ARM and this also limits Tegra V4L2 driver building.

So, this patch allows building host1x driver with COMPILE_TEST on all platforms.

Can you Ack/Review this so I can merge both patches for v5.11? If you prefer to merge this on your side, then I can Ack patch 2/2 as well, but I think it makes more sense if this goes through the media subsystem.

Regards,

Hans

Quoted 20 lines
---
 drivers/gpu/host1x/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/host1x/Kconfig +1 -1
index 6dab94a..977a0ac 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config TEGRA_HOST1X
 	tristate "NVIDIA Tegra host1x driver"
-	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+	depends on ARCH_TEGRA || COMPILE_TEST
 	select IOMMU_IOVA
 	help
 	  Driver for the NVIDIA Tegra host1x hardware.
author maintainer
#3 lore raw

PATCH 2/2 media: tegra-video: Allow building driver with COMPILE_TEST

In reply to Sowjanya Komatineni

This patch adds COMPILE_TEST option to Kconfig to allow building it with COMPILE_TEST option.

---
 drivers/staging/media/tegra-video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-video/Kconfig +1 -1
index 1f35da4..3e03ddd 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config VIDEO_TEGRA
 	tristate "NVIDIA Tegra VI driver"
-	depends on TEGRA_HOST1X
+	depends on TEGRA_HOST1X || COMPILE_TEST
 	depends on VIDEO_V4L2
 	select MEDIA_CONTROLLER
 	select VIDEOBUF2_DMA_CONTIG
Signature · 1 line
2.7.4
#4 lore raw

Re: [PATCH v1 2/2] media: tegra-video: Allow building driver with COMPILE_TEST

Quoted 2 lines · Sowjanya Komatineni

This patch adds COMPILE_TEST option to Kconfig to allow building it with COMPILE_TEST option.

Does it build without TEGRA_HOST1X selected? Isn't the previous patch enough to allow the build with COMPILE_TEST?

Best Regards,
Michał Mirosław

author maintainer
#5 lore raw

Re: [PATCH v1 2/2] media: tegra-video: Allow building driver with COMPILE_TEST

Quoted 8 lines · Michał Mirosław
Quoted 2 lines · Sowjanya Komatineni

This patch adds COMPILE_TEST option to Kconfig to allow building it with COMPILE_TEST option.

Does it build without TEGRA_HOST1X selected? Isn't the previous patch enough to allow the build with COMPILE_TEST?

Best Regards,
Michał Mirosław

No, it does not build without selecting CONFIG_TEGRA_HOST1X along with CONFIG_VIDEO_TEGRA