Bluetooth: hci_qca: Enhance retry logic in qca_setup
PATCH 1/1 Bluetooth: hci_qca: Enhance retry logic in qca_setup
Currently driver only retries to download FW if FW downloading is failed. Sometimes observed command timeout for version request command, if this happen on some platforms during boot time, then a reboot is needed to turn ON BT. Instead to avoid a reboot, now extended retry logic for version request command too.
Signed-off-by Balakrishna Godavarthi <[email protected]>
--- drivers/bluetooth/hci_qca.c | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-)
drivers/bluetooth/hci_qca.c +18 -16
@@ -1672,7 +1672,7 @@ static int qca_setup(struct hci_uart *hu) retry: ret =qca_power_on (hdev);if (ret) -return ret; + goto out;clear_bit (QCA_SSR_TRIGGERED , &qca->flags);
@@ -1681,7 +1681,7 @@ static int qca_setup(struct hci_uart *hu) ret =qca_read_soc_version (hdev, &soc_ver, soc_type);if (ret) -return ret; + goto out; }else {qca_set_speed (hu,QCA_INIT_SPEED ); }
@@ -1691,7 +1691,7 @@ static int qca_setup(struct hci_uart *hu)if (speed) { ret =qca_set_speed (hu,QCA_OPER_SPEED );if (ret) -return ret; + goto out; qca_baudrate =qca_get_baudrate_value (speed); }
@@ -1700,7 +1700,7 @@ static int qca_setup(struct hci_uart *hu)/* Get QCA version information */ ret =qca_read_soc_version (hdev, &soc_ver, soc_type);if (ret) -return ret; + goto out; }bt_dev_info (hdev,"QCA controller version 0x%08x" , soc_ver);
@@ -1721,20 +1721,22 @@ static int qca_setup(struct hci_uart *hu)* patch/nvm-config is found, so run with original fw/config. */ ret =0 ; - }else { -if (retries <MAX_INIT_RETRIES ) { -qca_power_shutdown (hu); -if (hu->serdev) { -serdev_device_close (hu->serdev); - ret =serdev_device_open (hu->serdev); -if (ret) { -bt_dev_err (hdev,"failed to open port" ); -return ret; - } + } + +out: +if (ret && retries <MAX_INIT_RETRIES ) { +bt_dev_warn (hdev,"Retry BT power ON:%d" , retries); +qca_power_shutdown (hu); +if (hu->serdev) { +serdev_device_close (hu->serdev); + ret =serdev_device_open (hu->serdev); +if (ret) { +bt_dev_err (hdev,"failed to open port" ); +return ret; } - retries++; - goto retry; } + retries++; + goto retry; }/* Setup bdaddr */
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Reviewed-by Abhishek Pandit-Subedi <[email protected]>
Quoted 8 lines · Balakrishna Godavarthi
Currently driver only retries to download FW if FW downloading is failed. Sometimes observed command timeout for version request command, if this happen on some platforms during boot time, then a reboot is needed to turn ON BT. Instead to avoid a reboot, now extended retry logic for version request command too.
Signed-off-by Balakrishna Godavarthi <[email protected]>