Skip to contentSkip to conversation

Add board support for HK10 board variants

PATCH Superseded Gokul Sriram Palanisamy 4 participants 10 messages Oct 8, 2020 – Oct 9, 2020

Subsystems (4)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add board support for HK10 board variants

Added support for HK10-C1 and HK10-C2 board variants based on IPQ8074 SoC. Both these variants support dual QCN9000 PCIe cards that uses MHI communication protocol over PCIe. In addition, HK10-C1 support on-chip radio. Both these variants slightly differ in clock configuation for ethernet.

This series depends on below series:
[V2,0/7] Add PCIe support for IPQ8074
[v7,0/9] remoteproc: qcom: q6v5-wcss: Add support for secure pil

changes since v2:
- In patch 3, Moved pcie0_rp and pcie1_rp nodes and removed unused members and subnodes

Gokul Sriram Palanisamy (3):
dt-bindings: qcom: Add ipq8074 bindings
arm64: dts: Add board support for HK10
arm64: dts: Enabled MHI device over PCIe

 Documentation/devicetree/bindings/arm/qcom.yaml |   4 +
 arch/arm64/boot/dts/qcom/Makefile               |   2 +
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts    |  11 +++
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts    |  14 +++
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi      | 123 ++++++++++++++++++++++++
 5 files changed, 154 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/3 dt-bindings: qcom: Add ipq8074 bindings

Document the new device-tree bindings for boards
HK10-C1 and HK10-C2 based on ipq8074 SoC.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +4 -0
index 6031aee..7b294be 100644
@@ -47,6 +47,8 @@ description: |
         cp01-c1
         dragonboard
         hk01
+        hk10-c1
+        hk10-c2
         idp
         liquid
         mtp
@@ -148,6 +150,8 @@ properties:
       - items:
           - enum:
               - qcom,ipq8074-hk01
+              - qcom,ipq8074-hk10-c1
+              - qcom,ipq8074-hk10-c2
           - const: qcom,ipq8074
 
       - items:
Signature · 1 line
2.7.4
#2 lore raw

PATCH v3 2/3 arm64: dts: Add board support for HK10

In reply to Gokul Sriram Palanisamy

Add initial support for IPQ8074 SoC based HK10-C1
and HK10-C2 evaluation boards.

---
 arch/arm64/boot/dts/qcom/Makefile            |  2 +
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts | 11 ++++
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts | 14 +++++
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi   | 76 ++++++++++++++++++++++++++++
 4 files changed, 103 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
arch/arm64/boot/dts/qcom/Makefile +2 -0
index d8f1466..7e628fe 100644
@@ -4,6 +4,8 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c1.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-longcheer-l8150.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-a3u-eur.dtb
arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts new file +11 -0
new file mode 100644
index 0000000..2bfcf42
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* Copyright (c) 2020 The Linux Foundation. All rights reserved.
+ */
+/dts-v1/;
+
+#include "ipq8074-hk10.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ8074/AP-HK10-C1";
+	compatible = "qcom,ipq8074-hk10-c1", "qcom,ipq8074";
+};
arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts new file +14 -0
new file mode 100644
index 0000000..1897e96
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/dts-v1/;
+/* Copyright (c) 2020 The Linux Foundation. All rights reserved.
+ */
+#include "ipq8074-hk10.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ8074/AP-HK10-C2";
+	compatible = "qcom,ipq8074-hk10-c2", "qcom,ipq8074";
+};
+
+&q6v5_wcss {
+	status = "disabled";
+};
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi new file +76 -0

76 lines not on this page · raw message

Signature · 1 line
2.7.4
#3 lore raw

PATCH v3 3/3 arm64: dts: Enabled MHI device over PCIe

In reply to Gokul Sriram Palanisamy

Enabled MHI device support over PCIe and added memory reservation required for MHI enabled QCN9000 PCIe card.

---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 ++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +47 -0
index 0827055..e5c1ec0 100644
@@ -24,6 +24,22 @@
 		device_type = "memory";
 		reg = <0x0 0x40000000 0x0 0x20000000>;
 	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		qcn9000_pcie0: memory@50f00000 {
+			no-map;
+			reg = <0x0 0x50f00000 0x0 0x03700000>;
+		};
+
+		qcn9000_pcie1: memory@54600000 {
+			no-map;
+			reg = <0x0 0x54600000 0x0 0x03700000>;
+		};
+	};
 };
 
 &blsp1_spi1 {
@@ -45,11 +61,42 @@
 &pcie0 {
 	status = "ok";
 	perst-gpio = <&tlmm 58 0x1>;
+
+	pcie0_rp: pcie0_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_0: qcom,mhi@0 {
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x20>;
+			base-addr = <0x50f00000>;
+			m3-dump-addr = <0x53c00000>;
+			etr-addr = <0x53d00000>;
+			qcom,caldb-addr = <0x53e00000>;
+		};
+	};
 };
 
 &pcie1 {
 	status = "ok";
 	perst-gpio = <&tlmm 61 0x1>;
+
+	pcie1_rp: pcie1_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_1: qcom,mhi@1 {
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x21>;
+			base-addr = <0x54600000>;
+			m3-dump-addr = <0x57300000>;
+			etr-addr = <0x57400000>;
+			qcom,caldb-addr = <0x57500000>;
+			};
+		};
+	};
 };
 
 &qmp_pcie_phy0 {
Signature · 1 line
2.7.4
#4 lore raw

Re: [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe

Hi,

Quoted 36 lines · Gokul Sriram Palanisamy

Enabled MHI device support over PCIe and added memory reservation required for MHI enabled QCN9000 PCIe card.

---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 ++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +16 -0
index 0827055..e5c1ec0 100644
@@ -24,6 +24,22 @@
 		device_type = "memory";
 		reg = <0x0 0x40000000 0x0 0x20000000>;
 	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		qcn9000_pcie0: memory@50f00000 {
+			no-map;
+			reg = <0x0 0x50f00000 0x0 0x03700000>;
+		};
+
+		qcn9000_pcie1: memory@54600000 {
+			no-map;
+			reg = <0x0 0x54600000 0x0 0x03700000>;
+		};
+	};
 };
 
 &blsp1_spi1 {

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi line 69

Quoted 9 lines
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +6 -0
@@ -45,11 +61,42 @@
 &pcie0 {
 	status = "ok";
 	perst-gpio = <&tlmm 58 0x1>;
+
+	pcie0_rp: pcie0_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_0: qcom,mhi@0 {

MHI doesn't support devicetree as of now so how is this supposed to work? Have you tested this series with mainline?

Thanks,
Mani

Quoted 36 lines
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +25 -0
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x20>;
+			base-addr = <0x50f00000>;
+			m3-dump-addr = <0x53c00000>;
+			etr-addr = <0x53d00000>;
+			qcom,caldb-addr = <0x53e00000>;
+		};
+	};
 };
 
 &pcie1 {
 	status = "ok";
 	perst-gpio = <&tlmm 61 0x1>;
+
+	pcie1_rp: pcie1_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_1: qcom,mhi@1 {
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x21>;
+			base-addr = <0x54600000>;
+			m3-dump-addr = <0x57300000>;
+			etr-addr = <0x57400000>;
+			qcom,caldb-addr = <0x57500000>;
+			};
+		};
+	};
 };
 
 &qmp_pcie_phy0 {
Signature · 1 line
2.7.4
#5 lore raw

Re: [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe

Quoted 53 lines · Manivannan Sadhasivam

Hi,

Quoted 37 lines · Gokul Sriram Palanisamy

Enabled MHI device support over PCIe and added memory reservation required for MHI enabled QCN9000 PCIe card.

---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 
++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +16 -0
index 0827055..e5c1ec0 100644
@@ -24,6 +24,22 @@
 		device_type = "memory";
 		reg = <0x0 0x40000000 0x0 0x20000000>;
 	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		qcn9000_pcie0: memory@50f00000 {
+			no-map;
+			reg = <0x0 0x50f00000 0x0 0x03700000>;
+		};
+
+		qcn9000_pcie1: memory@54600000 {
+			no-map;
+			reg = <0x0 0x54600000 0x0 0x03700000>;
+		};
+	};
 };
 
 &blsp1_spi1 {

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi line 69

Quoted 9 lines
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +6 -0
@@ -45,11 +61,42 @@
 &pcie0 {
 	status = "ok";
 	perst-gpio = <&tlmm 58 0x1>;
+
+	pcie0_rp: pcie0_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_0: qcom,mhi@0 {

MHI doesn't support devicetree as of now so how is this supposed to work? Have you tested this series with mainline?

Quoted 3 lines

Thanks,
Mani

Hi Mani,
This node entries will be consumed by ath11k driver and is not supposed
to be consumed by mhi driver.
And yes, it is tested on Mainline.

Regards,
Gokul

Quoted 36 lines
Quoted 36 lines
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +25 -1
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x20>;
+			base-addr = <0x50f00000>;
+			m3-dump-addr = <0x53c00000>;
+			etr-addr = <0x53d00000>;
+			qcom,caldb-addr = <0x53e00000>;
+		};
+	};
 };
 
 &pcie1 {
 	status = "ok";
 	perst-gpio = <&tlmm 61 0x1>;
+
+	pcie1_rp: pcie1_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_1: qcom,mhi@1 {
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x21>;
+			base-addr = <0x54600000>;
+			m3-dump-addr = <0x57300000>;
+			etr-addr = <0x57400000>;
+			qcom,caldb-addr = <0x57500000>;
+			};
+		};
+	};
 };
 
 &qmp_pcie_phy0 {
--

2.7.4

#6 lore raw

Re: [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe

Quoted 18 lines · On Thu, Oct 08, 2020 at 11:03:42PM +0530, [email protected] wrote:
Quoted 17 lines · Manivannan Sadhasivam

Hi,

Quoted 14 lines · Gokul Sriram Palanisamy

Enabled MHI device support over PCIe and added memory reservation required for MHI enabled QCN9000 PCIe card.

---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47
++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +0 -0
index 0827055..e5c1ec0 100644

[...]

Quoted 10 lines
Quoted 10 lines

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi line 69

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +5 -0
+	pcie0_rp: pcie0_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_0: qcom,mhi@0 {

MHI doesn't support devicetree as of now so how is this supposed to work?
Have you tested this series with mainline?

Quoted 9 lines
Quoted 3 lines

Thanks,
Mani

Hi Mani,
This node entries will be consumed by ath11k driver and is not supposed to
be consumed by mhi driver.
And yes, it is tested on Mainline.

Can you please point me to the relevant binding or the code which consumes this change?

Also please explain what it does! For enabling MHI support over PCIe you don't need this node at all. You just need to define the PCIe device ID in the ath11k driver and that's it.

Adding Kalle to this thread...

Thanks,
Mani

Quoted 39 lines

Regards,
Gokul

Quoted 36 lines
Quoted 36 lines
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +25 -1
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x20>;
+			base-addr = <0x50f00000>;
+			m3-dump-addr = <0x53c00000>;
+			etr-addr = <0x53d00000>;
+			qcom,caldb-addr = <0x53e00000>;
+		};
+	};
 };
 
 &pcie1 {
 	status = "ok";
 	perst-gpio = <&tlmm 61 0x1>;
+
+	pcie1_rp: pcie1_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_1: qcom,mhi@1 {
+			reg = <0 0 0 0 0 >;
+
+			qrtr_instance_id = <0x21>;
+			base-addr = <0x54600000>;
+			m3-dump-addr = <0x57300000>;
+			etr-addr = <0x57400000>;
+			qcom,caldb-addr = <0x57500000>;
+			};
+		};
+	};
 };
 
 &qmp_pcie_phy0 {
--

2.7.4

#7 lore raw

Re: [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe

+ ath11k list

Quoted 32 lines · Manivannan Sadhasivam
Quoted 18 lines · On Thu, Oct 08, 2020 at 11:03:42PM +0530, [email protected] wrote:
Quoted 17 lines · Manivannan Sadhasivam

Hi,

Quoted 14 lines · Gokul Sriram Palanisamy

Enabled MHI device support over PCIe and added memory reservation required for MHI enabled QCN9000 PCIe card.

---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47
++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +0 -0
index 0827055..e5c1ec0 100644

[...]

Quoted 10 lines
Quoted 10 lines

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi line 69

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +5 -0
+	pcie0_rp: pcie0_rp {
+		reg = <0 0 0 0 0>;
+
+		status = "ok";
+		mhi_0: qcom,mhi@0 {

MHI doesn't support devicetree as of now so how is this supposed to work?
Have you tested this series with mainline?

Quoted 8 lines
Quoted 8 lines
Quoted 3 lines

Thanks,
Mani

Hi Mani,
This node entries will be consumed by ath11k driver and is not supposed to
be consumed by mhi driver.
And yes, it is tested on Mainline.

Upstream ath11k does not yet support QCN9074 so I don't see how this is tested with mainline ath11k. You must be using some out-of-tree _unofficial_ ath11k patches.

Quoted 8 lines

Can you please point me to the relevant binding or the code which consumes this change?

Also please explain what it does! For enabling MHI support over PCIe you don't need this node at all. You just need to define the PCIe device ID in the ath11k driver and that's it.

Adding Kalle to this thread...

So currently QCN9074 firmware needs 55 MB of contiguous host memory and I suspect one reason for these DT entries is an ugly hack to provide that memory range to the firmware.

We are currently preparing QCN9074 patches for ath11k and finding a solution how to implement these properly in ath11k. Hopefully there's no need for hacks like this, we know more once we get the ath11k QCN9074 patches ready. Please drop this patch.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#8 lore raw

Re: [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe

In reply to Gokul Sriram Palanisamy
Thank you for the patch! Yet something to improve:

Hi Gokul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.9-rc8]
[cannot apply to next-20201008]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r006-20201008 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d852c07655e85bfc07d8d3543698ce06e2ce62f8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356 git checkout d852c07655e85bfc07d8d3543698ce06e2ce62f8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi:100.1-2 syntax error

FATAL ERROR: Unable to parse input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#9 lore raw

Re: [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe

In reply to Gokul Sriram Palanisamy
Thank you for the patch! Yet something to improve:

Hi Gokul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.9-rc8]
[cannot apply to next-20201008]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r015-20201008 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 8da0df3d6dcc0dd42740be60b0da4ec201190904)

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/d852c07655e85bfc07d8d3543698ce06e2ce62f8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356 git checkout d852c07655e85bfc07d8d3543698ce06e2ce62f8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi:100.1-2 syntax error
>> FATAL ERROR: Unable to parse input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org