net: wireless: nl80211: fix out-of-bounds access in nl80211_del_key()
Subsystems (3)
PATCH 1/1 net: wireless: nl80211: fix out-of-bounds access in nl80211_del_key()
In nl80211_parse_key(), key.idx is first initialized as -1. If this value of key.idx remains unmodified and gets returned, and nl80211_key_allowed() also returns 0, then rdev_del_key() gets called with key.idx = -1.
This causes an out-of-bounds array access.
Handle this issue by checking if the value of key.idx after nl80211_parse_key() is called and return -EINVAL if key.idx < 0.
--- net/wireless/nl80211.c | 3 +++ 1 file changed, 3 insertions(+)
net/wireless/nl80211.c +3 -0
@@ -4172,6 +4172,9 @@ static int nl80211_del_key(struct sk_buff *skb, struct genl_info *info)if (err)return err; +if (key.idx <0 ) +return -EINVAL ; +if (info->attrs[NL80211_ATTR_MAC ]) mac_addr =nla_data (info->attrs[NL80211_ATTR_MAC ]);
Signature · 1 line
2.25.1
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 10 lines · On Wed, 7 Oct 2020 09:24:01 +0530 you wrote:
In
nl80211_parse_key(), key.idx is first initialized as -1. If this value of key.idx remains unmodified and gets returned, andnl80211_key_allowed()also returns 0, thenrdev_del_key()gets called with key.idx = -1.
This causes an out-of-bounds array access.Handle this issue by checking if the value of key.idx after
nl80211_parse_key()is called and return-EINVALif key.idx < 0.[...]
Here is the summary with links:
- net: wireless: nl80211: fix out-of-bounds access in nl80211_del_key()
https://git.kernel.org/netdev/net/c/3dc289f8f139
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees