Skip to contentSkip to conversation

arm64: dts: imx8mm: Correct WDOG_B pin configuration

PATCH Applied Anson Huang 3 participants 7 messages Oct 12, 2020 – Oct 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 arm64: dts: imx8mm: Correct WDOG_B pin configuration

Different revision of i.MX8MM EVK boards may have different external pull up registor design, some are enabled while some are NOT, to make sure the WDOG_B pin works properly, better to enable internal pull up resistor. Since enabling internal pull up resistor is NOT harmful and having benefit of flexibility on different board design, just enable it for all i.MX8MM boards; And schmitt input is NOT necessary for this WDOG_B output pin, so remove it; Open drain outputs provide more flexibility to a designer as they can be pulled-up to any voltage found in the system, so enable it as well.

---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.

---
 arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi        | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +1 -1
index 6de86a4..a941301 100644
@@ -398,7 +398,7 @@
 
 		pinctrl_wdog: wdoggrp {
 			fsl,pins = <
-				MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B		0xc6
+				MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B		0x166
 			>;
 		};
 
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +1 -1
index f305a53..469d570 100644
@@ -468,7 +468,7 @@
 
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
-			MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B	0xc6
+			MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B	0x166
 		>;
 	};
 };
arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi +1 -1
index 4107fe9..38e879d 100644
@@ -555,7 +555,7 @@
 
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
-			MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B	0xc6
+			MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B	0x166
 		>;
 	};
 };
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 2/3 arm64: dts: imx8mn: Correct WDOG_B pin configuration

Different revision of i.MX8MN EVK boards may have different external pull up registor design, some are enabled while some are NOT, to make sure the WDOG_B pin works properly, better to enable internal pull up resistor. Since enabling internal pull up resistor is NOT harmful and having benefit of flexibility on different board design, just enable it for all i.MX8MN boards; And schmitt input is NOT necessary for this WDOG_B output pin, so remove it; Open drain outputs provide more flexibility to a designer as they can be pulled-up to any voltage found in the system, so enable it as well.

---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.

---
 arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi     | 2 +-
 arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +1 -1
index 4aa0dbd..fda8905 100644
@@ -340,7 +340,7 @@
 
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
-			MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B		0xc6
+			MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B		0x166
 		>;
 	};
 };
arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi +1 -1
index a2d0190..dde01da 100644
@@ -545,7 +545,7 @@
 
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
-			MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B	0xc6
+			MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B	0x166
 		>;
 	};
 };
Signature · 1 line
2.7.4
Reviewed-by on v2 2/3
#2 lore raw

Re: [PATCH V2 2/3] arm64: dts: imx8mn: Correct WDOG_B pin configuration

Quoted 10 lines · Anson Huang

Different revision of i.MX8MN EVK boards may have different external pull up registor design, some are enabled while some are NOT, to make sure the WDOG_B pin works properly, better to enable internal pull up resistor. Since enabling internal pull up resistor is NOT harmful and having benefit of flexibility on different board design, just enable it for all i.MX8MN boards; And schmitt input is NOT necessary for this WDOG_B output pin, so remove it; Open drain outputs provide more flexibility to a designer as they can be pulled-up to any voltage found in the system, so enable it as well.

Quoted 8 lines

---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.

---
 arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi     | 2 +-
 arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Best regards,
Krzysztof

#3 lore raw

PATCH v2 3/3 arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration

In reply to Anson Huang

Different revision of i.MX8MP EVK boards may have different external pull up registor design, some are enabled while some are NOT, to make sure the WDOG_B pin works properly, better to enable internal pull up resistor. Since enabling internal pull up resistor is NOT harmful and having benefit of flexibility on different board design, just enable it for all i.MX8MP boards; And schmitt input is NOT necessary for this WDOG_B output pin, so remove it; Open drain outputs provide more flexibility to a designer as they can be pulled-up to any voltage found in the system, so enable it as well.

---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.

---
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mp-evk.dts +1 -1
index ad66f12..908b92b 100644
@@ -262,7 +262,7 @@
 
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
-			MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B	0xc6
+			MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B	0x166
 		>;
 	};
 };
Signature · 1 line
2.7.4
Reviewed-by on v2 3/3
#4 lore raw

Re: [PATCH V2 3/3] arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration

Quoted 10 lines · Anson Huang

Different revision of i.MX8MP EVK boards may have different external pull up registor design, some are enabled while some are NOT, to make sure the WDOG_B pin works properly, better to enable internal pull up resistor. Since enabling internal pull up resistor is NOT harmful and having benefit of flexibility on different board design, just enable it for all i.MX8MP boards; And schmitt input is NOT necessary for this WDOG_B output pin, so remove it; Open drain outputs provide more flexibility to a designer as they can be pulled-up to any voltage found in the system, so enable it as well.

Quoted 7 lines

---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.

---
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Best regards,
Krzysztof

Reviewed-by on v2 1/3
#5 lore raw
In reply to Anson Huang
Quoted 11 lines · Anson Huang

Different revision of i.MX8MM EVK boards may have different external pull up registor design, some are enabled while some are NOT, to make sure the WDOG_B pin works properly, better to enable internal pull up resistor. Since enabling internal pull up resistor is NOT harmful and having benefit of flexibility on different board design, just enable it for all i.MX8MM boards; And schmitt input is NOT necessary for this WDOG_B output pin, so remove it; Open drain outputs provide more flexibility to a designer as they can be pulled-up to any voltage found in the system, so enable it as well.

Quoted 8 lines

---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.

---
 arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi        | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Best regards,
Krzysztof

Applied
#6 lore raw
In reply to Anson Huang
Quoted 11 lines · Anson Huang

Different revision of i.MX8MM EVK boards may have different external pull up registor design, some are enabled while some are NOT, to make sure the WDOG_B pin works properly, better to enable internal pull up resistor. Since enabling internal pull up resistor is NOT harmful and having benefit of flexibility on different board design, just enable it for all i.MX8MM boards; And schmitt input is NOT necessary for this WDOG_B output pin, so remove it; Open drain outputs provide more flexibility to a designer as they can be pulled-up to any voltage found in the system, so enable it as well.

Applied all, thanks.