remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot
Subsystems (2)
PATCH v3 1/1 remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot
On secure devices which support warm reset, the MBA firmware requires access to the modem region to clear them out. Hence provide Q6 access to this region before MBA boot. This will be a nop during a modem SSR.
---
V3:
* Fixup comment style [Stephen]
V2:
* Fixup comments [Bjorn]
drivers/remoteproc/qcom_q6v5_mss.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
drivers/remoteproc/qcom_q6v5_mss.c +13 -3
@@ -931,6 +931,17 @@ static int q6v5_mba_load(struct q6v5 *qproc) goto assert_reset; } +/* +* Some versions of the MBA firmware will upon boot wipe the MPSS region as well, so provide +* the Q6 access to this region. +*/ + ret =q6v5_xfer_mem_ownership (qproc, &qproc->mpss_perm, false, true, + qproc->mpss_phys, qproc->mpss_size); +if (ret) { +dev_err (qproc->dev,"assigning Q6 access to mpss memory failed: %d\n" , ret); + goto disable_active_clks; + } +/* Assign MBA image access in DDR to q6 */ ret =q6v5_xfer_mem_ownership (qproc, &qproc->mba_perm, false, true, qproc->mba_phys, qproc->mba_size);
@@ -1135,10 +1146,9 @@ static int q6v5_mpss_load(struct q6v5 *qproc) max_addr =ALIGN (phdr->p_paddr + phdr->p_memsz,SZ_4K ); } -/** +/* * In case of a modem subsystem restart on secure devices, the modem -* memory can be reclaimed only after MBA is loaded. For modem cold -* boot this will be a nop +* memory can be reclaimed only after MBA is loaded. */ q6v5_xfer_mem_ownership (qproc, &qproc->mpss_perm, true, false, qproc->mpss_phys, qproc->mpss_size);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoting Sibi Sankar (2020-09-17 10:58:40)
Quoted 6 lines
On secure devices which support warm reset, the MBA firmware requires access to the modem region to clear them out. Hence provide Q6 access to this region before MBA boot. This will be a nop during a modem SSR.
Signed-off-by Sibi Sankar <[email protected]>---
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Quoted 8 lines · On Thu, 17 Sep 2020 23:28:40 +0530 you wrote:
On secure devices which support warm reset, the MBA firmware requires access to the modem region to clear them out. Hence provide Q6 access to this region before MBA boot. This will be a nop during a modem SSR.
Signed-off-by Sibi Sankar <[email protected]>---
[...]
Here is the summary with links:
- [v3] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot
https://git.kernel.org/andersson/remoteproc/c/4360f93ac39c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html