Skip to contentSkip to conversation

configs: mt8512: enable device mode of mtu3 explicitly

PATCH Superseded Chunfeng Yun 2 participants 7 messages Oct 14, 2020 – Oct 15, 2020 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 configs: mt8512: enable device mode of mtu3 explicitly

Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly, try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Fixes 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

---
v2: change fixes info suggested by Bin

---
 configs/mt8512_bm1_emmc_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/mt8512_bm1_emmc_defconfig +1 -0
index aaf59f52a8..c25a42cd3d 100644
@@ -53,6 +53,7 @@ CONFIG_DM_USB=y
 CONFIG_DM_USB_GADGET=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_MTU3=y
+CONFIG_USB_MTU3_GADGET=y
 # CONFIG_USB_MTU3_HOST is not set
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 1/1 configs: mt8512: enable device mode of mtu3 explicitly

Quoted 5 lines · Chunfeng Yun

Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly, try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Fixes 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Should I just squash this into ^ that commit in usb/next ?

#2 lore raw

PATCH v2 1/1 configs: mt8512: enable device mode of mtu3 explicitly

Quoted 8 lines · Marek Vasut
Quoted 5 lines · Chunfeng Yun

Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly, try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Fixes 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Should I just squash this into ^ that commit in usb/next ?

Fine to me if it can fix the build error, thanks

#3 lore raw

PATCH v2 1/1 configs: mt8512: enable device mode of mtu3 explicitly

Quoted 10 lines · Chunfeng Yun
Quoted 8 lines · Marek Vasut
Quoted 5 lines · Chunfeng Yun

Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly, try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Fixes 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Should I just squash this into ^ that commit in usb/next ?

Fine to me if it can fix the build error, thanks

So, can you please test it and then send me all the patches you want me to apply and possibly add a note in them if they should be squashed somewhere ?

Thanks

#4 lore raw

PATCH v2 1/1 configs: mt8512: enable device mode of mtu3 explicitly

Quoted 7 lines · Marek Vasut
Quoted 6 lines · Chunfeng Yun
Quoted 5 lines · Marek Vasut
Quoted 4 lines · Chunfeng Yun

Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly, try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Fixes 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Should I just squash this into ^ that commit in usb/next ?

Fine to me if it can fix the build error, thanks

So, can you please test it and then send me all the patches you want me to apply and possibly add a note in them if they should be squashed somewhere ?

Ok, I'll test and send them again, please apply them directly, that may be easier

Thanks a lot

Quoted 2 lines

Thanks

#5 lore raw

PATCH v2 1/1 configs: mt8512: enable device mode of mtu3 explicitly

In reply to Marek Vasut
Quoted 7 lines · Marek Vasut
Quoted 6 lines · Chunfeng Yun
Quoted 5 lines · Marek Vasut
Quoted 4 lines · Chunfeng Yun

Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly, try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Fixes 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Should I just squash this into ^ that commit in usb/next ?

Fine to me if it can fix the build error, thanks

So, can you please test it and then send me all the patches you want me to apply and possibly add a note in them if they should be squashed somewhere ?

As I explained in another email, just apply the following patch into
u-boot-usb/next will fix build error:
https://patchwork.ozlabs.org/project/uboot/patch/1602681717-20850-1-git-send-email-chunfeng.yun at mediatek.com/ [RESEND,v9] usb: add MediaTek USB3 DRD driver

Thank you

Quoted 2 lines

Thanks

#6 lore raw

PATCH v2 1/1 configs: mt8512: enable device mode of mtu3 explicitly

Quoted 13 lines · Chunfeng Yun
Quoted 12 lines · Marek Vasut
Quoted 10 lines · Chunfeng Yun
Quoted 8 lines · Marek Vasut
Quoted 5 lines · Chunfeng Yun

Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly, try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Fixes 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Should I just squash this into ^ that commit in usb/next ?

Fine to me if it can fix the build error, thanks

Quoted 7 lines
Quoted 3 lines

So, can you please test it and then send me all the patches you want me to apply and possibly add a note in them if they should be squashed somewhere ?

As I explained in another email, just apply the following patch into
u-boot-usb/next will fix build error:
https://patchwork.ozlabs.org/project/uboot/patch/1602681717-20850-1-git-send-email-chunfeng.yun at mediatek.com/ [RESEND,v9] usb: add MediaTek USB3 DRD driver

OK, so to make it easy, just rebase whatever you have left on usb/next and resend it.