Skip to contentSkip to conversation

ath11k: Remove unnecessary data sync to cpu on monitor buffer

PATCH In review Vasanthakumar Thiagarajan 2 participants 3 messages Oct 15, 2020 – Nov 7, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: Remove unnecessary data sync to cpu on monitor buffer

Monitor ring Rx buffer is not really modified between dma map and unmap. So remove the unnecssary data sync before dma unmap. This does not fix any visible issue, found in code review.

Compile tested only.

---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +0 -4
index 0162532..4455e5af 100644
@@ -2856,10 +2856,6 @@ static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
 
 			rxcb = ATH11K_SKB_RXCB(skb);
 
-			dma_sync_single_for_cpu(ab->dev, rxcb->paddr,
-						skb->len + skb_tailroom(skb),
-						DMA_FROM_DEVICE);
-
 			dma_unmap_single(ab->dev, rxcb->paddr,
 					 skb->len + skb_tailroom(skb),
 					 DMA_BIDIRECTIONAL);
Signature · 7 lines
2.7.4


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 8 lines · Vasanthakumar Thiagarajan

Monitor ring Rx buffer is not really modified between dma map and unmap. So remove the unnecssary data sync before dma unmap. This does not fix any visible issue, found in code review.

Compile tested only.

Patch applied to ath-next branch of ath.git, thanks.

bafdbd79aae4 ath11k: Remove unnecessary data sync to cpu on monitor buffer

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Vasanthakumar Thiagarajan
Quoted 8 lines · Vasanthakumar Thiagarajan

Monitor ring Rx buffer is not really modified between dma map and unmap. So remove the unnecssary data sync before dma unmap. This does not fix any visible issue, found in code review.

Compile tested only.

Patch applied to ath-next branch of ath.git, thanks.

bafdbd79aae4 ath11k: Remove unnecessary data sync to cpu on monitor buffer

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k