bus: mhi: core: Remove double locking from mhi_driver_remove()
Subsystems (2)
PATCH 1/1 bus: mhi: core: Remove double locking from mhi_driver_remove()
There is double acquisition of the pm_lock from mhi_driver_remove() function. Remove the read_lock_bh/read_unlock_bh calls for pm_lock taken during a call to mhi_device_put() as the lock is acquired within the function already. This will help avoid a potential kernel panic.
--- drivers/bus/mhi/core/init.c | 2 -- 1 file changed, 2 deletions(-)
drivers/bus/mhi/core/init.c +0 -2
@@ -1276,10 +1276,8 @@ static int mhi_driver_remove(struct device *dev)mutex_unlock (&mhi_chan->mutex); } -read_lock_bh (&mhi_cntrl->pm_lock);while (mhi_dev->dev_wake)mhi_device_put (mhi_dev); -read_unlock_bh (&mhi_cntrl->pm_lock);return 0 ; }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 9 lines · Bhaumik Bhatt
There is double acquisition of the
pm_lockfrommhi_driver_remove()function. Remove the read_lock_bh/read_unlock_bh calls forpm_locktaken during a call tomhi_device_put()as the lock is acquired within the function already. This will help avoid a potential kernel panic.Fixes 189ff97cca53 ("bus: mhi: core: Add support for data transfer")Reported-by Shuah Khan <[email protected]>Signed-off-by Bhaumik Bhatt <[email protected]>
Thanks,
Mani
Quoted 23 lines
--- drivers/bus/mhi/core/init.c | 2 -- 1 file changed, 2 deletions(-)drivers/bus/mhi/core/init.c +0
-2@@ -1276,10 +1276,8 @@ static int mhi_driver_remove(struct device *dev)mutex_unlock (&mhi_chan->mutex); } -read_lock_bh (&mhi_cntrl->pm_lock);while (mhi_dev->dev_wake)mhi_device_put (mhi_dev); -read_unlock_bh (&mhi_cntrl->pm_lock);return 0 ; }Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Manivannan Sadhasivam
AppliedQuoted 9 lines · Bhaumik Bhatt
There is double acquisition of the
pm_lockfrommhi_driver_remove()function. Remove the read_lock_bh/read_unlock_bh calls forpm_locktaken during a call tomhi_device_put()as the lock is acquired within the function already. This will help avoid a potential kernel panic.Fixes 189ff97cca53 ("bus: mhi: core: Add support for data transfer")Reported-by Shuah Khan <[email protected]>Signed-off-by Bhaumik Bhatt <[email protected]>
Applied to mhi-next!
Thanks,
Mani
Quoted 23 lines
--- drivers/bus/mhi/core/init.c | 2 -- 1 file changed, 2 deletions(-)drivers/bus/mhi/core/init.c +0
-2@@ -1276,10 +1276,8 @@ static int mhi_driver_remove(struct device *dev)mutex_unlock (&mhi_chan->mutex); } -read_lock_bh (&mhi_cntrl->pm_lock);while (mhi_dev->dev_wake)mhi_device_put (mhi_dev); -read_unlock_bh (&mhi_cntrl->pm_lock);return 0 ; }Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 11 lines · On Thu, 15 Oct 2020 11:47:51 -0700 you wrote:
There is double acquisition of the
pm_lockfrommhi_driver_remove()function. Remove the read_lock_bh/read_unlock_bh calls forpm_locktaken during a call tomhi_device_put()as the lock is acquired within the function already. This will help avoid a potential kernel panic.Fixes 189ff97cca53 ("bus: mhi: core: Add support for data transfer")Reported-by Shuah Khan <[email protected]>Signed-off-by Bhaumik Bhatt <[email protected]>[...]
Here is the summary with links:
- bus: mhi: core: Remove double locking from mhi_driver_remove()
https://git.kernel.org/qcom/c/9b627c25e708
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html